Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes an issue with dict_merge in network utils #41107

Merged
merged 1 commit into from Nov 30, 2018
Merged

fixes an issue with dict_merge in network utils #41107

merged 1 commit into from Nov 30, 2018

Conversation

privateip
Copy link
Contributor

This change address a problem where the dict_merge function would fail
due to the value being a nested dict. This will now recursively pass
the value back through the dict_merge function.

fixes an issue with dict_merge in network utils
5b743ce 
This change address a problem where the dict_merge function would fail
due to the value being a nested dict.  This will now recursively pass
the value back through the dict_merge function.
@ansibot
Copy link
Contributor

ansibot commented Jun 4, 2018

cc @Qalthos @ganeshrn @gdpak @gundalow @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 4, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Jun 5, 2018
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 13, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 25, 2018

cc @justjais
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2018

cc @NilashishC
click here for bot help

@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 18, 2018
@ansibot ansibot added the community_review In order to be merged, this PR must follow the community review workflow. label Oct 24, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:network This issue/PR relates to code supported by the Ansible Network Team. and removed community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. labels Nov 26, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 29, 2018
@ganeshrn ganeshrn merged commit 2a4be27 into ansible:devel Nov 30, 2018
ganeshrn pushed a commit to ganeshrn/ansible that referenced this pull request Dec 5, 2018
@privateip @ganeshrn
fixes an issue with dict_merge in network utils (ansible#41107)
e48d77b 
This change address a problem where the dict_merge function would fail
due to the value being a nested dict.  This will now recursively pass
the value back through the dict_merge function.
Merge to devel ansible#41107

(cherry picked from commit 2a4be27)

Update changelog

Fix review comments
abadger pushed a commit that referenced this pull request Dec 5, 2018
@privateip @abadger
fixes an issue with dict_merge in network utils (#41107)
799f8e9 
This change address a problem where the dict_merge function would fail
due to the value being a nested dict.  This will now recursively pass
the value back through the dict_merge function.
Merge to devel #41107

(cherry picked from commit 2a4be27)

Update changelog

Fix review comments
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@privateip @kbreit
fixes an issue with dict_merge in network utils (ansible#41107)
dd75175 
This change address a problem where the dict_merge function would fail
due to the value being a nested dict.  This will now recursively pass
the value back through the dict_merge function.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
@privateip privateip deleted the fix-network-utils-dict-merge branch August 5, 2019 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

Assignees

@privateip privateip

Labels
affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@privateip @ansibot @ganeshrn @webknjaz