New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated module with 2.5+ requirements and example #41566

Open
wants to merge 6 commits into
base: devel
from

Conversation

@mglantz

mglantz commented Jun 14, 2018

I've updated the documentation with 2.5+ requirements plus a working example of implementing them.

load_balancing_rules requires frontend_port and also requires backend_port to be passed if not the user has taken special action to enable additional features on the azure subscription. I marked both as required as the backend_port error message doesn't really explain that backend_port needs to be defined except for in a special scenario.

Error message as follows
'''
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Error creating or updating load balancer myLoadBalancer - Azure Error: SubscriptionNotRegisteredForFeature\nMessage: Subscription asdfasdfasdfasdfasdfasdfasdfasdfasdf is not registered for feature Microsoft.Network/AllowILBAllPortsRule required to carry out the requested operation."}
'''

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME
ANSIBLE VERSION

ADDITIONAL INFORMATION

Updated module with 2.5+ requirements and example
I've updated the documentation with 2.5+ requirements plus a working example of implementing them.

load_balancing_rules requires frontend_port and also requires backend_port to be passed if not the user has taken special action to enable additional features on the azure subscription. I marked both as required as the backend_port error message doesn't really explain that backend_port needs to be defined except for in a special scenario.

Error message as follows
'''
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Error creating or updating load balancer myLoadBalancer - Azure Error: SubscriptionNotRegisteredForFeature\nMessage: Subscription asdfasdfasdfasdfasdfasdfasdfasdfasdf is not registered for feature Microsoft.Network/AllowILBAllPortsRule required to carry out the requested operation."}
'''

+label: docsite_pr
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 14, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py:337:27: W291 trailing whitespace

click here for bot help

@yuwzho

This comment has been minimized.

Contributor

yuwzho commented Jun 15, 2018

shipit

Unfortunately your test together with other tests run out of the subscription's resource limit. Please close this pr and reopen it to trigger another build.

@ansibot ansibot removed the needs_triage label Jun 15, 2018

@mglantz mglantz closed this Jun 16, 2018

@mglantz mglantz reopened this Jun 16, 2018

@yuwzho

This comment has been minimized.

Contributor

yuwzho commented Jun 22, 2018

bot_status

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 22, 2018

Components

lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py
support: community
maintainers: haroldwongms nitzmahone trstringer tstringer xscript yuwzho zikalino

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): yuwzho
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@yuwzho

This comment has been minimized.

Contributor

yuwzho commented Aug 23, 2018

from line 310 - line 351, are over indent

# Example for 2.5+ module
- name: Create a master load balancer
azure_rm_loadbalancer:
name: myLoadBalancer
resource_group: myResourceGroup
location: northeurope
backend_address_pools:
- name: myBackendPool
frontend_ip_configurations:
- name: myFrontendIPcfg
public_ip_address: myPublicIP
probes:
- name: myProbe
fail_count: 3
interval: 5
port: 8443
protocol: Http
request_path: "/"
load_balancing_rules:
- name: myLoadBalancingRules
frontend_port: 8443
backend_port: 8443
frontend_ip_configuration: myFrontendIPcfg
load_distribution: SourceIP
protocol: Tcp
backend_address_pool: myBackendPool
probe: myProbe
# Example for <2.5 module
- name: Create a load balancer
azure_rm_loadbalancer:
name: myloadbalancer
location: eastus
resource_group: my-rg
public_ip: mypublicip
probe_protocol: Tcp
probe_port: 80
probe_interval: 10
probe_fail_count: 3
protocol: Tcp
frontend_port_range_start: 80
frontend_port_range_end: 81
backend_port: 8080

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Aug 30, 2018

@mglantz Thanks for the contribution, Could you help to recheck the PR according by @yuwzho's advice? Thanks !

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Sep 17, 2018

@mglantz Thanks for the contribution, Could you help to recheck the PR according by @yuwzho's comment? Thanks !

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Sep 26, 2018

@mglantz Thanks for the contribution, It need you change according by @yuwzho's advice. Thanks!

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Oct 9, 2018

@acozine acozine self-assigned this Oct 10, 2018

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Oct 24, 2018

@mglantz Thanks for the contribution, Are you still here? Could you help change according by @yuwzho's comment? Thanks!

Fixed indention
It was over indent

@mglantz mglantz closed this Oct 24, 2018

@mglantz mglantz reopened this Oct 24, 2018

@mglantz

This comment has been minimized.

mglantz commented Oct 24, 2018

Hey @Fred-sun, sorry for this taking 1000 years. I've fixed it.

@ansibot ansibot removed the stale_ci label Oct 24, 2018

@mglantz

This comment has been minimized.

mglantz commented Oct 24, 2018

@Fred-sun I can't see any errors coming out of Shippable, even though it seems to say that all checks have failed. Let me know. I don't have anything competing for my attention except for this now.

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Oct 24, 2018

@mglantz Thanks for you update, As @yuwzho describe, From line 310 - line 351 both need to be indented two space forward. Thanks!

@mglantz

This comment has been minimized.

mglantz commented Oct 24, 2018

@Fred-sun Forward, aah.

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Oct 24, 2018

@yuwzho Could you help to review this PR again? The contributor has changed. Thanks!

@mglantz

This comment has been minimized.

mglantz commented Oct 24, 2018

@yuwzho Could you help to review this PR again? The contributor has changed. Thanks!

I've changed it so that I follow the same indention as in https://github.com/mglantz/ansible/blob/patch-1/lib/ansible/modules/cloud/azure/azure_rm_aks.py

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 24, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py:323:7: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py:323:7: error EXAMPLES: syntax error: expected <block end>, but found '-'

click here for bot help

@mglantz

This comment has been minimized.

mglantz commented Oct 24, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py:323:7: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py:323:7: error EXAMPLES: syntax error: expected <block end>, but found '-'

click here for bot help

Fixing..

azure_rm_loadbalancer:
name: myLoadBalancer
resource_group: myResourceGroup
location: northeurope

This comment has been minimized.

@yungezz

yungezz Oct 25, 2018

Contributor

location is not necessary

protocol: Tcp
backend_address_pool: myBackendPool
probe: myProbe
# Example for <2.5 module

This comment has been minimized.

@yungezz

yungezz Oct 25, 2018

Contributor

i dont think this is necessary to keep old one. docs has version also

@ansibot ansibot added the stale_ci label Nov 5, 2018

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Nov 22, 2018

@mglantz Thanks for your contribution, Could you help update according by yungezz's comment? Thanks!

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Nov 30, 2018

kindly ping

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Dec 11, 2018

@mglantz Thanks for the contrition, Are you still here? Could you help give a change according by yungezz and yuwzho's comment? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment