New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware Module to perform operations on VNIC #41726

Open
wants to merge 11 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@mohdumar321

mohdumar321 commented Jun 20, 2018

SUMMARY
ISSUE TYPE
  • New Module Pull Request
  • created a new module for performing operations on vmware vnics.
  • tested
COMPONENT NAME

vmware_vnic.py

ANSIBLE VERSION
2.x
ADDITIONAL INFORMATION

mohdumar321 added some commits Jun 5, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 20, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:28:27: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:4:0: ImportError: No module named requests

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:4:0: ImportError: No module named requests

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:4:0: ImportError: No module named 'requests'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:4:0: ModuleNotFoundError: No module named 'requests'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:4:0: ModuleNotFoundError: No module named 'requests'

The test ansible-test sanity --test pep8 [explain] failed with 7 errors:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:11:129: E231 missing whitespace after ','
lib/ansible/modules/cloud/vmware/vmware_vnic.py:11:161: E501 line too long (179 > 160 characters)
lib/ansible/modules/cloud/vmware/vmware_vnic.py:98:10: E211 whitespace before '('
lib/ansible/modules/cloud/vmware/vmware_vnic.py:103:14: E211 whitespace before '('
lib/ansible/modules/cloud/vmware/vmware_vnic.py:103:41: E502 the backslash is redundant between brackets
lib/ansible/modules/cloud/vmware/vmware_vnic.py:104:15: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_vnic.py:106:14: E211 whitespace before '('

The test ansible-test sanity --test shebang [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:1:1: expected module shebang "b'#!/usr/bin/python'" but found: b'#!/usr/bin/env python'

The test ansible-test sanity --test validate-modules [explain] failed with 8 errors:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E203 requests import found, should use ansible.module_utils.urls instead
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E301 No DOCUMENTATION provided
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E310 No EXAMPLES provided
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E314 No ANSIBLE_METADATA provided
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'No module named 'tools''

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 20, 2018

mohdumar321 added some commits Jun 20, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 20, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:56:27: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: missing documentation (or could not parse documentation): 'description'

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 101, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:32:0: ImportError: No module named requests

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:32:0: ImportError: No module named requests

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:32:0: ModuleNotFoundError: No module named 'requests'

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:32:0: ImportError: No module named 'requests'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:32:0: ModuleNotFoundError: No module named 'requests'

The test ansible-test sanity --test pep8 [explain] failed with 7 errors:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:39:129: E231 missing whitespace after ','
lib/ansible/modules/cloud/vmware/vmware_vnic.py:39:161: E501 line too long (179 > 160 characters)
lib/ansible/modules/cloud/vmware/vmware_vnic.py:126:10: E211 whitespace before '('
lib/ansible/modules/cloud/vmware/vmware_vnic.py:131:14: E211 whitespace before '('
lib/ansible/modules/cloud/vmware/vmware_vnic.py:131:41: E502 the backslash is redundant between brackets
lib/ansible/modules/cloud/vmware/vmware_vnic.py:132:15: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_vnic.py:134:14: E211 whitespace before '('

The test ansible-test sanity --test validate-modules [explain] failed with 9 errors:

lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E203 requests import found, should use ansible.module_utils.urls instead
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E305 DOCUMENTATION.author: required key not provided @ data['author']. Got None
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E305 DOCUMENTATION.description: required key not provided @ data['description']. Got None
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E305 DOCUMENTATION.version_added: required key not provided @ data['version_added']. Got None
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E307 version_added should be 2.7. Currently 0.0
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E316 ANSIBLE_METADATA.supported_by: not a valid value for dictionary value @ data['supported_by']. Got ''
lib/ansible/modules/cloud/vmware/vmware_vnic.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'No module named 'tools''

click here for bot help

@ansibot ansibot removed the ci_verified label Jun 20, 2018

@@ -0,0 +1,137 @@
#!/usr/bin/python
# -*- coding: utf-8 -*-

This comment has been minimized.

@Akasurde

Akasurde Jun 20, 2018

Member

Add license boilerplate

# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
ANSIBLE_METADATA = {'metadata_version': '1.1',
'status': ['preview'],
'supported_by': ''}

This comment has been minimized.

@Akasurde

Akasurde Jun 20, 2018

Member

'supported_by': 'community'}

DOCUMENTATION = '''
---
module: vmware_vnic

This comment has been minimized.

@Akasurde

Akasurde Jun 20, 2018

Member

I would recommend to rename this to vmware_guest_nic_manager or vmware_guest_nic or something, this will match will existing naming scheme.

DOCUMENTATION = '''
---
module: vmware_vnic
short_description: Manage Operations on vmware vnics

This comment has been minimized.

@Akasurde

Akasurde Jun 20, 2018

Member

Please add description and related documentation as this will be used by both docs.ansible.com and ansible-doc command.

def get_args():
argument_spec = vmware_argument_spec()
argument_spec.update(dict(hostname=dict(type='str', required=True),

This comment has been minimized.

@Akasurde

Akasurde Jun 20, 2018

Member

hostname, username, password and port are already part of vmware_argument_spec()

args = get_args()
# connect to vc
si = SmartConnect(

This comment has been minimized.

@Akasurde

Akasurde Jun 20, 2018

Member

use existing method connect_to_api from module_utils/vmware.py

content = si.RetrieveContent()
print ('Searching for VM {}').format(args.params['name'])
vm_obj = get_obj(content, [vim.VirtualMachine], args.params['name'])

This comment has been minimized.

@Akasurde

Akasurde Jun 20, 2018

Member

use PyVmomi helper class from module_utils/vmware.py

if vm_obj:
update_virtual_nic_state(si, vm_obj, args.params['nic_number'], args.params['nic_state'])
print ('VM NIC {} successfully' \

This comment has been minimized.

@Akasurde

Akasurde Jun 20, 2018

Member

Don't use print statements in module.

username=dict(type='str', required=True),
password=dict(type='str', required=True),
port=dict(type='int', default='443'),
name=dict(type='str', required=True),

This comment has been minimized.

@Akasurde

Akasurde Jun 20, 2018

Member

String is default argument type so not necessary.

virtual_nic_spec.operation = \
vim.vm.device.VirtualDeviceSpec.Operation.remove \
if new_nic_state == 'delete' \
else vim.vm.device.VirtualDeviceSpec.Operation.edit

This comment has been minimized.

@Akasurde

Akasurde Jun 20, 2018

Member

Can we add new NICs as well ?

This comment has been minimized.

@mohdumar321

mohdumar321 Jun 21, 2018

@Akasurde : Thanks for the valuable suggestions. I will update as suggested.

Currently we can delete , connect and disconnect vnics but later we can add functionality to add vnics as well.

@ansibot ansibot removed the needs_triage label Jun 20, 2018

@ansibot ansibot added the stale_ci label Jul 5, 2018

@Akasurde

This comment has been minimized.

Member

Akasurde commented Jul 19, 2018

@mohdumar321 Are you working on this ? needs_info

@ansibot ansibot added the needs_info label Jul 19, 2018

@mohdumar321

This comment has been minimized.

mohdumar321 commented Jul 23, 2018

@Akasurde: I am almost done will commit soon.

@ansibot ansibot removed the needs_info label Jul 23, 2018

commit with new changes- - Module name change -Documentation update -…
… Boilerplate added - Example updated - Removed print statements

Done changes 
- Module Name Change
- Documentation update
- Boilerplate added
- Example updated
- Removed print statements
@mohdumar321

This comment has been minimized.

mohdumar321 commented Jul 24, 2018

@Akasurde: I have committed code with changes. Unable to identify where it got failed Please review it and if needed please update because I am unable to identify.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 24, 2018

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:100:27: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:175:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:177:15: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:76:0: ImportError: No module named requests

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:76:0: ImportError: No module named requests

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:76:0: ImportError: No module named 'requests'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:76:0: ModuleNotFoundError: No module named 'requests'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:76:0: ModuleNotFoundError: No module named 'requests'

The test ansible-test sanity --test pep8 [explain] failed with 19 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:59:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:64:31: W291 trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:69:23: W291 trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:77:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:78:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:84:129: E231 missing whitespace after ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:84:161: E501 line too long (179 > 160 characters)
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:90:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:141:20: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:141:52: E203 whitespace before ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:142:31: E126 continuation line over-indented for hanging indent
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:171:10: E211 whitespace before '('
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:175:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:177:41: E502 the backslash is redundant between brackets
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:178:15: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:179:31: E203 whitespace before ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:179:32: E231 missing whitespace after ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:182:31: E203 whitespace before ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:182:32: E231 missing whitespace after ','

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:0:0: E203 requests import found, should use ansible.module_utils.urls instead
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:0:0: E306 version_added is not a valid version number: '2.x'
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'No module named 'pyVmomi''

click here for bot help

@ansibot ansibot added the ci_verified label Jul 24, 2018

@ansibot ansibot removed the ci_verified label Jul 24, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 24, 2018

The test ansible-test sanity --test pylint [explain] failed with 5 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:81:11: undefined-variable Undefined variable 'requests'
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:82:4: undefined-variable Undefined variable 'requests'
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:94:27: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:169:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:171:15: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:73:0: ImportError: No module named pyVmomi

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:73:0: ImportError: No module named pyVmomi

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:73:0: ImportError: No module named 'pyVmomi'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:73:0: ModuleNotFoundError: No module named 'pyVmomi'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:73:0: ModuleNotFoundError: No module named 'pyVmomi'

The test ansible-test sanity --test pep8 [explain] failed with 17 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:56:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:61:31: W291 trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:66:23: W291 trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:78:129: E231 missing whitespace after ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:78:161: E501 line too long (179 > 160 characters)
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:84:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:135:20: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:135:52: E203 whitespace before ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:136:31: E126 continuation line over-indented for hanging indent
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:165:10: E211 whitespace before '('
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:169:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:171:41: E502 the backslash is redundant between brackets
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:172:15: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:173:31: E203 whitespace before ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:173:32: E231 missing whitespace after ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:176:31: E203 whitespace before ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:176:32: E231 missing whitespace after ','

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:0:0: E306 version_added is not a valid version number: '2.x'
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'No module named 'pyVmomi''

click here for bot help

@ansibot ansibot added the ci_verified label Jul 24, 2018

@ansibot ansibot removed the ci_verified label Jul 24, 2018

mohdumar321 added some commits Jul 24, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 24, 2018

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:112:27: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:185:15: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:89:0: ImportError: No module named pyVmomi

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:89:0: ImportError: No module named pyVmomi

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:89:0: ImportError: No module named 'pyVmomi'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:89:0: ModuleNotFoundError: No module named 'pyVmomi'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:89:0: ModuleNotFoundError: No module named 'pyVmomi'

The test ansible-test sanity --test pep8 [explain] failed with 13 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:63:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:68:31: W291 trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:73:23: W291 trailing whitespace
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:88:1: E303 too many blank lines (3)
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:100:1: E265 block comment should start with '# '
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:103:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:145:55: E203 whitespace before ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:146:9: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:151:87: E203 whitespace before ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:186:31: E203 whitespace before ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:186:32: E231 missing whitespace after ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:189:31: E203 whitespace before ','
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:189:32: E231 missing whitespace after ','

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:0:0: E307 version_added should be 2.7. Currently 2.4
lib/ansible/modules/cloud/vmware/vmware_guest_nic_manager.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'No module named 'pyVmomi''

click here for bot help

@ansibot ansibot added the ci_verified label Jul 24, 2018

@ansibot ansibot added the stale_ci label Aug 1, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment