New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added timestamps to response of asa_command and iosxr_command modules #42103

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@vaneuk

vaneuk commented Jun 29, 2018

SUMMARY

Added information about time when command was issued on remote device.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iosxr_command
asa_command

ANSIBLE VERSION
ansible 2.6.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/srv/ansible_modules']
  ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]
ADDITIONAL INFORMATION

example playbook

- name: collect show commands from devices
  hosts: test_group
  connection: network_cli

  tasks:

    - name: collect show commands
      iosxr_command:
        commands:
          - "show clock"
          - "show run vrf mgmt"
      register: output

    - name: debug task
      debug:
        var: output

before

ok: [R01] => {
    "output": {
        "changed": false, 
        "failed": false, 
        "stdout": [
            "16:23:19.904 MSK Fri Jun 29 2018", 
            "vrf mgmt\n!"
        ], 
        "stdout_lines": [
            [
                "16:23:19.904 MSK Fri Jun 29 2018"
            ], 
            [
                "vrf mgmt", 
                "!"
            ]
        ]
    }
}

after

ok: [R01] => {
    "output": {
        "changed": false, 
        "failed": false, 
        "stdout": [
            "16:24:58.318 MSK Fri Jun 29 2018", 
            "vrf mgmt\n!"
        ], 
        "stdout_lines": [
            [
                "16:24:58.318 MSK Fri Jun 29 2018"
            ], 
            [
                "vrf mgmt", 
                "!"
            ]
        ], 
        "timestamps": [
            "2018-06-29T16:24:58", 
            "2018-06-29T16:24:58"
        ]
    }
}
@ansibot

This comment has been minimized.

@mattclay

This comment has been minimized.

Member

mattclay commented Jun 29, 2018

@vaneuk

This comment has been minimized.

vaneuk commented Jul 8, 2018

@Qalthos @ganeshrn @gdpak @gundalow @kedarX @ogenstad @privateip @rcarrillocruz @trishnaguha @mattclay
Hi, could someone kindly take a look at this PR? Thanks!

@ansibot ansibot added the stale_ci label Jul 16, 2018

@vaneuk vaneuk closed this Jul 18, 2018

@vaneuk vaneuk reopened this Jul 18, 2018

@vaneuk

This comment has been minimized.

vaneuk commented Jul 18, 2018

@Qalthos @ganeshrn @gdpak @gundalow @kedarX @ogenstad @privateip @rcarrillocruz @trishnaguha @mattclay
Hi, firendly ping ). Could someone take a look at this PR?

@ansibot ansibot removed the stale_ci label Jul 18, 2018

@ansibot ansibot added the stale_ci label Jul 26, 2018

@ansibot ansibot removed the core_review label Aug 3, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 27, 2018

@gundalow

This comment has been minimized.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment