New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] RDS cluster module #42128

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@s-hertel
Contributor

s-hertel commented Jun 29, 2018

SUMMARY

New RDS cluster module. I'm going to add some more tests that modify cloudwatch logs and don't use the default VPC and subnet.

Rather than have an unreasonably large rds_instance module to handle Aurora, I'm breaking it into two modules, rds_instance and rds_cluster to be used in tandem.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/rds_cluster.py

ANSIBLE VERSION
ansible 2.7.0.dev0
@ansibot

This comment has been minimized.

Contributor

ansibot commented Jun 29, 2018

The test ansible-test sanity --test pylint [explain] failed with 5 errors:

lib/ansible/modules/cloud/amazon/rds_cluster.py:529:63: undefined-variable Undefined variable 'restore_time_cluster'
lib/ansible/modules/cloud/amazon/rds_cluster.py:549:40: too-many-format-args Too many arguments for format string
lib/ansible/modules/cloud/amazon/rds_cluster.py:603:79: undefined-variable Undefined variable 'params'
lib/ansible/modules/cloud/amazon/rds_cluster.py:604:43: undefined-variable Undefined variable 'params'
lib/ansible/modules/cloud/amazon/rds_cluster.py:612:12: duplicate-except Catching previously caught exception type ClientError

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/cloud/amazon/rds_cluster.py:541:13: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/amazon/rds_cluster.py:658:17: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/amazon/rds_cluster.py:764:21: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/amazon/rds_cluster.py:860:13: E124 closing bracket does not match visual indentation
lib/ansible/modules/cloud/amazon/rds_cluster.py:880:161: E501 line too long (163 > 160 characters)

click here for bot help

@dmsimard

This comment has been minimized.

Contributor

dmsimard commented Aug 8, 2018

@s-hertel this PR hasn't been updated for a while -- do you plan on including it in #43789 ? Is it usable in it's current state ?

@s-hertel

This comment has been minimized.

Contributor

s-hertel commented Aug 8, 2018

I have local changes that I need to clean up a little more before pushing to this branch will try to get to that this week. if you check the rds_instance PR I have tests that use the local version to test Aurora that are using this module.

@ansibot ansibot removed the support:core label Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment