New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override openstack keystone endpoint #42376

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@emonty
Contributor

emonty commented Jul 5, 2018

SUMMARY

For bootstrapping installations, keystone needs to be manipulated before
the service catalog is there. While identity_endpoint_override can be
provided in clouds.yaml - in this case it's only a useful setting during
the bootstrap stage, which means it would be more handy to be in a
module parameter.

We don't just add the parameter to the main module kwargs because ALL of
the services in openstack potentially have an endpoint_override setting
but only specific ones are useful - and only in certain modules.

ISSUE TYPE
  • Feature Pull Request
ADDITIONAL INFORMATION

Inspired by openstack/openstack-ansible-plugins@cc7c924 and is part of allowing the openstack-ansible team to get rid of things.

Add ability to override openstack keystone endpoint
For bootstrapping installations, keystone needs to be manipulated before
the service catalog is there. While identity_endpoint_override can be
provided in clouds.yaml - in this case it's only a useful setting during
the bootstrap stage, which means it would be more handy to be in a
module parameter.

We don't just add the parameter to the main module kwargs because ALL of
the services in openstack potentially have an endpoint_override setting
but only specific ones are useful - and only in certain modules.
@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 5, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:142:0: syntax-error keyword argument repeated (<string>, line 142)

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 101, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:142:0: SyntaxError: keyword argument repeated

The test ansible-test sanity --test import --python 2.7 [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:0:0: SyntaxError: keyword argument repeated (os_keystone_service.py, line 142) (in /root/ansible/test/runner/.tox/minimal-py27/bin/importer.py:82)
lib/ansible/modules/cloud/openstack/os_keystone_service.py:142:0: SyntaxError: keyword argument repeated

The test ansible-test sanity --test import --python 3.5 [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:0:0: SyntaxError: keyword argument repeated (os_keystone_service.py, line 142) (in /root/ansible/test/runner/.tox/minimal-py35/bin/importer.py:82)
lib/ansible/modules/cloud/openstack/os_keystone_service.py:142:8: SyntaxError: keyword argument repeated

The test ansible-test sanity --test import --python 3.6 [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:0:0: SyntaxError: keyword argument repeated (os_keystone_service.py, line 142) (in /root/ansible/test/runner/.tox/minimal-py36/bin/importer.py:82)
lib/ansible/modules/cloud/openstack/os_keystone_service.py:142:8: SyntaxError: keyword argument repeated

The test ansible-test sanity --test import --python 3.7 [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:0:0: SyntaxError: keyword argument repeated (os_keystone_service.py, line 142) (in /root/ansible/test/runner/.tox/minimal-py37/bin/importer.py:82)
lib/ansible/modules/cloud/openstack/os_keystone_service.py:142:8: SyntaxError: keyword argument repeated

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_keystone_endpoint.py:0:0: E323 "identity_endpoint_override" is listed in DOCUMENTATION.options, but not accepted by the module
lib/ansible/modules/cloud/openstack/os_keystone_service.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_keystone_service.py:142:8: python-syntax-error keyword argument repeated (<unknown>, line 142)

click here for bot help

@openstack-zuul

This comment has been minimized.

openstack-zuul bot commented Jul 5, 2018

Build succeeded (third-party-check pipeline).

@mattclay

This comment has been minimized.

Member

mattclay commented Jul 27, 2018

@emonty Are you still working on this?

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment