New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for trustcacerts option in java_cert module #42555

Open
wants to merge 10 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@goforgold

goforgold commented Jul 10, 2018

SUMMARY

Added support for trustcacerts option in java_cert module

Fixes #37707

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

java_cert

ANSIBLE VERSION
ansible 2.5.5
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /bin/ansible
  python version = 2.7.5 (default, Apr 11 2018, 07:36:10) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

goforgold added some commits Jul 10, 2018

Adding support for trustcacerts keytool option
Adding support for -trustcacerts option in keytool
@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 10, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 10, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/system/java_cert.py:319:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/system/java_cert.py:203:64: E128 continuation line under-indented for visual indent
lib/ansible/modules/system/java_cert.py:204:64: E128 continuation line under-indented for visual indent
lib/ansible/modules/system/java_cert.py:205:64: E128 continuation line under-indented for visual indent
lib/ansible/modules/system/java_cert.py:206:64: E128 continuation line under-indented for visual indent
lib/ansible/modules/system/java_cert.py:319:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/system/java_cert.py:0:0: E309 version_added for new option (trust_ca_certs) should be 2.7. Currently 0.0
lib/ansible/modules/system/java_cert.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "trust_ca_certs" does not match the documentation ([True, False])

click here for bot help

@ansibot ansibot removed the ci_verified label Jul 10, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 10, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/system/java_cert.py:111:1: W293 blank line contains whitespace

click here for bot help

@webknjaz webknjaz removed the needs_triage label Jul 10, 2018

@goforgold

This comment has been minimized.

goforgold commented Jul 12, 2018

@haad

Please help to look into my proposed changes.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 27, 2018

@goforgold this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 27, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/java_cert.py:0:0: E309 version_added for new option (trust_ca_certs) should be 2.8. Currently 2.7

click here for bot help

@ansibot ansibot removed the ci_verified label Nov 27, 2018

@goforgold goforgold changed the title from Added support for trustcacerts option in java_cert module to Added support for trustcacerts option in java_cert system module Nov 28, 2018

@goforgold goforgold changed the title from Added support for trustcacerts option in java_cert system module to Added support for trustcacerts option in java_cert module Nov 28, 2018

@goforgold goforgold closed this Nov 28, 2018

@goforgold goforgold reopened this Nov 28, 2018

@goforgold goforgold closed this Nov 28, 2018

@goforgold goforgold reopened this Nov 28, 2018

@ansibot ansibot added the stale_ci label Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment