New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New modules for the administration of IBM DataPower Gateway with Ansible #42720

Open
wants to merge 26 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@dgraum

dgraum commented Jul 13, 2018

SUMMARY

This is the beginning of the implementation of a solution to manage the IBM DataPower Gateway (https://www.ibm.com/products/datapower-gateway) with Ansible. I suggest that this development be stored in a new "modules / appliance" directory that could serve as a collaboration space for the technologies produced by this and other technology companies.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • idg_domain
ANSIBLE VERSION
ansible 2.6.0
  config file = /home/dgrau/Documents/Projects/idg_ansible/datapower-ansible/ansible.cfg
  configured module search path = [u'/home/dgrau/Documents/Projects/idg_ansible/datapower-ansible/library/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.15 (default, May 15 2018, 15:37:31) [GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]
ADDITIONAL INFORMATION

The combination of both technologies promises many advantages for the users of these IBM devices and their new proposals in the cloud.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 13, 2018

@dgraum this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 13, 2018

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/module_utils/appliance/ibm/idg_common.py:63:16: undefined-variable Undefined variable 'module'
lib/ansible/module_utils/appliance/ibm/idg_common.py:68:16: undefined-variable Undefined variable 'module'
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:138:53: multiple-statements More than one statement on a single line

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:13:0: ImportError: No module named six

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:13:0: ImportError: No module named six

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:13:0: ImportError: No module named 'six'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:13:0: ModuleNotFoundError: No module named 'six'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:13:0: ModuleNotFoundError: No module named 'six'

The test ansible-test sanity --test pep8 [explain] failed with 10 errors:

lib/ansible/module_utils/appliance/ibm/idg_common.py:24:42: E261 at least two spaces before inline comment
lib/ansible/module_utils/appliance/ibm/idg_common.py:25:44: E261 at least two spaces before inline comment
lib/ansible/module_utils/appliance/ibm/idg_common.py:26:48: E261 at least two spaces before inline comment
lib/ansible/module_utils/appliance/ibm/idg_common.py:31:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/appliance/ibm/idg_common.py:43:22: E201 whitespace after '{'
lib/ansible/module_utils/appliance/ibm/idg_common.py:43:57: E202 whitespace before '}'
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:22:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:134:49: E127 continuation line over-indented for visual indent
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:138:52: E701 multiple statements on one line (colon)
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:144:161: E501 line too long (178 > 160 characters)

The test ansible-test sanity --test use-compat-six [explain] failed with 1 error:

lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:13:1: use `ansible.module_utils.six` instead of `six`

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 7, 2018

The test ansible-test sanity --test pep8 [explain] failed with 9 errors:

lib/ansible/module_utils/appliance/ibm/idg_common.py:82:161: E501 line too long (168 > 160 characters)
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:29:18: E225 missing whitespace around operator
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:30:15: E225 missing whitespace around operator
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:31:15: E225 missing whitespace around operator
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:62:18: E225 missing whitespace around operator
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:63:17: E225 missing whitespace around operator
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:88:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:143:35: E226 missing whitespace around arithmetic operator
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:230:161: E501 line too long (168 > 160 characters)

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 7, 2018

@dgraum this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 8, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:56:58: undefined-variable Undefined variable 're'

The test ansible-test sanity --test pep8 [explain] failed with 9 errors:

lib/ansible/module_utils/appliance/ibm/idg_common.py:72:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/module_utils/appliance/ibm/idg_common.py:72:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:156:19: E225 missing whitespace around operator
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:273:20: E225 missing whitespace around operator
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:274:18: E225 missing whitespace around operator
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:275:14: E225 missing whitespace around operator
lib/ansible/module_utils/appliance/ibm/idg_rest_mgmt.py:276:22: E225 missing whitespace around operator
lib/ansible/modules/appliance/ibm/idg_domain.py:456:67: E261 at least two spaces before inline comment
lib/ansible/modules/appliance/ibm/idg_domain.py:520:84: E127 continuation line over-indented for visual indent

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/appliance/ibm/idg_domain.py:0:0: E307 version_added should be 2.8. Currently 2.7

click here for bot help

@ansibot ansibot added the ci_verified label Sep 8, 2018

@gundalow

Hi,
Thank you for this PR.
I wonder if we can find a better directory for this than appliance/ibm. Do any of the existing directory suite this?

What exactly is IBM DataPower Gateway?

# Connection agreements
BASIC_HEADERS = {"Content-Type": "application/json"}
ANSIBLE_VERSION = '2.7'

This comment has been minimized.

@gundalow

gundalow Nov 19, 2018

Contributor

Their should be a variable you can read in, rather than hardcoding this

This comment has been minimized.

@dgraum

dgraum Nov 19, 2018

Hi John!

IBM DataPower® Gateway serves as the enterprise-grade, field-proven application integration for SOA and REST and security-rich API gateway.
This technology has maintained steady growth and is seen as an important component of IBM's cloud strategy.

https://www.ibm.com/products/datapower-gateway

I also do not feel very comfortable with the current route, but I did not find a position that I could reuse, maybe something like: gateway, api, ...?

Thanks to the corrections, we will work to ensure that the appropriate corrections are made.

Thank you for your attention.

@ansibot ansibot added needs_revision and removed core_review labels Nov 19, 2018

@ansibot ansibot removed the support:core label Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment