New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert implicit AWS retry into boto3 events. #42766

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@orthanc
Contributor

orthanc commented Jul 13, 2018

SUMMARY

This replaces the Decorator that supports "implicit retries" (aws_retry=True) for boto3 clients with a more idiomatic (but functionally equivalent) implementation based on boto3 extension events.

The only functional differenes between this and the previous implementation are:

  • All boto clients (retrying or not) have a aws_retry_supported boolean property that allows common code to detect if retries are enabled or not
  • retry_decorator can also be passed to the boto3_conn method as well as the AwsModule
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws

ANSIBLE VERSION
ansible 2.7.0.dev0 (change-implicit-retry-to-boto-events 7bd85de767) last updated 2018/07/29 17:46:14 (GMT +1300)
  config file = None
  configured module search path = [u'USER_HOME/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = ANSIBLE_HOME/lib/ansible
  executable location = ANSIBLE_HOME/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]
@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 14, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/ec2.py:184:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/ec2.py:184:1: W293 blank line contains whitespace

click here for bot help

@orthanc orthanc force-pushed the orthanc:change-implicit-retry-to-boto-events branch Jul 14, 2018

@ansibot ansibot added the stale_ci label Jul 23, 2018

Update implicit aws_retry utility to enhance the boto client directly
using events rather than wrapping it.

This is functionally equivalent to the previous implementation but is a
more idiomatic way to extend boto.

@orthanc orthanc force-pushed the orthanc:change-implicit-retry-to-boto-events branch to 7bd85de Jul 29, 2018

@ansibot ansibot removed the stale_ci label Jul 29, 2018

@orthanc orthanc changed the title from WIP: Convert implicit AWS retry into boto3 events. to Convert implicit AWS retry into boto3 events. Jul 29, 2018

@orthanc

This comment has been minimized.

Contributor

orthanc commented Jul 29, 2018

ready_for_review I believe the unstable tests are unrelated and just associated becuase this is a change to module_utils.

@ansibot ansibot added needs_revision and removed WIP labels Jul 29, 2018

@gundalow gundalow added the ci_verified label Aug 2, 2018

@ansibot ansibot added the stale_ci label Aug 10, 2018

@orthanc orthanc closed this Aug 24, 2018

@orthanc orthanc reopened this Aug 24, 2018

@ansibot ansibot added needs_revision and removed stale_ci labels Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment