New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing some yamllint issues #42775

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@bbaassssiiee
Member

bbaassssiiee commented Jul 13, 2018

SUMMARY

yamllint is a python module for code quality. These changesfix issues like too many blank lines, indentation, quoting, etc.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-galaxy generated content

ANSIBLE VERSION
ansible 2.6.1
  config file = None
  configured module search path = [u'/Users/bas/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15 (default, Jun 17 2018, 12:46:58) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

ADDITIONAL INFORMATION
./vars/main.yml
  2:27      error    no new line character at the end of file  (new-line-at-end-of-file)

./tasks/main.yml
  2:28      error    no new line character at the end of file  (new-line-at-end-of-file)

./tests/test.yml
  5:17      error    no new line character at the end of file  (new-line-at-end-of-file)

./meta/main.yml
  57:42     error    no new line character at the end of file  (new-line-at-end-of-file)

./defaults/main.yml
  2:31      error    no new line character at the end of file  (new-line-at-end-of-file)

./handlers/main.yml
  2:31      error    no new line character at the end of file  (new-line-at-end-of-file)
hosts: localhost
gather_facts: false
connection: local
vars:
apb_action: deprovision
roles:
- role: {{ role_name }}

This comment has been minimized.

@jborean93

jborean93 Jul 19, 2018

Contributor

This shouldn't be a yamlint issue? When defining a list the - can be on the same level as the parent of indented. For example these all represent the same value.

var:
- a
- b

var:
  - a
  - b

var:
    - a
    - b

This comment has been minimized.

@bbaassssiiee

bbaassssiiee Jul 19, 2018

Member

yamllint has a default, a .yamllint file allows overriding for your coding standards.
.yamllint

@jborean93 jborean93 removed the needs_triage label Jul 19, 2018

@ansibot ansibot added the stale_ci label Jul 27, 2018

@ansibot ansibot added the core_review label Oct 24, 2018

@maxamillion maxamillion added the docs label Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment