Allow to use task retries without until block #43128
Conversation
Proposal discussion at: ansible/proposals#132 |
Any update on this? |
@dagwieers @bcoca - any update here? looks from the proposal that the idea has merit but haven't seen any action on code reviews here in the PR? |
@barlik can you resolve conflicts? |
Bump |
I've rebased the code and fixed merge conflicts. It's been a very long time since I've created this PR so hopefully everything still works. |
Is this PR still open? Would be very handy to have... |
@bcoca can you give this a review please? If you're busy is there a different person who is available to review this? |
@caleb15 this is not blocked on me, anyone can review, it is on my list .. but i have a long list |
@caleb15 alas, I can't review python changes. The docs portion LGTM. |
as noted in meeting, we need more tests for current behaviour before we can proceed. also some had issues with the current implementation, will leave up to them to add specific comments. |
SUMMARY
This change will make task retries work without having an
until
block. This is useful in situations when you are not interested in the output value and/or you simply want to retry on a failure. This allows you to omitregister
anduntil
parameters and makes the task easier to read.ISSUE TYPE
COMPONENT NAME
core engine
ANSIBLE VERSION
ADDITIONAL INFORMATION
The change will allow you to simplify:
into:
This PR also fixes a small bug (inconsistency) whereby having
retries:
without a value defaults to 2 retries instead of 3.