New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updating sql server facts #43323

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@zikalino
Contributor

zikalino commented Jul 26, 2018

SUMMARY

Adding missing SQL Server facts module.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_sqlserver_facts

ANSIBLE VERSION

2.6

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

Contributor

ansibot commented Jul 26, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlserver_facts.py:0:0: E309 version_added for new option (format) should be 2.7. Currently 0.0

click here for bot help

@@ -16,7 +16,7 @@
DOCUMENTATION = '''
---
module: azure_rm_sqlserver_facts
version_added: "2.5"
version_added: "2.7"

This comment has been minimized.

@s-hertel

s-hertel Jul 27, 2018

Contributor

Was this meant to be nested under the new format option?

This comment has been minimized.

@zikalino

zikalino Aug 17, 2018

Contributor

yes

@ansibot ansibot added the stale_ci label Aug 4, 2018

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Aug 14, 2018

@zikalino does this PR ready for review, please help confirm? Thanks!

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Aug 15, 2018

@zikalino Could you help to confirm the PR ready for review or not? Thanks!

1 similar comment
@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Aug 22, 2018

@zikalino Could you help to confirm the PR ready for review or not? Thanks!

@ansibot

This comment has been minimized.

@zikalino zikalino changed the title from [WIP] adding sql server facts to [WIP] Updating sql server facts Sep 2, 2018

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Sep 20, 2018

@zikalino Could you help confirm that do you have finished this PR change? Thanks!

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Dec 4, 2018

kindly ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment