ec2_tag: move to boto3, implemented diff and max_attempts support

[hryamzik]

SUMMARY

• fixed issue with role-based profiles by moving to boto3
• added diff support
• added max_attempts support

ISSUE TYPE

• Feature Pull Request
• Bugfix Pull Request

COMPONENT NAME

ec2_tag

ANSIBLE VERSION

2.6.1

ADDITIONAL INFORMATION

Relates to #43348.

[ansibot]

cc @lwade
click here for bot help

[ansibot]

Hi @hryamzik,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/modules/cloud/amazon/ec2_tag.py:147:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/amazon/ec2_tag.py:156:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/amazon/ec2_tag.py:183:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/cloud/amazon/ec2_tag.py:220:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test no-dict-iteritems [explain] failed with 5 errors:

lib/ansible/modules/cloud/amazon/ec2_tag.py:197:99: use `dict.items` or `ansible.module_utils.six.iteritems` instead of `dict.iteritems`
lib/ansible/modules/cloud/amazon/ec2_tag.py:213:102: use `dict.items` or `ansible.module_utils.six.iteritems` instead of `dict.iteritems`
lib/ansible/modules/cloud/amazon/ec2_tag.py:223:33: use `dict.items` or `ansible.module_utils.six.iteritems` instead of `dict.iteritems`
lib/ansible/modules/cloud/amazon/ec2_tag.py:228:80: use `dict.items` or `ansible.module_utils.six.iteritems` instead of `dict.iteritems`
lib/ansible/modules/cloud/amazon/ec2_tag.py:229:80: use `dict.items` or `ansible.module_utils.six.iteritems` instead of `dict.iteritems`

The test ansible-test sanity --test no-dict-iterkeys [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_tag.py:225:29: use `dict.keys` or `for key in dict:` instead of `dict.iterkeys`

The test ansible-test sanity --test pep8 [explain] failed with 19 errors:

lib/ansible/modules/cloud/amazon/ec2_tag.py:127:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/amazon/ec2_tag.py:133:37: E231 missing whitespace after ','
lib/ansible/modules/cloud/amazon/ec2_tag.py:147:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/amazon/ec2_tag.py:149:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/ec2_tag.py:150:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/ec2_tag.py:152:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/ec2_tag.py:153:9: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/amazon/ec2_tag.py:155:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/ec2_tag.py:156:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/amazon/ec2_tag.py:183:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/amazon/ec2_tag.py:197:85: E231 missing whitespace after ','
lib/ansible/modules/cloud/amazon/ec2_tag.py:213:85: E231 missing whitespace after ','
lib/ansible/modules/cloud/amazon/ec2_tag.py:220:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/amazon/ec2_tag.py:222:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/ec2_tag.py:223:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/ec2_tag.py:225:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/ec2_tag.py:227:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/ec2_tag.py:228:9: E121 continuation line under-indented for hanging indent
lib/ansible/modules/cloud/amazon/ec2_tag.py:229:17: E241 multiple spaces after ':'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_tag.py:0:0: E309 version_added for new option (max_attempts) should be 2.7. Currently 0.0

click here for bot help

[ansibot]

The test ansible-test sanity --test no-dict-iteritems [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_tag.py:198:100: use `dict.items` or `ansible.module_utils.six.iteritems` instead of `dict.iteritems`

click here for bot help

[s-hertel]

There is another pull request for this in the works right now (#39712). Do you mind testing it out and seeing if it meets your needs?

[hryamzik]

Oh, I've missed it. That PR doesn't add diff and retries options that really help me with large amount of volumes.

[hryamzik]

Looks like you've been waiting for a new PR to merge a previous one and get conflicts, lol.

[ansibot]

cc @flowerysong
click here for bot help

[hryamzik]

Hold on, I'm trying to resolve conflicts. Not sure how to tune retries settings for module.client('ec2')...

[hryamzik]

@s-hertel I didn;t manage to reproduce any connection issues with a new code but it doesn't support diff, AttributeError: 'AnsibleAWSModule' object has no attribute '_diff'. Any ideas how to fix this?

I also failed to find a way to push configuration settings to AnsibleAWSModule.

[ansibot]

cc @jillr @tremble
click here for bot help

[ansibot]

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

• lib/ansible/modules/cloud/amazon/ec2_tag.py -> https://galaxy.ansible.com/amazon/aws

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md