[WIP] Decouple display from config initialization #43519
+95
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
WIP
|
The test |
This is an attempt to give ansible the ability to print out errors with the config code. It does succeed in decoupling display from config. Unfortunately, the structure of config and cli currently means that you have to load a bunch of other pieces of code which need config before you get to process the code which could print out the config errors. Since those fail without config, those cause the whole thing to break down. It could be worthwhile to continue in this vein, reorganizing the code so that we can do all of our static loading (option parsing and config loading) up front before moving on to the rest of the code which needs to utilize config but before that happens I hope to move display() to using a logging framework. If that happens, we won't need this anyway.
abadger
force-pushed
the
decouple-display-from-config-initialization
branch
from
bc8ef4e to
cc8e72b
Compare
ansibot
removed
the
ci_verified
nitzmahone
requested changes
Aug 1, 2018
| """ Display a message to the user | ||
|
|
||
| Note: msg *must* be a unicode string to prevent UnicodeError tracebacks. | ||
| Note: color is deprecated. Use type instead. |
jborean93
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
ansibot
added
pre_azp
ansibot
added
needs_rebase
ansibot
added
the
stale_pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to give ansible the ability to print out errors with
the config code. It does succeed in decoupling display from config.
Unfortunately, the structure of config and cli currently means that you
have to load a bunch of other pieces of code which need config before
you get to process the code which could print out the config errors.
Since those fail without config, those cause the whole thing to break
down.
It could be worthwhile to continue in this vein, reorganizing the code
so that we can do all of our static loading (option parsing and config
loading) up front before moving on to the rest of the code which needs
to utilize config but before that happens I hope to move display() to
using a logging framework. If that happens, we won't need this anyway.
ISSUE TYPE
COMPONENT NAME
utils/display.py
ANSIBLE VERSION
ADDITIONAL INFORMATION