New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add win_mssql_query module: Module for query MSSQL databases #43774
Commits on Dec 19, 2018
-
Pluribus Networks admin service module with unit tests (ansible#49854)
* Pluribus Networks admin service module with unit tests * Documentation fix * import module changes * Removed unused imports * Fix return type
-
Pluribus Networks dhcp filter module with unit tests (ansible#49848)
* Pluribus Networks dhcp filter module with unit tests * Added type which was missing in doc * Removed unwanted global variable * Fix return type
-
Added organization in the scm_credential get (ansible#49884)
* Added organization in the scm_credential get * Fallback looking for cred in project org * Tests project with multi org credential * Fixed CI issue * Added changelog fragment
-
rabbitmq_binding: Fix using empty routing key (ansible#48597)
* rabbitmq_binding: Fix using empty routing key If the routing key is an empty string we need to use the special props value ~ in the URL. Otherwise the last part of the URL will be empty, which will instead be equivalent to the "list all bindings" API call which always returns 200 OK (as long as the exchange and queue exists). * rabbitmq_binding: Move routing_key test outside format Test the routing_key value and set the props value outside the format call. We leave the original routing_key untouched since its original value is later needed in create().
-
-
dont think all files are valid cause libs present (ansible#50103)
verify_file was improperly always returning true if pyvimomi and requests libs were correct moved library checking to parse, avoid unneded errors unless the file is actually meant for this plugin
-
Allow persistent connection plugins to queue messages back to ansible…
…-connection (ansible#49977) * Connections can queue messages to be returned from ansible-connection * Provide fallback for invalid display level * Strip display from plugins * Route messages through helper method to try to avoid improper appends
-
Refactoring of cnos_interface module like what followed by other vend…
…ors (ansible#49927) * Refactoring of cnos_interface module like what followed by other vendors * To remove cnos-interface from E326 validation ignore list * Effect of default parameters impacted UT
-
Revert range change (ansible#50155)
* Revert "Fix incorrect examples with random filter (ansible#50137)" This reverts commit 9a7dbd5. The correction is incomplete and also based on a 'fix' that was supposed to have been reverted already * Revert "Added `+1` to the `end` in `random` filter so that it was inclusive (ansible#27215)" This reverts commit ea2b89c. reverted fix as agreed at the time, but missed by maintainers.
-
-
VMware: Update example vmware_deploy_ovf (ansible#49893)
* Update vmware_deploy_ovf.py Provided more detailed example using additional, often used parameters Co-Authored-By: mhoffmann1 <marcin.hoffmann@intel.com> * Replace variable values in example task Co-Authored-By: mhoffmann1 <marcin.hoffmann@intel.com>
-
Command module docs: args vs argv (ansible#49907)
* add note about 'args', update examples * Update lib/ansible/modules/commands/command.py Co-Authored-By: acozine <879121+acozine@users.noreply.github.com>
-
Fix typo in ds_type in examples section (ansible#50166)
replace ds_type elasticisearch by elasticsearch
-
Update zabbix_action.py (ansible#50149)
Mostly typo/grammar fixes. "Zabbix Server" was changed to just "Zabbix", as it could be slightly confusing - some people might interpret this referencing the server process, although API matters. "capital-case" was changed, as it usually is one of "capital" or "upper-case". +label: docsite_pr
-
Add retries for Invoke-ScriptAnalyzer in pslint.
Hopefully this will work around the intermittent CI failures due to NullReferenceException, which then succeed on a retry.
-
Change test to support runner_on_start in Ansible 2.8 and ansible-runner 1.2.0
Commits on Dec 20, 2018
-
-
optimising vmss tests (ansible#50175)
Zim Kalinowski committedDec 20, 2018 -
New Module: Add bitbucket_deploy_key (ansible#27467)
* added new module to manage deploy keys for BitBucket repositories * Modified module to pass CI tests * Updated bitbucket_deploy_key module * updated message returned when there is an existing deploy key * bumped version_added to 2.8 * fixed issues reported by ansible-test
-
-
Fix type in RETURN for bitbucket_deploy_key
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
-
fixing network client version (ansible#50182)
Zim Kalinowski committedDec 20, 2018 -
sku in the sample became invalid, so updating (ansible#50177)
Zim Kalinowski committedDec 20, 2018 -
Fix eos terminal plugin (ansible#49920)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
-
New Module for creating, managing Infoblox NIOS nameserver groups (an…
…sible#49124) * adding new nios_nsgroup module Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com> * adding new nios_nsgroup module Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com> * adding new nios_nsgroup module Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com> * fix shippable errors Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com> * added unit tests Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
-
os_security_group_rule proper module exit (ansible#50076)
When the security group the rule belongs to does not exist and the state is absent, the module is not properly exited, leading to a playbook execution failure. Fixes issue ansible#50057
-
Skip non-management Packet IP addresses (ansible#48168)
Non-management (elastic) IP addresses require manual configuration on the host as described in https://help.packet.net/article/54-elastic-ips. Skip those so that only the automatically configured management addresses are used. Otherwise, a non-routable address may be returned in the inventory.
-
Update
Unknown error
to specific error message (ansible#50129)* Update `Unknown error` to specific error message outputs the Exception received rather than just 'Unknown error' fixes: issue/49713 * Update `Unknown error` to specific error message improves the error message
-
-
-
-
Move doc fragments to changelogs/fragments dir (ansible#50179)
Move changelog fragment to changelogs/fragments dir
-
Typo/grammar/consistency fixes.
-
Change the Packet.net section to be more consistent with the other *C…
…loud Guide pages. (ansible#50170) <!--- Your description here --> +label: docsite_pr
-
List correctly current PV in "lvg" module: fix lvg reduce (ansible#4…
…9731) * Refactor integration test for lvg module to introduce grow/reduce test * List correctly current PV in lvg module: fix lvg reduce Previous behaviour was to only take into account PV passed in 'pvs' argument. This lead to reduce not working as expecting: * with state=present and list of wanted pvs, lvg found only the pvs to add or already present and ignored the pv to remove (obviously absent from the list of given PV) * with state=absent and a pv to remove, lvg found that the remaining pvs list is empty (ignoring possible other PV in the vg) and decides to remove the vg entirely (as supposely no PV are left anymore to store lvm metadata) * Add changelog fragment
-
Jenkins_plugin: Handle 'latest' version when installing plugin for fi…
…rst time (ansible#49723) * Handle 'latest' version when installing module for first time Otherwise, a fresh install of a plugin with 'version: latest' gets installed without its dependencies, rendering the plugin effectively useless. * Add changelog
-
MSC: Various bugfixes and features enhancements (ansible#50200)
* MSC: Various bugfixes and features enhancements This PR includes: - Lookups of roles, labels and domains - Auto-create new labels - Improvements to comparing complex datastructures - Force removal of sites - Support non top-level queries - Document internal functions - Add parameter types to modules - Fix documentation examples - Improvements to idempotency wrt. returning changed - Support site locations - Update permission list - Various improvements to integration tests * Fix Ci issues
-
Docs: Show parameter types (in purple) (ansible#49966)
* Docs: Show parameter types (in purple) * Changes based on feedback * Remove leftover statement after review * Simplify TOC and support section * Add missing 'v' to version_added * Remove the v for version * Update docs/templates/plugin.rst.j2 Co-Authored-By: dagwieers <dag@wieers.com> * Update docs/templates/plugin.rst.j2 Co-Authored-By: dagwieers <dag@wieers.com> * Move Author into Support section * Avoid more "isn't included in any toctree" errors * Add Red Hat support section, list module status
-
Make modprobe module check for builtins as well (ansible#37150)
Without this modprobe always reports changed when modprobe-ing a builtin module. With this, if a kernel module is a builtin, the modprobe module will: - succeed (without incorrectly reporting changed) if ``state`` is ``present``; - fail if ``state`` is ``absent`` The failure will have whatever error message modprobe returns when attempting to remove a builtin module. For example: ``modprobe: ERROR: Module nfs is builtin.``
-
Add more detailed documentation on how to use multiple inventories (a…
…nsible#47586) * Add a new section on how to use multiple inventory sources w/ examples Co-Authored-By: zharalim <zharalim@outlook.com>
-
Misc documentation update (ansible#50190)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Commits on Dec 21, 2018
-
-
win_updates: Correctly report changes on success (ansible#50188)
* win_updates: Correctly report changes on success * Add changelog fragment
-
win_firewall_rule: Remove invalid 'bypass' action (ansible#50207)
* win_firewall_rule: Remove invalid 'bypass' action This fixes ansible#50143 * Add changelog fragment
-
-
Add
env
command to ansible-test and run in CI. (ansible#50176)* Add `env` command to ansible-test and run in CI. * Avoid unnecessary docker pull.
-
Fix Issue ansible#49612 (ansible#50073)
* Fix Issue ansible#49612 Signed-off-by: Anas Badaha <anasb@mellanox.com> * Fix Pep8 failures Signed-off-by: Anas Badaha <anasb@mellanox.com> * Add validation for send empty group name Signed-off-by: Anas Badaha <anasb@mellanox.com> * Fix Error message Signed-off-by: Anas Badaha <anasb@mellanox.com>
-
Fix Issue ansible#39598 (ansible#49982)
* Fix Issue ansible#39598 Signed-off-by: Anas Badaha <anasb@mellanox.com> * Fix unit test for onyx_config Signed-off-by: Anas Badaha <anasb@mellanox.com> * Add comments for save running config Signed-off-by: Anas Badaha <anasb@mellanox.com> * Enhance onyx_config bug fix Signed-off-by: Anas Badaha <anasb@mellanox.com> * Fix result['changed'] = True comment Signed-off-by: Anas Badaha <anasb@mellanox.com>
-
VMware: add VBS configuration support for Windows 10 (ansible#48595)
* Fix space issue * fix whitespaces issue
-
-
postgresql_idx: misc fixes (ansible#50199)
* Removed unused import * Removed 'login_password' from exit_json call * Removed unused db, cond variable Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
-
Correct match test documentation (ansible#50229)
Match test matches zero or more characters at the begining of the string. Fixes: ansible#32366 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
-
fixed invalid samples (ansible#50227)
* fixed invalid samples
-
Add backup parameter to cli_config (ansible#50206)
* Add backup parameter to cli_config * Add a unit test for cli_config backup
-
Merge backup functionality across config action plugins (ansible#50208)
* Merge backup functionality across config action plugins * Port updated cli_config
-
Log device interaction and push labeled logs back to controller (ansi…
…ble#50028) * Add session tracing support for network_cli, netconf and httapi connection * Add `persistent_log_messages` configuration option to log device inteaction in log file for network_cli, netconf and httapi connection type * Log jsonrpc request and response in log file is configuration option is enabled * Update docs to talk about warning shown when persistent_log_messages is on
-
-
Allow AnsibleVaultEncryptedUnicode to pass through exec_jsonrpc (ansi…
…ble#48306) * Allow AnsibleVaultEncryptedUnicode to pass through exec_jsonrpc * Add changelog
-
-
* Bug fixes * fixes as of 12/5/2018 * changes as of 12/06/2018
-
-
-
-
-
ansible-doc: update faq to include common z/OS pitfalls (ansible#18555)…
… (ansible#49504) * ansible-doc: update faq to include common z/OS pitfalls (ansible#18555) Co-Authored-By: gitaaron <aaron.surty@gmail.com>
-
Commits on Dec 22, 2018
-
Update nios_aaaa_record.py (ansible#50271)
Should be ipv6. +label: docsite_pr
-
postgresql_user: set type of conn_limit (ansible#50178)
conn_limit type is set to 'int'. This will allow module to compare conn_limit with record value without type casting. Fixes: ansible#38118 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
-
Add colon after module name (ansible#50274)
* A colon is not described * dddd * Update aws_kms_facts.py
Commits on Dec 23, 2018
-
fix: ansible_kubectl_ssl_ca_cert variable (ansible#50217)
* fix: mistake for ansible_kubectl_ssl_ca_cert variable * fix: K8S_AUTH_VERIFY_SSL
-
Elliptic curve tests for crypto modules (ansible#50109)
* Add openssl_csr ECC test. * Add openssl_publickey ECC test. * Add openssl_certificate ECC test.
-
Revert TEMP HACK: Upload all to codecov (ansible#50279)
Codecov.io have made some improvements to results processing. Upload all the coverage data to see is codecov can process this. Reverts ansible#47515
-
Fix for AttributeError in network_cli (ansible#50284)
* Value of prompt_answer is wrongly used as `self.prompt_answer` while logging it in message queue
Commits on Dec 24, 2018
Commits on Dec 26, 2018
-
-
Change net_* default behaviour on missing module (ansible#49923)
* Fix net_base default behaviour Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * New fix Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
-
docker_image: add network parameter (ansible#50313)
* docker_image: add network parameter Add a network parameter to the docker_image module to specify the network to use for RUN commands. Called it network instead of network_mode as the latter seems like a legacy of when there were just a few default options to choose from, while now the name of an arbitrary network can be specified. Fixes ansible#21433 * Format description * Update docker_image option_minimal_versions * Ensure network_mode param optional
-
Provide both service state and status when possible in service_facts (a…
…nsible#49618) * Combine systemd units/unit-files output for service_facts Fixes ansible#47118 Previously we were only taking the output of `systemd units` which would leave out information about the service units that were disabled, static, masked, etc. Now we're aggregating the results so that anything not active/inactive/dead at least is pulled as fact data with it's state provided. Signed-off-by: Adam Miller <admiller@redhat.com> * provide state and status information about services Fixes ansible#45730 Signed-off-by: Adam Miller <admiller@redhat.com>
-
ACME: add seealso references (ansible#50320)
* Add seealso references to ACME modules. * Bump to latest drafts.
-
-
Commits on Dec 27, 2018
-
Documentation remove escape r (ansible#50277)
* A colon is not described * dddd * Update branch
Commits on Dec 29, 2018
-
-
ufw: add integration tests (ansible#50374)
* Add basic integration tests for ufw. * Being more honest.
-
-
Commits on Dec 30, 2018
-
Temporarily disable mysql_user testcases (ansible#50395)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Commits on Dec 31, 2018
-
Temporarily disable mysql_variables (ansible#50403)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
-
Pure Storage facts fix (ansible#50349)
* Add module for Pure Storage FlashBlade to manage directory services * Fix facts not correctly passing into ansible_facts dict
Commits on Jan 1, 2019
-
vultr_server: fix multiple ssh keys not handled (ansible#50337)
* vultr_server: fix multiple ssh keys not handled * add changelog fragment
-
docker_secret, docker_config: allow to base64-decode data (ansible#49688
-
Commits on Jan 2, 2019
-
-
- Fixed documentation trailing whitespaces - Added missing/broken documentation
-
- Fixed documentation trailing whitespaces - Added missing/broken documentation
-
- Fixed documentation trailing whitespaces - Added missing/broken documentation
-
Add support for NRDP notifications (ansible#39297)
* Add support for NRDP notifications * Correct pep-8 check, adding copyright * Correct pep-8 check using autopep8 * Update nrdp to 2.6 version * Update nrdp to 2.7 version * Use internal ansible url and options modules * Remove useless comments * Add option to validate https certs * Update nrdp to 2.8 version * Correct nrdp pep8
-
Fix firewalld module failing on missing protocol. (ansible#50242)
Under Python 3.7 at least, the split of the port field fails ungracefully if there is no slash. The fix also addresses the case of an empty protocol after the slash.
-
-
-
fix order of dnf api operations so transactions don't fail (ansible#5…
…0038) * fix order of dnf api operations so transactions don't fail Previously dnf.base.fill_sack() was called before dnf.base.update_cache() which apparently breaks dnf transaction logic as per https://bugzilla.redhat.com/show_bug.cgi?id=1658694 Fixes ansible#49060 Signed-off-by: Adam Miller <admiller@redhat.com> * add changelog and test case Signed-off-by: Adam Miller <admiller@redhat.com>
-
add changelog for ansible#50242 (ansible#50480)
Signed-off-by: Adam Miller <admiller@redhat.com>
Commits on Jan 3, 2019
-
Add support for Kali Linux detection. (ansible#50331)
Signed-off-by: Joseph Benden <joe@benden.us>
-
-
docker_swarm_service: Fix typo for option type (ansible#50483)
* Fix typo for option type in docker_swarm_service. * Add changelog.
-
openssl_csr: idempotency doesn't work correctly for keyUsage (ansible…
…#50361) * Fix key usage idempotency bug. * Extend tests. * Add changelog.
-
openssl_*: prevent error when path includes no path (ansible#50322)
* Prevent error when path includes no path. * Add changelog.
-
add openssh_cert module (ansible#49605)
* add openssh_cert module * fix some linter issues * address review feedback * add basis for integration tests * change valid datetime formats * handle principals as set not as list * handle principals as set not as list * handle principals as set not as list
-
Add choices of the state parameter documentation (ansible#50481)
* Add choices of the state parameter documentation * Consistency
-
-
Update playbooks_loops.rst (ansible#50437)
Error in the example for exclusion pattern +label: docsite_pr
-
Update changed_when and failed_when examples (ansible#50411)
Added examples in playbooks_error_handling doc for handlining multiple conditions in changed_when and failed_when Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
-
gcp: documentation update (ansible#50183)
* gcp: documentation update * Update example about dynamic inventory * minor typo fixes in gcp_utils * Additional information about enabling inventory plugin in ansible.cfg partially fixes: ansible#44404 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
-
Update zabbix_action.py (ansible#50490)
* Add trailing dots for consistency. * Document how the current host can be specified for "run_on_hosts". +label: docsite_pr
-
Docs: add Pygments lexer for Ansible output (ansible#50318)
* Add specialized lexer for Ansible output. * Make linter happy. * Use different tokens.
-
Make WinRM security warning more explicit (ansible#50263)
Make WinRM security warning more explicit. Currently the warning is "viewed by anyone", this is a much lower risk than arbitrary command injection. Therefore the risk should be phrased appropriately. +label: docsite_pr
-
Windows: Add missing parameter types and doc fixes (ansible#50232)
* Windows: Add missing parameter types and doc fixes This PR includes: - Adding missing parameter types - Various documentation fixes * Update lib/ansible/modules/windows/win_copy.py Co-Authored-By: dagwieers <dag@wieers.com> * Update lib/ansible/modules/windows/win_credential.py Co-Authored-By: dagwieers <dag@wieers.com> * Update lib/ansible/modules/windows/win_domain_computer.py Co-Authored-By: dagwieers <dag@wieers.com> * Update lib/ansible/modules/windows/win_domain_user.py Co-Authored-By: dagwieers <dag@wieers.com> * Update lib/ansible/modules/windows/win_environment.py Co-Authored-By: dagwieers <dag@wieers.com> * Update lib/ansible/modules/windows/win_psexec.py Co-Authored-By: dagwieers <dag@wieers.com> * Update lib/ansible/modules/windows/win_uri.py Co-Authored-By: dagwieers <dag@wieers.com> * Update lib/ansible/modules/windows/win_wait_for.py Co-Authored-By: dagwieers <dag@wieers.com> * Ensure docstrings are raw strings
-
allow for vault enterprise namespaces (ansible#50462)
* enable namespaces feature for hashi_vault lookup * include version_added dict in options documentation
-
Add galaxy.html#dependencies link (ansible#49984)
* Add galaxy.html#dependencies link +label: docsite_pr
-
-
Give IncludedFile more context via ansible_search_path (ansible#50045)
* Give IncludedFile more context via ansible_search_path to template lookups. Fixes ansible#49969 * Update units
-
urldecode filter for Jinja2 (ansible#28503)
* urldecode filter for Jinja2 We needed this in order to deconstruct correct URLs using Jinja2. And we might as well upstream this. * Add integration tests * Fixes for Python 3 * Add urlencode for older Jinja2
-
ACI: Implement encoded query_string (ansible#50358)
This requires urldecode support in Ansible
Commits on Jan 4, 2019
-
ansible-test: docker_network set as untable (ansible#50526)
* Revert "disable docker_network ipam tests (ansible#50477)" This reverts commit 4dd2b8e. * test - docker_network mark as unstable
-
Cleanups to the common.sys_info API
* Move get_all_subclasses out of sys_info as it is unrelated to system information. * get_all_subclasses now returns a set() instead of a list. * Don't port get_platform to sys_info as it is deprecated. Code using the common API should just use platform.system() directly. * Rename load_platform_subclass() to get_platform_subclass and do not instantiate the rturned class. * Test the compat shims in module_utils/basic.py separately from the new API in module_utils/common/sys_info.py and module_utils/common/_utils.py
-
Save the command line arguments into a global context
* Once cli args are parsed, they're constant. So, save the parsed args into the global context for everyone else to use them from now on. * Port cli scripts to use the CLIARGS in the context * Refactor call to parse cli args into the run() method * Fix unittests for changes to the internals of CLI arg parsing * Port callback plugins to use context.CLIARGS * Got rid of the private self._options attribute * Use context.CLIARGS in the individual callback plugins instead. * Also output positional arguments in default and unixy plugins * Code has been simplified since we're now dealing with a dict rather than Optparse.Value
-
Split up the base_parser function
The goal of breaking apart the base_parser() function is to get rid of a bunch of conditionals and parameters in the code and, instead, make code look like simple composition. When splitting, a choice had to be made as to whether this would operate by side effect (modifying a passed in parser) or side effect-free (returning a new parser everytime). Making a version that's side-effect-free appears to be fighting with the optparse API (it wants to work by creating a parser object, configuring the object, and then parsing the arguments with it) so instead, make it clear that our helper functions are modifying the passed in parser by (1) not returning the parser and (2) changing the function names to be more clear that it is operating by side-effect. Also move all of the generic optparse code, along with the argument context classes, into a new subdirectory.
-
* Mark methods which are really functions as staticmethod * Fix calls to other staticmethods to use the subclass rather than the base class so that any inheritance overriding will be honored. * Remove unnecessary logic and dead code * Fix a typo in a docstring of how to implement subclass init_parser() methods * Call superclass's post_process_args in ansible-doc * Fix copyright comment according to suggested practice
-
Move the arguments module into cli/ and context_objects into utils
* Note: Python2 is not as intelligent at detecting false import loops as Python3. context_objects.py cannot be added to cli/arguments because it would set up an import loop between cli/__init__.py, cli/arguments/context_objects.py, and context.py on Python2. ci_complete
-
Update documentation for mysql_db notes (ansible#50444)
* Simplify the requirement section to avoid duplicating info already in mysql_document_fragment. * Package installation section simplified, mentioned RHEL; a typo fix in "than". * added dnf for Fedora
-
Handle exception raised in recursive_finder API (ansible#49590)
User module can contain Indentation errors or syntax errors. Handle AST exceptions rather than showing traceback while importing such module. Fixes: ansible#21707 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
-
Added new module to support NIOS Fixedaddress DHCP property (ansible#…
…49119) Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com> * nios fixedaddr new module Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com> * updating name Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com> * added unit tests Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
-
-
-
Correct Errors in Documentation (ansible#50507)
* Correct Errors in Documentation According to the module, "compose" is not required, but the docs said it was - removed the "required" tag. Additionally, the example for removing a stack did not include the required "name" option (this method is why "compose" is not required. +label: docsite_pr * Removed change to description Corrected issue to my "correction" on the description. * Removed required false * Removed all instances of required: false.
-
Fix backup issue in network config modules and network action plugins…
… common code refactor (ansible#50301) * Fix backup issue in network config modules * Fix `get_working_path` not found issue introduced due to backup config code refactor (PR ansible#50208) * Further refactor config related action plugins to minimize duplicate code * Remove unwated imports in config action plugins * Add common network class for action plugin and related code refactor * Fix review comment
-
add privileged role validation for nxos become (ansible#50312)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
-
Fix junos terminal error regex (ansible#50538)
* Change junos terminal error regex to read error string correctly.
-
dnf/yum - added install_weak_deps option (ansible#50525)
* dnf/yum - added install_weak_deps option * skip creating weak dep packages if rpm doesn't support it * fix rpm check for older hosts
-
Add a porting guide entry for ansible_distribution facts (ansible#50251)
* Add a porting guide entry for ansible_distribution facts Switching away from platform.distro() will cause changes sometimes due to the new code using new sources of information that may be out of sync with the old ones. Just have to make people aware of that and also what we are doing to mitigate it when appropriate. * wordsmithed, added links for new distro backend
-
-
-
Add new AnsibleTemplateError to more easily catch templating issues (a…
…nsible#50563) * Add new AnsibleTemplateError to more easily catch templating issues. Fixes ansible#50154 * Add changelog fragment
-
module_utils/urls.py is core (ansible#50567)
* module_utils/urls.py is core * More core supported module_utils * More missed core module_utils
Commits on Jan 5, 2019
-
new module: Configure LVM and NFS file systems for AIX (ansible#30810)
* new module: AIX LVM file system and NFS This module creates, removes, mount and unmount LVM and NFS file system for AIX using /etc/filesystems. For LVM file systems is also possible to resize the file system. * better parameters options structure better parameters options structure * Improved file system resize returns Added better tratment for return codes for file system resize. When a resize is not possible because no enough space on lv or shrink is not allowed. * improved doc and creation file system return code - improved doc - creation file system return code 10 was treated. * Doc recomendations, dict result, line limit - Added doc recomendations - Changed return to dict results on main() - Using 159 columns for code limit * wrong changed return when file system is already Fixed wrong changed return when file system is already mounted. When the file system is already mounted the return for changed is False. * Fixed description and included playbook for tests - Fixed description - Included playbook for manual tests * Various small bits to get this merged ASAP * Rename test/legacy/aix_filesystem.yml to test/integration/targets/aix_filesystem/tasks/main.yml Move integration test to its proper location * Create aliases * Fix CI issues
Commits on Jan 6, 2019
Commits on Jan 7, 2019
-
Pluribus Networks module for connection stat settings with UT's (ansi…
…ble#50186) * Pluribus Networks module for connection stat settings
-
adding module azure_rm_virtualmachinescalesetinstance_facts (ansible#…
Zim Kalinowski committedJan 7, 2019 -
-
Checkpoint httpapi plugin (ansible#49929)
* Add checkpoint httpapi plugin and access rule facts module * WIP checkpoint_access_rule module * Add publish and install policy, plus fix empty json object request for publish * Refactor publish and install_policy onto module_utils * Add update resource logic * Add checkpoint_host_facts module * Return code and response on get_acess_rule function * Add checkpoint_host module * Add checkpoint_run_script module * Add checkpoint_task_facts module * Show all tasks if no task id is passed Note, this is only available on v1.3 of Checkpoint WS API * Add update logic to checkpoint host * Add full details on get task call * Add checkpoint httpapi plugin * Fix pep8 * Use auth instead of sid property and return False on handle_httperror method * Fix version in docstring * Remove constructor * Remove Accept from base headers * Do not override http error handler and assign Checkpoint sid to connection _auth There is scaffolding in the base class to autoappend the token, given it is assigned to connection _send * Use new connection queue message method instead of display * Remove unused display * Catch ValueError, since it's a parent of JSONDecodeError * Make static methods that are not used outside the class regular methods * Add missing self to previously static methods * Fix logout Was carrying copy pasta from ftd plugin * Remove send_auth_request * Use BASE_HEADERS constant * Simplify copyright header on httpapi plugin * Remove access rule module * Remove unused imports * Add unit test * Fix pep8 * Add test * Add test * Fix pep8
-
Fix for the new 2.8 feature to have modprobe check for builtins.
uname output includes a newline. strip() the newline so that the filepath we construct points to the right place.
-
-
xml: Improve documentation and examples (ansible#50602)
This PR includes: - Type information for parameters - Added 'seealso' section to documentation - Improve examples
-
-
Cloudscale volume (ansible#49887)
* Cloudscale integration test setup CloudProvider and CloudEnvironment classes for Cloudscale integration tests. This also contains a cloudscale_common role with common variables for all tests. * cloudscale_volume module New cloud module to manage volumes on the cloudscale.ch IaaS service.
-
The API docs state that both `branch` and `branchName` are valid, but only `branchName` appears to work.
-
Add Devuan Support for ascii release - resolve 49615 (ansible#49616)
* Add Devuan Support for ascii release - resolve 49615 * Devuan Ascii does not have the VERSION_ID in the /etc/os-release file, we need to set NA
Commits on Jan 8, 2019
-
Fix issue in junos and bigip action plugins (ansible#50636)
* tmp is not required to be passed to in run() within action plugin
-
New Module: vyos_ping (ansible#50193)
* New module for vyos ping functionality Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * Add some new parameters Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * Need spaces Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * Fix pylint errors Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * Fix pylint errors Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * Fix docs Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * Fix docs Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com> * Fix docs Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
-
ovirt_storage_connection: Fix issue in detaching the connection (ansi…
…ble#50005) Currently deleting the storage connection just tries to delete the connection but it doesn't detach the connection from storage domain. The patch first tries to detach the connection from storage domain before attempting to delete the same if the storage domain parameter is provided.
-
fix eos_l2_interface invalid command (ansible#50644)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
-
ufw: extend integration tests (ansible#50400)
* Improve cleanup. * Add check mode tests. Failing tests commented out; will be fixed in ansible#49948. * Add reload and reset tests. * Add tests for other global state. * Work around ufw bugs.
-
docker_node_facts: Read information about swarm node from swarm manag…
…er (ansible#50571) * docker_node_facts: New module to read information about swarm node from swarm manager * Update lib/ansible/modules/cloud/docker/docker_node_facts.py Co-Authored-By: WojciechowskiPiotr <23406016+WojciechowskiPiotr@users.noreply.github.com> * Update lib/ansible/modules/cloud/docker/docker_node_facts.py Co-Authored-By: WojciechowskiPiotr <23406016+WojciechowskiPiotr@users.noreply.github.com> * Update lib/ansible/modules/cloud/docker/docker_node_facts.py Co-Authored-By: WojciechowskiPiotr <23406016+WojciechowskiPiotr@users.noreply.github.com> * docker_node_facts: min_docker_api_version and docker updated to align with Docker documentation * docker_node_facts: Updated documentation and minimum version requirements * docker_node_facts: Updated documentation of requirements * Update lib/ansible/modules/cloud/docker/docker_node_facts.py Co-Authored-By: WojciechowskiPiotr <23406016+WojciechowskiPiotr@users.noreply.github.com> * Update lib/ansible/modules/cloud/docker/docker_node_facts.py Co-Authored-By: WojciechowskiPiotr <23406016+WojciechowskiPiotr@users.noreply.github.com> * Update lib/ansible/modules/cloud/docker/docker_node_facts.py Co-Authored-By: WojciechowskiPiotr <23406016+WojciechowskiPiotr@users.noreply.github.com> * Update lib/ansible/modules/cloud/docker/docker_node_facts.py Co-Authored-By: WojciechowskiPiotr <23406016+WojciechowskiPiotr@users.noreply.github.com> * Update lib/ansible/modules/cloud/docker/docker_node_facts.py * Update lib/ansible/modules/cloud/docker/docker_node_facts.py Co-Authored-By: WojciechowskiPiotr <23406016+WojciechowskiPiotr@users.noreply.github.com>
-
Introduce 'insertbefore' and 'insertafter' to specify the position (a…
…nsible#44811) * Introduce 'insertbefore' and 'insertafter' to specify the position children have to be inserted. * Added version_added to new options * Xpath in example needs single quotes * Added integration tests for insertafter and insertbefore * Changed version_added to 2.8
-
Update zabbix_action.py (ansible#50582)
* Document "host_groups", "templates" and "inventory" operation parameters. * Fix a couple of typos. Fixes ansible#50581 +label: docsite_pr
-
avoid x2 setting of set_fact when 'cacheable' (ansible#50564)
* avoid x2 setting of set_fact when 'cacheable' fixes ansible#50556 * ammend docs to new behaviour * added period
-
* csv of memory usage * Fix var * Configurable output file * Add cpu profiling * Valdiate the existence of cgroup files * Add guard to prevent exception when trying to reset max memory value * to_bytes/to_text and docs updates * Add support for CPU results * Just track the max, don't log all results, and then calculate max * Restore cgroup_memory_recap, and move new functionality into cgroup_perf_recap * Add pid count tracking, restructure to support more profilers * Add cli tool for graphing cgroup_perf_recap data * csv_output_dir is a path * Correct CALLBACK_NAME * Include uuid in csv data * fix linting errors * Bump version_added * Create helper funciton to create dict from list of keys, with callable default * Updated notes to include pids * Print a newline after each section * Plugin improvements * Add option to supporess recap display * Add default for output directory * Add option to dictate whether or not to write files * Add JSON-seq output option * s/uuid/task_uuid * Use bytes for paths * Increase polling interval length for pids/memory * Reduce instance attrs, change how we invoke profilers * Shorten some line lengths * Remove more instance attrs * Fix some typos * document directory creation, and catch exceptions * Enable per task file outputs, and filename customization * s/per_task_file/file_per_task/g
-
Documentation fix for developing own plugin (ansible#50547)
Seems like `self` is not necessary in the call args +label: docsite_pr
-
docker_network IPAM test / general docker test cleanup (ansible#50499)
* Re-enable docker_network tests. * Basic cleanup of docker daemon. * Add docker CLI detection. * YAML notation.
-
Included support to AIX group of subsystems on service module (ansib…
…le#33043) * Included support to AIX group subsystems AIX systems has subsystems as services but also uses group subsystems. For example, spooler is a group subsystem to services qdaemon, writesrv, and lpd. This change enables the possibility to use also the group susbsystmes such as spooler, nfs, etc. When the service name is informed, first the module will check if the name is a subsystem, if not it will check if the name is a group subsystem and also it subsystems states. This change makes services more flexible with AIX systems. * Included test/legacy/aix_services.yml for tests As discussed on IRC ansible-devel channes, was include the legacy tests for further manual tests.
-
Add AIX support to reboot module (ansible#50353)
* Add ability for reboot module to work for AIX * changelog for AIX reboot support
Commits on Jan 9, 2019
-
-
Add auth_timeout parameter when supported by paramiko (ansible#50448)
* Add auth_timeout parameter when supported Paramiko 2.2 introduces the auth_timeout parameter. This will set the parameter to the same value of the timeout parameter to prevent "Authentication timeout" errors. * Conditionally add auth_timeout to ssh.connect Renamed sock_kwarg to ssh_connect_kwargs and conditionally added the auth_timeout parameter based on the installed paramiko version. * Add changelog fragment
-
-
-
-
zabbix_host_facts: get list of templates (ansible#50007)
Get list of templates among other items. It is useful because later one can edit this list using zabbix_host module.
-
Checkpoint access rule (ansible#49937)
* WIP checkpoint_access_rule module * Add fixes and docstrings * Add dunder init * Fix sanity tests issues * Fix sanity test * Add RETURN and EXAMPLES * Fix example * Fix pep8 * Add tests * Fix pep8 * Fix pep8
-
-
-
Fixing exception import for tower modules (ansible#50447)
* fixing the exception import from tower modules * Adding tests for checking tower modules are failing with correct msg * fixed failing tests * fixed failing test in tower_team
-
Update zabbix_action.py (ansible#50548)
* Update zabbix_action.py Clarify when in/not in operators can be used.
-
Lenovo cnos banner new module (ansible#50145)
* Adding cnos_banner module to the list.
-
Lenovo cnos l2interface (ansible#50641)
* Adding cnos_l2 interface module and its associated Integration test as well as Unit test code
-
Fix sanitizing config lines (ansible#50553)
Previously, the index got out of sync with the actual config list. Invoked with lines: - bad - first - bad - second the sanitization would first delete index 0 and then index 2, which would result in the output - first - bad By reversing the list, we avoid that problem (though a filter() would be nicer)
-
default: callback plugin allow unreachable task to stderr (ansible#50533
) Provide toggle flag to allow display of unreachable task to stderr using default callback plugin. Fixes: ansible#48069 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
-
Add tests for WANT_JSON and old style modules (ansible#50555)
* Add tests for WANT_JSON and old style modules * quote source path * Attempt to further appease tests * Check for file and not just exists * omg don't be dumb * moar fixes * shellcheck is the worst :) * Test the custom modules for failure without arg files
-
Commits on Jan 10, 2019
-
-
-
-
-
Merge pull request ansible#50735 from mattclay/callback-inv
Move callback_default test inventory into test.
-
-
-
-
-
-
-
To resolve NIOS race condition when ip allocated via NIOS next availa…
…ble ip function (ansible#49818) Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com> * resolves bug 45218 Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com> * fixing review comments
-
PR to fix the issue of keyerror in Nios api (ansible#49183)
* ipv4addr keyerror fix Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com> * fix review comment Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
-
Pluribus Networks pn_dscp_map_pri_map module with Unit tests (ansible…
…#50142) * Pluribus Networks pn_dscp_map_pri_map module with Unit tests * Corrected method name in unit test script
-
-
Fix: lxca_nodes misspelled in the lxca_common.py (ansible#50734)
misspelled "requirements" to "requirement". https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html
-
-
schema can also be provided if type is default_privs (ansible#50498)
+label: docsite_pr
-
Daniele Lazzari committed
Jan 10, 2019 -
fixed credentials security, select, version in doc
Daniele Lazzari committedJan 10, 2019 -
Daniele Lazzari authored and Daniele Lazzari committed
Jan 10, 2019 -
fix test/sanity/pslint/ignore.txt
Daniele Lazzari authored and Daniele Lazzari committedJan 10, 2019 -
fix ConvertTo-SecureString with empty string
Daniele Lazzari committedJan 10, 2019 -
Daniele Lazzari committed
Jan 10, 2019 -
Daniele Lazzari authored and Daniele Lazzari committed
Jan 10, 2019 -
-
Merge branch 'win_mssql_query' of https://github.com/dlazz/ansible in…
…to win_mssql_query