Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tests for correctly handling handlers w free #44175

Draft
wants to merge 3 commits into
base: devel
Choose a base branch
from
Draft

added tests for correctly handling handlers w free #44175

wants to merge 3 commits into from
+36 −0

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Aug 15, 2018

SUMMARY

confirms #33011 fix

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

strategy

ANSIBLE VERSION
2.7

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Aug 15, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 16, 2018
@mattclay
Copy link
Member

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/80066/64/console

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Aug 28, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 28, 2018
@mattclay
Copy link
Member

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/81217/54/console

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Aug 31, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 3, 2018
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Sep 4, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 12, 2018
@ansible ansible deleted a comment from ansibot Nov 7, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 7, 2018
@mattclay
Copy link
Member

mattclay commented Nov 7, 2018

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/92369/56/console

03:18 ++ ansible-playbook test_handlers_include_role.yml -i ../../inventory -v -vvvvvv
03:18 ++ egrep -o 'RUNNING HANDLER \[test_handlers_include_role : .*?]'
03:19 + '[' 'RUNNING HANDLER [test_handlers_include_role : test handler]' = 'RUNNING HANDLER [test_handlers_include_role : test handler]' ']'
03:19 ++ ansible-playbook free_strategy.yml -i ../../inventory -v -vvvvvv
03:19 ++ grep testhost
03:19 ++ grep -c -v testhost2
04:40 + '[' 12 = 9 ']'

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Nov 7, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 15, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 11, 2018
@mattclay
Copy link
Member

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/99155/62/console

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Dec 19, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 19, 2018
@Shrews
Copy link
Contributor

Shrews commented Sep 11, 2020

Is this something we still want?

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 8, 2020
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Mar 5, 2021
@samdoran
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. community_review In order to be merged, this PR must follow the community review workflow. labels Mar 15, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Mar 17, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 25, 2021
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. community_review In order to be merged, this PR must follow the community review workflow. labels Apr 27, 2022
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 5, 2022
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label May 6, 2022
@bcoca bcoca marked this pull request as draft August 24, 2022 20:08
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Aug 24, 2022
@webknjaz
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 18, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 affects_2.14 feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bcoca @mattclay @Shrews @samdoran @webknjaz @ansibot @nitzmahone @eqrx