New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EC2 test suite to work with testing policies #44387

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@willthames
Contributor

willthames commented Aug 20, 2018

SUMMARY
  • Update testing policies to ensure all required permissions are present
  • Remove iam:CreateRole, as that's not a sensible CI permission
  • Make roles static so that they can be present before CI is run,
    meaning that role creation permission is not required by the CI
    itself, only by someone setting up the roles prior to testing
  • Remove EFS policy and move contents to storage policy to ensure policy
    count (maximum of 10) stays low
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_instance

ANSIBLE VERSION
ansible 2.7.0.dev0 (devel 3921f34253) last updated 2018/08/20 20:53:37 (GMT +1000)
  config file = None
  configured module search path = [u'/Users/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/will/src/ansible/lib/ansible
  executable location = /Users/will/src/ansible/bin/ansible
  python version = 2.7.14 (default, Mar  9 2018, 23:57:12) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]
ADDITIONAL INFORMATION
Fix EC2 test suite to work with testing policies
* Update testing policies to ensure all required permissions are present
* Remove iam:CreateRole, as that's not a sensible CI permission
* Make roles static so that they can be present before CI is run,
  meaning that role creation permission is not required by the CI
  itself, only by someone setting up the roles prior to testing
* Remove EFS policy and move contents to storage policy to ensure policy
  count (maximum of 10) stays low

@willthames willthames requested a review from ryansb Aug 20, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 20, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment