New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New module for azure virtual network gateway #44411

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@Madhura-CSI
Contributor

Madhura-CSI commented Aug 20, 2018

SUMMARY

New module for azure virtual network gateway

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_virtualnetworkgateway

ANSIBLE VERSION
ansible 2.6.2
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/centos-dev/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Aug  4 2017, 00:39:18) [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)]
ADDITIONAL INFORMATION

Currently we don't have any existing module to create/update/delete virtual network gateway(VPN gateway) in azure cloud. Hence, I would like to contribute this module to community.
Sample module call is as follows:

    - name: Create virtual network gateway without bgp settings
      azure_rm_virtualnetworkgateway:
        resource_group: testrg
        name: testvpngw
        ip_configurations:
          - name: testipconfig
            private_ip_allocation_method: Dynamic
            public_ip_address_name: testipaddr
        virtual_network: testvnet
        tags:
          common: "xyz"
      register: vgw_without_bgp

By default module waits for VPN gateway to be created.(using poller)

@Madhura-CSI

This comment has been minimized.

Contributor

Madhura-CSI commented Aug 20, 2018

WIP

@ansibot

This comment has been minimized.

Contributor

ansibot commented Aug 20, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:335:20: undefined-variable Undefined variable 'fh'

The test ansible-test sanity --test validate-modules [explain] failed with 9 errors:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E322 "active_active" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E322 "gateway_default_site" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E322 "vpn_client_configuration" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E325 argument_spec for "active_active" defines type="bool" but documentation does not
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E325 argument_spec for "enable_bgp" defines type="bool" but documentation does not
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "gateway_type" does not match the documentation (['Vpn', 'ExpressRoute'])
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "sku" does not match the documentation (['VpnGw1', 'VpnGw2', 'VpnGw3'])
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "vpn_type" does not match the documentation (['RouteBased', 'PolicyBased'])
lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:167:21: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkgateway.py:167:21: error RETURN: syntax error: expected ',' or '}', but got '<scalar>'

click here for bot help

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Aug 28, 2018

@Madhura-CSI Thanks for the contribution, Could you help confirm the PR ready for review or not? if yes, I will push to review! Thanks!

@ansibot

This comment has been minimized.

@ansibot ansibot added the stale_ci label Sep 5, 2018

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Sep 20, 2018

@Madhura-CSI Thanks for the contribution. Could you help finished this PR change? when you finished, I will push to review. Thanks!

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Nov 1, 2018

@Madhura-CSI Thanks for your contribution, Are you still here?Could you help finish the PR changed? if you finished, I will push to review? Thanks!

@Madhura-CSI

This comment has been minimized.

Contributor

Madhura-CSI commented Nov 5, 2018

Yes @Fred-sun , I am working on this PR. Will need few more days to finish the stuff. I will update here once this is ready for review.

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Nov 5, 2018

@Madhura-CSI Thanks for your update, When you finished changed, I will test,. Thanks!

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Nov 26, 2018

kindly ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment