Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module for create/update/delete local network gateway for azure vpn #44414

Open
wants to merge 2,943 commits into
base: devel
from

Conversation

@Madhura-CSI
Copy link
Contributor

commented Aug 20, 2018

SUMMARY

New module for create/update/delete local network gateway for azure vpn

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_localnetworkgateway

ANSIBLE VERSION
ansible 2.6.2
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/centos-dev/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Aug  4 2017, 00:39:18) [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)]
ADDITIONAL INFORMATION

While configuring Azure VPN, we often need to configure local network gateway resource, in order to map on-premises vpn device information with azure. Hence, I would like to contribute this module to community.
Sample module call is as below:

    - name: Create local network gateway, with BGP settings
      azure_rm_localnetworkgateway:
        resource_group: testrg
        name: testlocalgw
        local_address_prefixes:
          - 10.108.0.0/24
          - 10.109.1.0/29
          - 10.106.0.0/27
        gateway_ip_address: 13.71.1.149
        tags:
          common: a
      register: local_network_gateway
@Madhura-CSI

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2018

WIP

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2018

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_localnetworkgateway.py:136:12: undefined-variable Undefined variable 'long'
lib/ansible/modules/cloud/azure/azure_rm_localnetworkgateway.py:152:16: undefined-variable Undefined variable 'long'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_localnetworkgateway.py:101:21: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_localnetworkgateway.py:101:21: error RETURN: syntax error: expected ',' or '}', but got '<scalar>'

click here for bot help

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2018

@Madhura-CSI Thanks for the contribution, Could you help confirm the PR ready for review or not? if yes, I will push to review! Thanks!

@Madhura-CSI

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2018

@Fred-sun , I will need a couple of days more to complete this feature set along with its integration tests.
Will update here once that is done. Thanks!

@ansibot

This comment has been minimized.

@Madhura-CSI Madhura-CSI force-pushed the cambridge-semantics:module-azure_rm_localnetworkgateway branch Aug 28, 2018

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_localnetworkgateway.py:143:12: undefined-variable Undefined variable 'long'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_localnetworkgateway.py:105:21: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_localnetworkgateway.py:105:21: error RETURN: syntax error: expected ',' or '}', but got '<scalar>'

click here for bot help

@ansibot ansibot added test and removed ci_verified labels Aug 28, 2018

@ansibot ansibot added the stale_ci label Sep 5, 2018

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2018

@Madhura-CSI Thanks for the contribution, Could you help confirm that the PR finished change or not? Thanks!

@yuwzho

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2018

@Fred-sun title with [WIP] means "working in process".

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2018

@yuwzho Thanks , I will notice. Thanks!

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2018

@Madhura-CSI Thanks for your contribution, Are you still here? Could you help finish the PR changed? if you finished, I will push to review? Thanks!

@Madhura-CSI

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2018

Yes @Fred-sun , I am working on this PR. Will need another 3-4 days to finish the stuff. I will update here once this is ready for review.

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

@Madhura-CSI Thanks for your update, When you finished changed, I will test,. Thanks!

@Madhura-CSI Madhura-CSI force-pushed the cambridge-semantics:module-azure_rm_localnetworkgateway branch Nov 26, 2018

@ansibot ansibot removed the stale_ci label Nov 26, 2018

bushvin and others added some commits Apr 7, 2019

New module: xfs_quota (#51654)
* New module: xfs_quota

* wildcard import resolution

* pep8 fixes

* validate-modules fixes

* pep8 and validate-module fixes

* removal of extra copyright info

* description capitalization and trailing dot

* Some more description

* type specification

* removal of notes

* reorder imports

* sorting

* starting with variable type

* removal of defaults

* results to dict

* results to dict

* complete condition

* removal of spaces for pep8 compliancy, removal of root check, addition of tests for failed xfs_quota commands indicating the need for elevation/capabilities

* lost result

* typo

* historical override removal

* report back values

* unexpected spaces removal

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* typo

* raw data, full data

* removal of several else: statements and indentation

* pep8

* typo

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* typo

* use bytes as base, not kilobytes

* be consistent

* integration tests

* lint

* empty lines

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* updates

* ci group

* XFS not supported on osx

* XFS not supported by freebsd

* long lines and removal of xfs_quota dict in return

* RETURN values

* no more xfs_quota dict
fix: Don't fail if updating Kinesis stream Shard count; We support th…
…is! (#54530)

This added support for increasing shard count:
#24805

But the conditional to fail if you have specified a shard count other 
than the current shard count was still left in.

This removes that conditional since it's no longer needed and prevents 
you from actually updating things!
added integration tests
integration test fix
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@Madhura-CSI this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@Madhura-CSI This PR contains @ mentions in at least one commit message. Those mentions can cause cascading notifications through GitHub and need to be removed. Please squash or amend your commits to remove the mentions.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@Madhura-CSI This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.
  • More than 50 commits.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@gundalow

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

@Madhura-CSI Could you can give a try according by the above comment? Thanks!

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@Madhura-CSI Are you still here? Could you can rebase this PR according by the above comments? Thanks!

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

@Madhura-CSI Thanks for your contribution, Could you help rebase this and push for merged? or can you add access to me? I'll try rebase this PR! Thanks a lot!

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

kindly ping

@Madhura-CSI

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

Hi @Fred-sun , apologies for delayed response. I will need a couple of days more to address changes. Will revert to you once those are done.

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

@Madhura-CSI Thanks for your feedback! once your finish revert, I will ping maintainer to review! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.