Skip to content

/ ansible

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assume 'all' when only exclusions added to subset #44776

Open
wants to merge 4 commits into
base: devel
from
Open

assume 'all' when only exclusions added to subset #44776

wants to merge 4 commits into from
+37 −47

Conversation

@bcoca
Copy link
Member

@bcoca bcoca commented Aug 28, 2018

SUMMARY

fixes #30929

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

fact gathering

ANSIBLE VERSION
2.x
@bcoca bcoca requested a review from alikins Aug 28, 2018
@bcoca bcoca removed the needs_triage label Aug 28, 2018
@mattclay
Copy link
Member

@mattclay mattclay commented Aug 31, 2018

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/81213/4/tests
CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/81213/55/tests
@ansibot ansibot added the stale_ci label Sep 8, 2018
@mattclay
Copy link
Member

@mattclay mattclay commented Oct 12, 2018

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/87755/8/tests
@ansibot ansibot added the stale_ci label Oct 24, 2018
@bcoca bcoca force-pushed the bcoca:facts_fix branch Nov 7, 2018
@mattclay
Copy link
Member

@mattclay mattclay commented Nov 7, 2018

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/92474/5/tests
CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/92474/56/tests
@mattclay mattclay added the ci_verified label Nov 7, 2018
@ansibot ansibot added the stale_ci label Nov 15, 2018
bcoca added 4 commits Aug 28, 2018
@bcoca
assume 'all' when only exclusions added to subset
8bab9b2 
fixes #30929
@bcoca
the default changed, so test needs to change
541d573
@bcoca
fixed error condition
cd07a9d
@bcoca
unfreeze
Loading status checks…
776e89f
@bcoca bcoca force-pushed the bcoca:facts_fix branch to 776e89f Jan 23, 2019
@ansibot ansibot removed the ci_verified label Jan 23, 2019
@ansibot ansibot removed the stale_ci label Jan 23, 2019
@ansibot ansibot added the stale_ci label Feb 1, 2019
@mattclay mattclay added the ci_verified label Feb 2, 2019
@s-hertel s-hertel self-requested a review Jul 17, 2020
@ansibot ansibot added pre_azp and removed ci_verified stale_ci labels Dec 8, 2020
@eqrx eqrx added the ci_verified label Mar 5, 2021
@ansibot ansibot removed the ci_verified label Mar 5, 2021
@samdoran
Copy link
Member

@samdoran samdoran commented Mar 15, 2021

/azp run
@azure-pipelines
Copy link

@azure-pipelines azure-pipelines bot commented Mar 15, 2021

Azure Pipelines successfully started running 1 pipeline(s).
@ansibot ansibot added the stale_ci label Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alikins alikins

@s-hertel s-hertel

Assignees
No one assigned
Labels
affects_2.7 bug ci_verified needs_revision stale_ci support:core
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Fact ansible_mounts does not exist if facter facts are excluded
5 participants
@bcoca @mattclay @samdoran @ansibot @eqrx