New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os_keystone_endpoint: endpoint_interface, not interface #45216

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
7 participants
@GSergeevich

GSergeevich commented Sep 5, 2018

endpoint_interface in EXAMPLES ,but interface in table.
+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ANSIBLE VERSION

ADDITIONAL INFORMATION

Update os_keystone_endpoint.py
<!--- Your description here -->
endpoint_interface in EXAMPLES ,but interface in table.
+label: docsite_pr
@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 5, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_keystone_endpoint.py:0:0: E309 version_added for new option (endpoint_interface) should be 2.8. Currently 0.0
test/sanity/validate-modules/ignore.txt:283:1: A102 Remove since "lib/ansible/modules/cloud/openstack/os_keystone_endpoint.py" passes "E326" test

click here for bot help

@openstack-zuul

This comment has been minimized.

openstack-zuul bot commented Sep 5, 2018

Build succeeded (third-party-check pipeline).

@albertomurillo

This comment has been minimized.

Contributor

albertomurillo commented Sep 5, 2018

@emonty What was the reason to change os_keystone_endpoint.interface to os_keystone_endpoint.endpoint_interface during #20974 ?

Now the documentation is inconsistent.

I would opt to return it to os_keystone_endpoint.interface to make the option less redundant in name and match var endpoint.interface in the return values

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 25, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_keystone_endpoint.py:0:0: E309 version_added for new option (endpoint_interface) should be 2.8. Currently 0.0
test/sanity/validate-modules/ignore.txt:280:1: A102 Remove since "lib/ansible/modules/cloud/openstack/os_keystone_endpoint.py" passes "E326" test

click here for bot help

@ansibot ansibot added the ci_verified label Sep 25, 2018

@openstack-zuul

This comment has been minimized.

openstack-zuul bot commented Sep 25, 2018

Build succeeded (third-party-check pipeline).

@ansibot ansibot removed the support:core label Oct 3, 2018

@mnaser

This comment has been minimized.

Contributor

mnaser commented Oct 13, 2018

I'm not sure if @emonty had a chance to reply however there are several places where OpenStack will actually want 'interface' as a parameter.

For example, if you want to create an Keystone endpoint, you'll have to specify the interface, that conflicts with the existing non-trivially named interface.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 2, 2018

@gundalow gundalow changed the title from Update os_keystone_endpoint.py to os_keystone_endpoint: endpoint_interface, not interface Nov 9, 2018

@gundalow

This comment has been minimized.

Contributor

gundalow commented Nov 9, 2018

You can use aliases in documentation and argspec to allow both names.
Currently it looks like only the DOCUMENTATION has been updated, but not the code

@gundalow

This comment has been minimized.

Contributor

gundalow commented Nov 29, 2018

@GSergeevich Hi, I hope the comments above make sense. I believe this is your first Ansible PR, so please shout out if you need assistance with anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment