New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elb classic lb: Migrate to boto3 #45434

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@zeenlym
Contributor

zeenlym commented Sep 10, 2018

SUMMARY

AWS boto only modules present issues with corporate internet proxies. Migrate to boto3 solves problems.

Fixes #44889

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • lib/ansible/modules/cloud/amazon/elb_classic_lb.py
  • lib/ansible/modules/cloud/amazon/elb_instance.py
ANSIBLE VERSION
2.5 and 2.6
ADDITIONAL INFORMATION

Yanis LISIMA added some commits Sep 10, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 10, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 10, 2018

Hi @zeenlym,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 10, 2018

The test ansible-test sanity --test pylint [explain] failed with 18 errors:

lib/ansible/modules/cloud/amazon/elb_classic_lb.py:703:52: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:713:52: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:839:48: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:848:48: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:853:50: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:858:50: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:908:66: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:941:63: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:1009:61: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:1043:72: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:1048:64: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:1154:15: too-many-format-args Too many arguments for format string
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:1171:61: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:1239:48: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:1248:52: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:1273:47: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_classic_lb.py:1291:47: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/cloud/amazon/elb_instance.py:333:20: too-many-format-args Too many arguments for format string

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elb_classic_lb.py:827:22: E126 continuation line over-indented for hanging indent

click here for bot help

Yanis LISIMA
@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 11, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elb_classic_lb.py:827:21: E126 continuation line over-indented for hanging indent

click here for bot help

Yanis LISIMA added some commits Sep 12, 2018

@@ -86,34 +86,36 @@
with_items: "{{ ec2_elbs }}"
"""
import time

This comment has been minimized.

@s-hertel

s-hertel Sep 12, 2018

Contributor

Please move porting this module to its own PR. Every PR porting a module to boto3 must also have accompanying integration tests to be able to be merged.

Modules marked stableinterface must keep input and return data the same for backward compatibility, where you have a little more leeway with modules marked preview (but should document anything that doesn't keep the same behavior that it had before).

@mattclay

This comment has been minimized.

Member

mattclay commented Sep 13, 2018

@zeenlym

This comment has been minimized.

Contributor

zeenlym commented Sep 20, 2018

Thanks for all checks, for the next 2 weeks I cannot fix nether add integration tests, I will do it after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment