New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test VyOS via Zuul #45479

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@gundalow
Contributor

gundalow commented Sep 11, 2018

SUMMARY

Add Zuul configuration and roles so that integration tests run for VyOS

  • Test via Python 2 and Python 3
  • Define aliases zuul/vyos/group1 and zuul/network/smoketest
  • Disable Shippable's Network testing as that only covered VyOS
  • Only run tests when PRs change the defined files: (VyOS code or Zuul
  • config)

Requires:

ISSUE TYPE
  • Feature Pull Request
Test VyOS via Zuul
Add Zuul configuration and roles so that integration tests run for VyOS

* Test via Python 2 and Python 3
* Define aliases `zuul/vyos/group1` and `zuul/network/smoketest`
* Disable Shippable's Network testing as that only covered VyOS
* Only run tests when PRs change the defined `files:` (VyOS code or Zuul
* config)

@gundalow gundalow added the networking label Sep 11, 2018

@gundalow gundalow requested a review from mattclay Sep 11, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 11, 2018

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/utils/zuul/playbooks/ansible-test-classification/run.yaml:5:1: error syntax error: could not find expected ':'

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 11, 2018

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/utils/zuul/playbooks/ansible-test-classification/run.yaml:5:1: error syntax error: could not find expected ':'

click here for bot help

@mattclay

mattclay requested changes Sep 11, 2018 edited

Add handling for the .zuul.d directory like we have for .github:

test/runner/lib/classification.py:        if path.startswith('.github/'):
test/runner/lib/target.py:        if root.startswith('.') and root != '.github':

That way the yaml files can be sanity tested.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 19, 2018

@ansibot ansibot added stale_ci and removed support:network labels Sep 19, 2018

@@ -42,8 +42,6 @@ matrix:
- env: T=windows/2012-R2/4
- env: T=windows/2016/4
- env: T=network

This comment has been minimized.

@mattclay

mattclay Sep 19, 2018

Member

Lets keep the VyOS testing on Shippable for a while so we have some overlap until we're confident in the results we're getting by running things under Zuul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment