New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add win iis logs #45521

Open
wants to merge 25 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@crossan007
Contributor

crossan007 commented Sep 11, 2018

SUMMARY

IIS logging is cumbersome to manage. This module provides a clean way to manage the available properties. Manages the IIS log configuration either per-site, or server wide

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

win_iis_logs

This is still a work-in-progress and I'm open to input on the interface / public methods.

@ansibot

This comment was marked as resolved.

Contributor

ansibot commented Sep 11, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:3:1: SyntaxError:

The test ansible-test sanity --test line-endings [explain] failed with 2 errors:

lib/ansible/modules/windows/win_iis_logs.ps1:0:0: use "\n" for line endings instead of "\r\n"
lib/ansible/modules/windows/win_iis_logs.py:0:0: use "\n" for line endings instead of "\r\n"

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:66:1: W293 blank line contains whitespace

The test ansible-test sanity --test pslint [explain] failed with 8 errors:

lib/ansible/modules/windows/win_iis_logs.ps1:16:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-LocalTime. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:35:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-LogDirectory. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:54:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-ExtFileFlags. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:124:25: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:127:21: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:140:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-CustomFields. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:223:1: PSUseDeclaredVarsMoreThanAssignments The variable 'debug' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:227:1: PSUseDeclaredVarsMoreThanAssignments The variable 'log_format' is assigned but never used.

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/windows/win_iis_logs.py:0:0: E305 DOCUMENTATION.options.log_custom_fields.description.0: expected str @ data['options']['log_custom_fields']['description'][0]. Got {'Custom log fileds to be included.  This must be a list of objects with the following properties': 'field_name, source_type, source_name, state'}
lib/ansible/modules/windows/win_iis_logs.py:0:0: E305 DOCUMENTATION.options.log_directory.type: not a valid value for dictionary value @ data['options']['log_directory']['type']. Got 'string'
lib/ansible/modules/windows/win_iis_logs.py:0:0: E305 DOCUMENTATION.options.log_ext_file_flags.description.0: expected str @ data['options']['log_ext_file_flags']['description'][0]. Got {'Built-In IIS Log fields to be included. This must be a list of objects with the following properties': 'field_name, state.'}

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment was marked as resolved.

Contributor

ansibot commented Sep 12, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 99, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test line-endings [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.ps1:0:0: use "\n" for line endings instead of "\r\n"

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/windows/win_iis_logs.py:37:161: E501 line too long (161 > 160 characters)
lib/ansible/modules/windows/win_iis_logs.py:72:1: W293 blank line contains whitespace

The test ansible-test sanity --test pslint [explain] failed with 10 errors:

lib/ansible/modules/windows/win_iis_logs.ps1:18:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-RotationPeriod. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:21:9: PSUseDeclaredVarsMoreThanAssignments The variable 'validValues' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:54:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-LocalTime. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:73:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-LogDirectory. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:92:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-ExtFileFlags. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:162:25: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:165:21: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:178:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-CustomFields. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:261:1: PSUseDeclaredVarsMoreThanAssignments The variable 'debug' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:265:1: PSUseDeclaredVarsMoreThanAssignments The variable 'log_format' is assigned but never used.

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:33:122: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:33:122: error DOCUMENTATION: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot removed the ci_verified label Sep 12, 2018

crossan007 added some commits Sep 12, 2018

@ansibot

This comment was marked as resolved.

Contributor

ansibot commented Sep 12, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 99, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test pslint [explain] failed with 8 errors:

lib/ansible/modules/windows/win_iis_logs.ps1:18:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-RotationPeriod. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:59:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-LocalTime. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:78:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-LogDirectory. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:97:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-ExtFileFlags. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:167:25: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:170:21: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:183:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-CustomFields. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:267:1: PSUseDeclaredVarsMoreThanAssignments The variable 'log_format' is assigned but never used.

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:31:114: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:31:114: error DOCUMENTATION: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot removed the needs_triage label Sep 12, 2018

@jborean93

This comment has been minimized.

Contributor

jborean93 commented Sep 12, 2018

@crossan007 are you aware of how to run the sanity checks locally? The test error explains the command used that failed which you can run locally. I would also recommend you add --docker default which runs the tests in a Docker container that already has all the requirements installed so you don't have to do that yourself.

For example, to run the pslint and yamllint tests you can do

ansible-test sanity --test pslint --test yamllint --docker default
@ansibot

This comment was marked as resolved.

Contributor

ansibot commented Sep 17, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 99, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test pslint [explain] failed with 13 errors:

lib/ansible/modules/windows/win_iis_logs.ps1:18:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-RotationPeriod. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:59:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-ExtFileFlags. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:154:25: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:157:21: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:172:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-CustomFields. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:262:9: PSUseDeclaredVarsMoreThanAssignments The variable 'str' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:278:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-WebConfigurationProperty. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:381:13: PSUseDeclaredVarsMoreThanAssignments The variable 'changed' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:382:13: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:420:17: PSUseDeclaredVarsMoreThanAssignments The variable 'changed' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:421:17: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:473:17: PSUseDeclaredVarsMoreThanAssignments The variable 'changed' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:474:17: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:31:114: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:31:114: error DOCUMENTATION: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot removed the ci_verified label Sep 17, 2018

@ansibot

This comment was marked as resolved.

Contributor

ansibot commented Sep 17, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:87:4: W292 no newline at end of file

The test ansible-test sanity --test pslint [explain] failed with 13 errors:

lib/ansible/modules/windows/win_iis_logs.ps1:25:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-RotationPeriod. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:66:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-ExtFileFlags. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:161:25: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:164:21: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:179:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-CustomFields. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:269:9: PSUseDeclaredVarsMoreThanAssignments The variable 'str' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:284:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-WebConfigurationProperty. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:397:13: PSUseDeclaredVarsMoreThanAssignments The variable 'changed' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:398:13: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:436:17: PSUseDeclaredVarsMoreThanAssignments The variable 'changed' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:437:17: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:489:17: PSUseDeclaredVarsMoreThanAssignments The variable 'changed' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:490:17: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: E305 DOCUMENTATION.options.log_directory.type: not a valid value for dictionary value @ data['options']['log_directory']['type']. Got 'string'

click here for bot help

@ansibot ansibot added the ci_verified label Sep 17, 2018

@crossan007

This comment has been minimized.

Contributor

crossan007 commented Sep 17, 2018

variable scope warning probably related to this: PowerShell/PSScriptAnalyzer#827

@ansibot ansibot removed the ci_verified label Sep 17, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Sep 17, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 99, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/windows/win_iis_logs.py:60:17: W291 trailing whitespace
lib/ansible/modules/windows/win_iis_logs.py:70:17: W291 trailing whitespace
lib/ansible/modules/windows/win_iis_logs.py:72:42: W291 trailing whitespace

The test ansible-test sanity --test pslint [explain] failed with 9 errors:

lib/ansible/modules/windows/win_iis_logs.ps1:25:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-RotationPeriod. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:66:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-ExtFileFlags. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:161:25: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:164:21: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:179:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-CustomFields. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:283:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-WebConfigurationProperty. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:397:13: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:436:17: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:489:17: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:44:10: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:44:10: error DOCUMENTATION: syntax error: expected <block end>, but found '<scalar>'

click here for bot help

@ansibot ansibot added the stale_ci label Sep 27, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 1, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Makefile:95: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 720, in <module>
    main()
  File "../bin/plugin_formatter.py", line 678, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 269, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 100, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 62, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 35, in get_single_data
    node = self.get_single_node()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 82, in compose_node
    node = self.compose_sequence_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 110, in compose_sequence_node
    while not self.check_event(SequenceEndEvent):
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 393, in parse_block_sequence_entry
    "expected <block end>, but found %r" % token.id, token.start_mark)
yaml.parser.ParserError: while parsing a block collection
  in "<unicode string>", line 16, column 7:
          - "The name of the site for whic ... 
          ^
expected <block end>, but found '<scalar>'
  in "<unicode string>", line 31, column 10:
          - "Built-In IIS Log fields to be in ... 
             ^
make: *** [modules] Error 1

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/win_iis_logs/aliases:0:0: missing alias `shippable/windows/group[1-4]` or `unsupported`

The test ansible-test sanity --test line-endings [explain] failed with 1 error:

test/integration/targets/win_iis_logs/tasks/tests.yml:0:0: use "\n" for line endings instead of "\r\n"

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/windows/win_iis_logs.py:60:17: W291 trailing whitespace
lib/ansible/modules/windows/win_iis_logs.py:70:17: W291 trailing whitespace
lib/ansible/modules/windows/win_iis_logs.py:72:42: W291 trailing whitespace

The test ansible-test sanity --test pslint [explain] failed with 9 errors:

lib/ansible/modules/windows/win_iis_logs.ps1:25:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-RotationPeriod. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:66:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-ExtFileFlags. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:161:25: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:164:21: PSUseDeclaredVarsMoreThanAssignments The variable 'newLoggedFields' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:179:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-CustomFields. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:283:13: PSUseSupportsShouldProcess Whatif and/or Confirm manually defined in function Confirm-WebConfigurationProperty. Instead, please use SupportsShouldProcess attribute.
lib/ansible/modules/windows/win_iis_logs.ps1:397:13: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:436:17: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.
lib/ansible/modules/windows/win_iis_logs.ps1:489:17: PSUseDeclaredVarsMoreThanAssignments The variable 'messages' is assigned but never used.

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:44:10: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/windows/win_iis_logs.py:44:10: error DOCUMENTATION: syntax error: expected <block end>, but found '<scalar>'

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment