New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_s3: Improve ETag handling #46332

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@flowerysong
Contributor

flowerysong commented Oct 1, 2018

SUMMARY

Fixes #46040

  • Extract ETag calculation into a utility function for reuse by aws_s3_sync (#39344).
  • Reduce code duplication in put/get by restructuring the logic
  • Only calculate ETag when overwrite == different
  • Fail gracefully when overwrite == different and MD5 isn't available (e.g. due to FIPS-140-2).
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aws_s3

ANSIBLE VERSION
2.8
@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 1, 2018

Hi @flowerysong,

Thank you for the pullrequest, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 1, 2018

The test ansible-test sanity --test shebang [explain] failed with 1 error:

lib/ansible/module_utils/aws/s3.py:0:0: should not have a shebang

click here for bot help

@flowerysong flowerysong force-pushed the flowerysong:aws_s3 branch from 7c30fa5 to 7c5e7e2 Oct 1, 2018

@bcoca bcoca removed needs_triage labels Oct 1, 2018

@ansibot ansibot added the stale_ci label Oct 9, 2018

@flowerysong flowerysong force-pushed the flowerysong:aws_s3 branch from 7c5e7e2 to d2b94fe Oct 13, 2018

@ansibot ansibot removed the stale_ci label Oct 13, 2018

@flowerysong flowerysong force-pushed the flowerysong:aws_s3 branch from d2b94fe to fa1062d Oct 13, 2018

flowerysong added some commits Sep 30, 2018

aws_s3: Improve ETag handling
* Extract ETag calculation into a utility function for reuse by
  aws_s3_sync.
* Reduce code duplication in put/get by restructuring the logic
* Only calculate ETag when overwrite == different
* Fail gracefully when overwrite == different and MD5 isn't available
  (e.g. due to FIPS-140-2).
aws_s3: clean up integration tests
Clean up tests, add tests for overwrite settings in both directions.

@ansibot ansibot added the stale_ci label Oct 25, 2018

@flowerysong flowerysong force-pushed the flowerysong:aws_s3 branch from fa1062d to 3e1f86a Oct 25, 2018

@ansibot ansibot removed the stale_ci label Oct 25, 2018

@ansibot ansibot added the stale_ci label Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment