New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module for AWS CodePipeline #47189

Open
wants to merge 8 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@stefanhorning
Contributor

stefanhorning commented Oct 17, 2018

SUMMARY

New module for AWS CodePipeline service.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aws_codepipeline module

ADDITIONAL INFORMATION

Sucessor of abandoned PR #38751

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 17, 2018

Hi @stefanhorning, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 17, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_codepipeline.py:300:1: E305 expected 2 blank lines after class or function definition, found 1

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 17, 2018

@stefanhorning, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@stefanhorning

This comment has been minimized.

Contributor

stefanhorning commented Oct 17, 2018

@ansibot ansibot removed the ci_verified label Oct 17, 2018

@stefanhorning

This comment has been minimized.

Contributor

stefanhorning commented Oct 17, 2018

Ready to merge

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 17, 2018

@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Madhura-CSI @MichaelBaydoun @Sodki @adq @akazakov @alachaum @amir343 @anryko @bekelchik @bpennypacker @brandond @chenl87 @defunctio @dennisconrad @dkhenry @fiunchinho @fivethreeo @flowerysong @garethr @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @michaeljs1990 @minichate @mjschultz @mmochan @nadirollo @nand0p @naslanidis @nathanwebsterdotme @nerzhul @nickball @orthanc @piontas @pjodouin @prasadkatti @psykotox @pwnall @raags @rickmendes @roadmapper @ryansydnor @scicoin-project @scottanderson42 @sdubrul @shepdelacreme @silviud @slapula @steynovich @tastychutney @tedder @tgerla @timmahoney @tombamford @tsiganenok @viper233 @whiter @willricardo @wilvk @wimnat @yaakov-github @zacblazic @zbal @zeekin @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ryansb

ryansb approved these changes Oct 18, 2018

@ansibot ansibot removed the needs_ci label Oct 19, 2018

- name: create IAM role needed for CodePipeline
iam_role:
name: "{{ resource_prefix }}-codepipeline-service-role"

This comment has been minimized.

@stefanhorning

stefanhorning Oct 19, 2018

Contributor

The tests currently fail on this task, as the CI running gets a AWS permission error when attempting to create the iam_role. Not sure how this is achieved in other tests.

This comment has been minimized.

@ryansb

ryansb Oct 23, 2018

Contributor

In other tests we add the ability to create an IAM role, but only to attach a specific subset of policies, such as "S3ReadOnly" or similar. Pretty much the minimal permissions necessary to exercise the module. Is there an existing managed policy that grants the perms that CodePipeline needs for these tests?

This comment has been minimized.

@stefanhorning

stefanhorning Oct 24, 2018

Contributor

Actually I don't need any permission policy for this role, just the 'assume' policy that I have added already to make it possible for the code pipeline to use the role. But as the test just creates the project but doesn't execute it it needs no permissions to any services.
So all I need is for the CI runner to create this IAM role. Not sure what to do for it.

This comment has been minimized.

@mattclay

mattclay Nov 5, 2018

Member

I've added the needs_ci_update label to this PR, which puts it on the list of PRs which are awaiting updates to our CI system.

This comment has been minimized.

@stefanhorning

stefanhorning Nov 5, 2018

Contributor

Perfect. Thanks!

stefanhorning added some commits Dec 12, 2018

@stefanhorning

This comment has been minimized.

Contributor

stefanhorning commented Dec 12, 2018

ready_for_review

IMO ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment