New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] DigitalOcean module deprecation #47272

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@BondAnthony
Contributor

BondAnthony commented Oct 18, 2018

SUMMARY

Deprecation of digital_ocean module in favor of digital_ocean_droplet. This migration completes removal of all external software dependencies from the digital_ocean modules.

This change can be merged after #33984

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/digital_ocean/digital_ocean.py

ANSIBLE VERSION
ansible 2.8.0.dev0 (feature/dep-do-module ba8da1b9a1) last updated 2018/10/18 06:53:05 (GMT -400)
  config file = /Users/abond/Dev/github/ansible.cfg
  configured module search path = ['/Users/abond/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/abond/Dev/github/ansible/lib/ansible
  executable location = /Users/abond/Dev/github/ansible/bin/ansible
  python version = 3.7.0 (default, Jun 29 2018, 20:14:27) [Clang 9.0.0 (clang-900.0.39.2)]

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 18, 2018

Hi @BondAnthony, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 18, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 18, 2018

The test ansible-test sanity --test botmeta [explain] failed with 1 error:

.github/BOTMETA.yml:0:0: Can't find 'lib/ansible/modules/cloud/digital_ocean/digital_ocean.py.*' in this branch

The test ansible-test sanity --test use-compat-six [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/_digital_ocean.py:192:1: use `ansible.module_utils.six` instead of `six`

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/_digital_ocean.py:0:0: E322 "API_TOKEN" is listed in the argument_spec, but not documented in the module

click here for bot help

@ansibot ansibot removed the needs_triage label Oct 18, 2018

@BondAnthony BondAnthony force-pushed the BondAnthony:feature/dep-do-module branch from ba8da1b to ab6276c Oct 19, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 19, 2018

The test ansible-test sanity --test botmeta [explain] failed with 1 error:

.github/BOTMETA.yml:0:0: Can't find 'lib/ansible/modules/cloud/digital_ocean/digital_ocean.py.*' in this branch

The test ansible-test sanity --test use-compat-six [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/_digital_ocean.py:192:1: use `ansible.module_utils.six` instead of `six`

click here for bot help

@BondAnthony BondAnthony force-pushed the BondAnthony:feature/dep-do-module branch from ab6276c to 81453f3 Oct 19, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 19, 2018

The test ansible-test sanity --test use-compat-six [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/_digital_ocean.py:192:1: use `ansible.module_utils.six` instead of `six`

click here for bot help

@ansibot ansibot added the ci_verified label Oct 19, 2018

@BondAnthony BondAnthony force-pushed the BondAnthony:feature/dep-do-module branch from 81453f3 to 03a4dd4 Oct 23, 2018

@ansibot ansibot removed the ci_verified label Oct 23, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 23, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/_digital_ocean.py:192:4: useless-import-alias Import alias does not rename original package

The test ansible-test sanity --test changelog [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/changelog.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "packaging/release/changelogs/changelog.py", line 814, in <module>
    main()
  File "packaging/release/changelogs/changelog.py", line 98, in main
    args.func(args)
  File "packaging/release/changelogs/changelog.py", line 109, in command_lint
    lint_fragments(fragments, exceptions)
  File "packaging/release/changelogs/changelog.py", line 227, in lint_fragments
    errors += linter.lint(fragment)
  File "packaging/release/changelogs/changelog.py", line 307, in lint
    errors += [(fragment.path, 0, 0, result[1]) for result in results]
  File "packaging/release/changelogs/changelog.py", line 307, in <listcomp>
    errors += [(fragment.path, 0, 0, result[1]) for result in results]
  File "/usr/local/lib/python3.6/dist-packages/rstcheck.py", line 169, in check
    find_ignored_languages(source)
  File "/usr/local/lib/python3.6/dist-packages/rstcheck.py", line 235, in find_ignored_languages
    for (index, line) in enumerate(source.splitlines()):
AttributeError: 'dict' object has no attribute 'splitlines'
Traceback (most recent call last):
  File "test/sanity/code-smell/changelog.py", line 14, in <module>
    main()
  File "test/sanity/code-smell/changelog.py", line 10, in main
    subprocess.check_call(cmd)
  File "/usr/lib/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['packaging/release/changelogs/changelog.py', 'lint', 'changelogs/fragments/2.8-core-deprecations.yaml', 'changelogs/fragments/2.8-removed-modules.yaml', 'changelogs/fragments/42866-galaxy-search-unicode.yaml', 'changelogs/fragments/43123-add_support_for_per_host_no_stats.yaml', 'changelogs/fragments/43874-docker_container-stop_timeout.yaml', 'changelogs/fragments/44278-pamd_valid_simple_controls.yaml', 'changelogs/fragments/44789-docker_container-comparisons.yaml', 'changelogs/fragments/45628-fetch_url-error-headers.yaml', 'changelogs/fragments/46322-docker_container-image-not-given.yaml', 'changelogs/fragments/46594-docker_container-publish-all-ports.yml', 'changelogs/fragments/46595-docker_container-expected_ports.yml', 'changelogs/fragments/46596-docker_container-published_ports.yml', 'changelogs/fragments/46598-docker_container-volume-modes.yml', 'changelogs/fragments/46739-gcp-compute-instance-metadata.yaml', 'changelogs/fragments/46743-fix-native-jinja-newlines.yaml', 'changelogs/fragments/46961_fix_aws_ec2_cache.yaml', 'changelogs/fragments/47247-docker_container-add-runtime-option.yaml', 'changelogs/fragments/47281-pamd-dont-delete-named_temporary_file_on_close.yaml', 'changelogs/fragments/47307-handler-include-task.yml', 'changelogs/fragments/add-elapsed-return-value-to-select-modules.yaml', 'changelogs/fragments/agnostic-become-prompt.yaml', 'changelogs/fragments/ajson-nested-decode.yaml', 'changelogs/fragments/ansible-doc-fixes.yml', 'changelogs/fragments/async-dir.yaml', 'changelogs/fragments/async_statys_pyx_compat_fix.yml', 'changelogs/fragments/azure_rm_appgateway-probe.yaml', 'changelogs/fragments/azure_rm_deployment_fix_45941.yaml', 'changelogs/fragments/blockinfile-bytes-fix.yaml', 'changelogs/fragments/code-cleanup-no-get-exception.yaml', 'changelogs/fragments/copy-diff-text.yaml', 'changelogs/fragments/copy-recursive-remote-src.yml', 'changelogs/fragments/dd-put-empty-files.yaml', 'changelogs/fragments/delegate_to_loop_hostvars.yaml', 'changelogs/fragments/dnf-group-removal.yaml', 'changelogs/fragments/docker-image-ids.yaml', 'changelogs/fragments/docker_container-idempotency.yaml', 'changelogs/fragments/drop-pkg_resources.yaml', 'changelogs/fragments/ec2_asg-launch-template-support.yml', 'changelogs/fragments/ec2_group_fix_target_containing_list_within_list.yaml', 'changelogs/fragments/elb_target_group_fix_KeyError.yaml', 'changelogs/fragments/fix_ec2_group_target_vpc_precedence.yaml', 'changelogs/fragments/fix_ec2_group_vpc_precedence_classic.yaml', 'changelogs/fragments/free-strategy-include-var-tags.yaml', 'changelogs/fragments/get-url-fix-idempotency.yaml', 'changelogs/fragments/get_url.yaml', 'changelogs/fragments/inv_fixes.yml', 'changelogs/fragments/lineinfile-insertbefore-index-out-of-range.yaml', 'changelogs/fragments/loop-empty-literal-list.yaml', 'changelogs/fragments/loop_undefined_delegate_to.yaml', 'changelogs/fragments/macports-upgrade-selfupdate.yml', 'changelogs/fragments/mysql-migrate_to_pymysql.yaml', 'changelogs/fragments/no-mutable-fieldattribute-defaults.yaml', 'changelogs/fragments/no_empty_groups.yml', 'changelogs/fragments/openssl-python3.yaml', 'changelogs/fragments/openstack_inventory_fix.yml', 'changelogs/fragments/piped-transfer-empty-files.yaml', 'changelogs/fragments/plugin-docs-list-fix.yaml', 'changelogs/fragments/plugin-filters-cfg.yaml', 'changelogs/fragments/postgresql_user-not-sup-error.yaml', 'changelogs/fragments/psexec-handle-socket-errors.yaml', 'changelogs/fragments/psexec-imp-error.yaml', 'changelogs/fragments/reboot-show-timeout.yaml', 'changelogs/fragments/reboot-unicode-string.yaml', 'changelogs/fragments/reboot_missing_parameter.yaml', 'changelogs/fragments/reboot_openbsd_support.yaml', 'changelogs/fragments/restore_sigpipe_dfl.yml', 'changelogs/fragments/run-command-expand-shell.yaml', 'changelogs/fragments/s3_bucket_fix_non_str_tags.yaml', 'changelogs/fragments/script-module-no-file-path.yaml', 'changelogs/fragments/sns-boto3.yaml', 'changelogs/fragments/solaris-prtdiag-path.yaml', 'changelogs/fragments/tower_credential_ssh_key_data.yaml', 'changelogs/fragments/unsafe-set-wrap.yaml', 'changelogs/fragments/user-do-not-pass-ssh_key_passphrase-on-cmdline.yaml', 'changelogs/fragments/user-docs-underlying-tools.yaml', 'changelogs/fragments/v2.8.0-initial-commit.yaml', 'changelogs/fragments/win_copy-dest-quote.yaml', 'changelogs/fragments/win_group_membership-com-marshal.yaml', 'changelogs/fragments/win_package_chdir.yaml', 'changelogs/fragments/win_say-fix.yaml', 'changelogs/fragments/win_scheduled_task-repetition.yaml', 'changelogs/fragments/win_script-become.yaml', 'changelogs/fragments/windows-deprecated-functionality.yaml', 'changelogs/fragments/windows-exec-changes.yaml', 'changelogs/fragments/windows-psrp-unreachable.yaml', 'changelogs/fragments/winrm_pexpect.yaml', 'changelogs/fragments/yumdnf-update-cache.yaml']' returned non-zero exit status 1.

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/modules/cloud/amazon/test_iam_password_policy.py:12:1: E302 expected 2 blank lines, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/system/user.py:876:21: E210 subprocess.Popen call found. Should be module.run_command

click here for bot help

@ansibot ansibot added the stale_ci label Oct 31, 2018

@ansibot ansibot added the needs_rebase label Nov 8, 2018

@BondAnthony BondAnthony force-pushed the BondAnthony:feature/dep-do-module branch 2 times, most recently from 46af04b to 887feff Nov 13, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 13, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/_digital_ocean.py:192:4: useless-import-alias Import alias does not rename original package

click here for bot help

@ansibot ansibot added the ci_verified label Nov 13, 2018

@@ -185,7 +189,7 @@
try:
# Imported as a dependency for dopy
import six
import ansible.module_utils.six as six

This comment has been minimized.

@acozine

acozine Nov 16, 2018

Contributor

You can fix the last Shippable failure by changing this to from ansible.module_utils import six.

This comment has been minimized.

@BondAnthony

BondAnthony Nov 17, 2018

Contributor

Yea I thought I made this change but it appears I didn't push my code from a different machine. Taken care of in the latest commit and I removed the [WIP] title. Just waiting on the other module now.

@BondAnthony BondAnthony force-pushed the BondAnthony:feature/dep-do-module branch 3 times, most recently from f56f578 to 19bc284 Nov 17, 2018

@ansibot ansibot removed the ci_verified label Nov 17, 2018

@BondAnthony BondAnthony changed the title from [WIP] DigitalOcean module deprecation to DigitalOcean module deprecation Nov 17, 2018

@ansibot ansibot added core_review and removed WIP labels Nov 17, 2018

@gundalow

This comment has been minimized.

Contributor

gundalow commented Nov 28, 2018

@BondAnthony Could you please rebase ~~then I think we can merge this ~~ https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html

EDIT: Need to get #33984 merged first. I've changed this PR back to [WIP] so we don't merge before the other PR

@gundalow gundalow changed the title from DigitalOcean module deprecation to [WIP] DigitalOcean module deprecation Nov 28, 2018

@ansibot ansibot added the WIP label Nov 28, 2018

@BondAnthony BondAnthony force-pushed the BondAnthony:feature/dep-do-module branch from 19bc284 to 9114fa0 Nov 28, 2018

@BondAnthony

This comment has been minimized.

Contributor

BondAnthony commented Nov 28, 2018

@gundalow rebased the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment