Add support to urls util for special characters in proxy username and password #47346

rafis · 2018-10-19T10:52:26Z

SUMMARY

When using any module which uses ansible.module_utils.urls and your username or password for proxy contain special characters like '#' you will get the following error:

fatal: [some_machine]: FAILED! => {"changed": false, "msg": "Connection to proxy failed"}

More detailed error log reveals that error happened in ansible.module_utils.urls:

The full traceback is:
  File "/tmp/ansible_jg073rku/ansible_modlib.zip/ansible/module_utils/urls.py", line 1058, in fetch_url
    client_key=client_key, cookies=cookies)
  File "/tmp/ansible_jg073rku/ansible_modlib.zip/ansible/module_utils/urls.py", line 961, in open_url
    r = urllib_request.urlopen(*urlopen_args)
  File "/usr/lib/python3.6/urllib/request.py", line 223, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.6/urllib/request.py", line 524, in open
    req = meth(req)
  File "/tmp/ansible_jg073rku/ansible_modlib.zip/ansible/module_utils/urls.py", line 753, in http_request
    self.validate_proxy_response(connect_result)
  File "/tmp/ansible_jg073rku/ansible_modlib.zip/ansible/module_utils/urls.py", line 676, in validate_proxy_response
    raise ProxyError('Connection to proxy failed')

fatal: [some_machine]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "data": null,
            "file": null,
            "id": null,
            "key": null,
            "keyring": null,
            "keyserver": null,
            "state": "present",
            "url": "https://pkg.jenkins.io/debian-stable/jenkins.io.key",
            "validate_certs": true
        }
    },
    "msg": "Connection to proxy failed"
}

In my case it was authentication error, because base64 encoded credentials were wrong.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ansible.module_utils.urls

ANSIBLE VERSION

ansible 2.6.5
  config file = /home/user/ansible/ansible.cfg
  configured module search path = ['/home/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.5 (default, Apr  1 2018, 05:46:30) [GCC 7.3.0]

ADDITIONAL INFORMATION

For example, apt_key module uses ansible.module_utils.urls to download key file. Note the "%23" special character here.

- name: Add Jenkins apt repository key.
  environment:
    http_proxy: "http://SA0001user:password%23SpecialCharacter@proxy.corporation.com:3128"
  apt_key:
    url: "https://pkg.jenkins.io/debian-stable/jenkins.io.key"
    state: present

Before

fatal: [some_machine]: FAILED! => {"changed": false, "msg": "Connection to proxy failed"}

After

changed: [some_machine]

ansibot · 2018-10-19T11:02:37Z

Hi @rafis, thank you for submitting this pull-request!

click here for bot help

rafis · 2018-10-22T08:14:26Z

I made rebase to latest devel, how to trigger CI processing again?

rafis · 2018-10-22T08:14:42Z

I made rebase to latest devel, how to trigger CI processing again?

rafis · 2018-10-22T08:22:42Z

I have made rebase latest devel, how to trigger CI processing again?

rafis · 2018-10-22T08:23:00Z

I have made rebase to latest devel, how to trigger CI processing again?

mattclay · 2018-11-05T18:47:18Z

@rafis Tests run automatically in CI each time you push new commits to your PR.

mattclay · 2018-11-05T18:49:47Z

CI is failing because ansible.module_utils.six.moves.urllib.parse.unquote does not exist.

jimi-c · 2020-05-29T15:46:57Z

Hi @rafis are you still interested in pursuing this? @mattclay pointed out the error above however there has been no follow-up to correct the issue. This will also require a changelog entry as well as tests to verify the behavior.

Also cc'ing @sivel for review.

Thanks!

samdoran · 2021-03-15T18:06:33Z

/azp run

azure-pipelines · 2021-03-15T18:06:43Z

Azure Pipelines successfully started running 1 pipeline(s).

ansibot · 2021-03-15T18:44:08Z

The test ansible-test sanity --test package-data [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/package-data.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 379, in <module>
    main()
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 356, in main
    sdist_path = create_sdist(tmp_dir)
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 170, in create_sdist
    raise Exception('make snapshot failed:\n%s' % stderr)
Exception: make snapshot failed:
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
Traceback (most recent call last):
  File "hacking/build-ansible.py", line 103, in <module>
    main()
  File "hacking/build-ansible.py", line 92, in main
    retval = command.main(args)
  File "/tmp/tmpm7m5_czh/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 279, in main
    allvars[cli_name] = opts_docs(cli_class_name, cli_name)
  File "/tmp/tmpm7m5_czh/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 120, in opts_docs
    fromlist=[cli_class_name]), cli_class_name)
  File "/tmp/tmpm7m5_czh/lib/ansible/cli/galaxy.py", line 25, in <module>
    from ansible.galaxy.api import GalaxyAPI
  File "/tmp/tmpm7m5_czh/lib/ansible/galaxy/api.py", line 26, in <module>
    from ansible.module_utils.urls import open_url, prepare_multipart
  File "/tmp/tmpm7m5_czh/lib/ansible/module_utils/urls.py", line 73, in <module>
    import ansible.module_utils.six.moves.urllib.parse.unquote as urllib_parse_unquote
ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package
make: *** [generate_rst] Error 1

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make core_singlehtmldocs' failed with status code: 2
--> Standard Output
../../hacking/build-ansible.py collection-meta --template-file=../templates/collections_galaxy_meta.rst.j2 --output-dir=rst/dev_guide/ ../../lib/ansible/galaxy/data/collections_galaxy_meta.yml
../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ ../../lib/ansible/config/base.yml
mkdir -p rst/cli
../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
Makefile:185: recipe for target 'cli' failed
--> Standard Error
Traceback (most recent call last):
  File "../../hacking/build-ansible.py", line 103, in <module>
    main()
  File "../../hacking/build-ansible.py", line 92, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 279, in main
    allvars[cli_name] = opts_docs(cli_class_name, cli_name)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/generate_man.py", line 120, in opts_docs
    fromlist=[cli_class_name]), cli_class_name)
  File "/root/ansible/lib/ansible/cli/galaxy.py", line 25, in <module>
    from ansible.galaxy.api import GalaxyAPI
  File "/root/ansible/lib/ansible/galaxy/api.py", line 26, in <module>
    from ansible.module_utils.urls import open_url, prepare_multipart
  File "/root/ansible/lib/ansible/module_utils/urls.py", line 73, in <module>
    import ansible.module_utils.six.moves.urllib.parse.unquote as urllib_parse_unquote
ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package
make: *** [cli] Error 1

The test ansible-test sanity --test validate-modules [explain] failed with 17 errors:

lib/ansible/modules/apt.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package'
lib/ansible/modules/apt_key.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package'
lib/ansible/modules/apt_repository.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package'
lib/ansible/modules/dnf.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package'
lib/ansible/modules/get_url.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package'
lib/ansible/modules/rpm_key.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package'
lib/ansible/modules/unarchive.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package'
lib/ansible/modules/uri.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package'
lib/ansible/modules/yum.py:0:0: import-error: Exception attempting to import module for argument_spec introspection, 'No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package'
test/sanity/ignore.txt:86:1: A100: Ignoring 'parameter-invalid' on 'lib/ansible/modules/apt.py' is unnecessary
test/sanity/ignore.txt:87:1: A100: Ignoring 'parameter-type-not-in-doc' on 'lib/ansible/modules/apt_key.py' is unnecessary
test/sanity/ignore.txt:88:1: A100: Ignoring 'parameter-invalid' on 'lib/ansible/modules/apt_repository.py' is unnecessary
test/sanity/ignore.txt:105:1: A100: Ignoring 'doc-required-mismatch' on 'lib/ansible/modules/dnf.py' is unnecessary
test/sanity/ignore.txt:106:1: A100: Ignoring 'parameter-invalid' on 'lib/ansible/modules/dnf.py' is unnecessary
test/sanity/ignore.txt:132:1: A100: Ignoring 'nonexistent-parameter-documented' on 'lib/ansible/modules/unarchive.py' is unnecessary
test/sanity/ignore.txt:134:1: A100: Ignoring 'doc-required-mismatch' on 'lib/ansible/modules/uri.py' is unnecessary
test/sanity/ignore.txt:139:1: A100: Ignoring 'parameter-invalid' on 'lib/ansible/modules/yum.py' is unnecessary

The test ansible-test sanity --test import --python 3.9 [explain] failed with 11 errors:

lib/ansible/module_utils/urls.py:73:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package
lib/ansible/modules/apt.py:327:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_key.py:158:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_repository.py:147:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/dnf.py:328:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/get_url.py:347:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/rpm_key.py:81:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/unarchive.py:232:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/uri.py:423:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/yum.py:375:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/plugins/lookup/url.py:179:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)

The test ansible-test sanity --test import --python 3.8 [explain] failed with 11 errors:

lib/ansible/module_utils/urls.py:73:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package
lib/ansible/modules/apt.py:327:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_key.py:158:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_repository.py:147:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/dnf.py:328:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/get_url.py:347:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/rpm_key.py:81:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/unarchive.py:232:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/uri.py:423:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/yum.py:375:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/plugins/lookup/url.py:179:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)

The test ansible-test sanity --test import --python 3.7 [explain] failed with 11 errors:

lib/ansible/module_utils/urls.py:73:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package
lib/ansible/modules/apt.py:327:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_key.py:158:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_repository.py:147:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/dnf.py:328:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/get_url.py:347:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/rpm_key.py:81:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/unarchive.py:232:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/uri.py:423:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/yum.py:375:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/plugins/lookup/url.py:179:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)

The test ansible-test sanity --test import --python 3.6 [explain] failed with 11 errors:

lib/ansible/module_utils/urls.py:73:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package
lib/ansible/modules/apt.py:327:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_key.py:158:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_repository.py:147:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/dnf.py:328:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/get_url.py:347:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/rpm_key.py:81:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/unarchive.py:232:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/uri.py:423:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/yum.py:375:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/plugins/lookup/url.py:179:0: traceback: ModuleNotFoundError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)

The test ansible-test sanity --test import --python 3.5 [explain] failed with 11 errors:

lib/ansible/module_utils/urls.py:73:0: traceback: ImportError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package
lib/ansible/modules/apt.py:327:0: traceback: ImportError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_key.py:158:0: traceback: ImportError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_repository.py:147:0: traceback: ImportError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/dnf.py:328:0: traceback: ImportError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/get_url.py:347:0: traceback: ImportError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/rpm_key.py:81:0: traceback: ImportError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/unarchive.py:232:0: traceback: ImportError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/uri.py:423:0: traceback: ImportError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/yum.py:375:0: traceback: ImportError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/plugins/lookup/url.py:179:0: traceback: ImportError: No module named 'ansible.module_utils.six.moves.urllib.parse.unquote'; 'ansible.module_utils.six.moves.urllib.parse' is not a package (at lib/ansible/module_utils/urls.py:73:0)

The test ansible-test sanity --test import --python 2.7 [explain] failed with 11 errors:

lib/ansible/module_utils/urls.py:73:0: traceback: ImportError: No module named unquote
lib/ansible/modules/apt.py:327:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_key.py:158:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_repository.py:147:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/dnf.py:328:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/get_url.py:347:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/rpm_key.py:81:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/unarchive.py:232:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/uri.py:423:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/yum.py:375:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/plugins/lookup/url.py:179:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)

The test ansible-test sanity --test import --python 2.6 [explain] failed with 10 errors:

lib/ansible/module_utils/urls.py:73:0: traceback: ImportError: No module named unquote
lib/ansible/modules/apt.py:327:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_key.py:158:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/apt_repository.py:147:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/dnf.py:328:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/get_url.py:347:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/rpm_key.py:81:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/unarchive.py:232:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/uri.py:423:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)
lib/ansible/modules/yum.py:375:0: traceback: ImportError: No module named unquote (at lib/ansible/module_utils/urls.py:73:0)

click here for bot help

ansibot added affects_2.8 bug community_review needs_triage new_contributor python3 small_patch support:community traceback needs_revision and removed community_review labels Oct 19, 2018

samdoran removed the needs_triage label Oct 19, 2018

samdoran requested a review from sivel Oct 19, 2018

Add support for special characters in proxy username and password

Loading status checks…

48fd2ad

rafis force-pushed the rafis:devel branch to 48fd2ad Oct 22, 2018

rafis closed this Oct 22, 2018

rafis reopened this Oct 22, 2018

ansibot added the stale_ci label Oct 30, 2018

mattclay added the ci_verified label Nov 5, 2018

ansibot added support:core and removed support:community labels Jan 8, 2019

ansibot removed the ci_verified label Dec 7, 2020

ansibot added pre_azp and removed stale_ci labels Dec 7, 2020

eqrx added the ci_verified label Mar 5, 2021

ansibot removed the ci_verified label Mar 5, 2021

ansibot added core_review and removed needs_revision pre_azp labels Mar 15, 2021

ansibot added needs_revision and removed core_review labels Mar 15, 2021

samdoran added the ci_verified label Mar 17, 2021

ansibot added the stale_ci label Mar 25, 2021

ansible / ansible

Add support to urls util for special characters in proxy username and password #47346

Add support to urls util for special characters in proxy username and password #47346

rafis commented Oct 19, 2018 •

edited

ansibot commented Oct 19, 2018

rafis commented Oct 22, 2018

rafis commented Oct 22, 2018

rafis commented Oct 22, 2018

rafis commented Oct 22, 2018

mattclay commented Nov 5, 2018

mattclay commented Nov 5, 2018

jimi-c commented May 29, 2020

samdoran commented Mar 15, 2021

azure-pipelines bot commented Mar 15, 2021

ansibot commented Mar 15, 2021

ansible / ansible

Add support to urls util for special characters in proxy username and password #47346

Add support to urls util for special characters in proxy username and password #47346

Conversation

rafis commented Oct 19, 2018 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented Oct 19, 2018

rafis commented Oct 22, 2018

rafis commented Oct 22, 2018

rafis commented Oct 22, 2018

rafis commented Oct 22, 2018

mattclay commented Nov 5, 2018

mattclay commented Nov 5, 2018

jimi-c commented May 29, 2020

samdoran commented Mar 15, 2021

azure-pipelines bot commented Mar 15, 2021

ansibot commented Mar 15, 2021

rafis commented Oct 19, 2018 •

edited