New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] adding sql virtual network rule #47384

Open
wants to merge 19 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@zikalino
Contributor

zikalino commented Oct 21, 2018

SUMMARY

Adding support for SQL Virtual Network rule

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_sqlvirtualnetworkrule

ANSIBLE VERSION

2.7

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 21, 2018

Hi @zikalino, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

@zikalino zikalino force-pushed the VSChina:sqlvirtualnetworkrule branch from 62a364f to 3f69005 Oct 22, 2018

@zikalino zikalino changed the title from adding sql virtual network rule to [WIP] adding sql virtual network rule Oct 22, 2018

@ansibot ansibot added WIP and removed needs_ci stale_ci labels Oct 22, 2018

zikalino added some commits Oct 22, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 23, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:161: E501 line too long (179 > 160 characters)

click here for bot help

zikalino added some commits Oct 23, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 23, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:0: syntax-error invalid syntax (<unknown>, line 181)

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 720, in <module>
    main()
  File "../bin/plugin_formatter.py", line 678, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 269, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 99, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 43, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 181
    if (self.ignore_missing_vnet_service_endpoint is not None) and
                                                                 ^
SyntaxError: invalid syntax
make: *** [modules] Error 1

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:79: SyntaxError: if (self.ignore_missing_vnet_service_endpoint is not None) and

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:79: SyntaxError: if (self.ignore_missing_vnet_service_endpoint is not None) and

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:79: SyntaxError: if (self.ignore_missing_vnet_service_endpoint is not None) and

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:79: SyntaxError: if (self.ignore_missing_vnet_service_endpoint is not None) and

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:79: SyntaxError: if (self.ignore_missing_vnet_service_endpoint is not None) and

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:79: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:79: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:79: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:79: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:79: SyntaxError: invalid syntax

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:182:25: E113 unexpected indentation
lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:183:21: E901 IndentationError: unindent does not match any outer indentation level

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:181:79: python-syntax-error invalid syntax (<unknown>, line 181)

click here for bot help

zikalino added some commits Oct 23, 2018

@zikalino zikalino closed this Oct 23, 2018

@zikalino zikalino reopened this Oct 23, 2018

@zikalino zikalino closed this Oct 23, 2018

@zikalino zikalino reopened this Oct 23, 2018

@zikalino zikalino closed this Oct 23, 2018

@zikalino zikalino reopened this Oct 23, 2018

@zikalino zikalino closed this Oct 23, 2018

@zikalino zikalino reopened this Oct 23, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 23, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlvirtualnetworkrule.py:0:0: E325 argument_spec for "ignore_missing_vnet_service_endpoint" defines type="bool" but documentation does not

click here for bot help

zikalino added some commits Oct 23, 2018

fix

@zikalino zikalino closed this Oct 25, 2018

@zikalino zikalino reopened this Oct 25, 2018

@jborean93 jborean93 removed the needs_triage label Oct 26, 2018

@ansibot ansibot added the stale_ci label Nov 3, 2018

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Dec 6, 2018

kindly ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment