New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for - Unable to create postgresql RDS Instance #47410

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@JrodJ

JrodJ commented Oct 22, 2018

SUMMARY

Adding postgresql-license as an allowed choice for license_model. Current implementation does not allow for creation of a postgresql RDS instance postgresql-license is not an allowed choice.

Fixes #47405

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rds_instance.py

ANSIBLE VERSION
ansible 2.7.0
  config file = /home/jjohnston/ansible.cfg
  configured module search path = [u'/opt/GIT/gitcentral/Ansible/custom_modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May 31 2018, 09:41:32) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]
ADDITIONAL INFORMATION

When creating a PostgreSQL RDS instance with the rds_instance.py module, use any of the currently allowed license_models and described in the documentation and you will get an error that you must use postgresql-license as the license_model from boto. If you do use postgresql-license, you will get an error from Ansible module rds_instance.py that it is not allowed.

When using postgresql-license as the license_model you get this error:

fatal: [localhost]: FAILED! => changed=false
  msg: 'value of license_model must be one of: license-included, bring-your-own-license, general-public-license, got: postgresql-license'

When using any of the three allowed license models: 'license-included', 'bring-your-own-license', 'general-public-license', you get this error:

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ClientError: An error occurred (InvalidParameterCombination) when calling the ModifyDBInstance operation: The bring-your-own-license LicenseModel cannot be used for this configuration
@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 22, 2018

Hi @JrodJ, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 22, 2018

@JrodJ, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

Jarrod S. Johnston

@JrodJ JrodJ changed the title from Adding postgresql-license as an allowed choice for license_model to Fix for issues #47405 and #47595 - Unable to create postgresql RDS Instance, bug in ec2_ami_copy module Oct 25, 2018

@jborean93 jborean93 removed the needs_triage label Oct 26, 2018

@ansibot ansibot added the stale_ci label Nov 3, 2018

@Akasurde Akasurde changed the title from Fix for issues #47405 and #47595 - Unable to create postgresql RDS Instance, bug in ec2_ami_copy module to Fix for - Unable to create postgresql RDS Instance Nov 15, 2018

@Akasurde

This comment has been minimized.

Member

Akasurde commented Nov 15, 2018

@JrodJ Thanks for the PR, could you please rebase this branch ? Thanks.

@@ -1038,7 +1039,7 @@ def main():
force_failover=dict(type='bool'),
iops=dict(type='int'),
kms_key_id=dict(),
license_model=dict(choices=['license-included', 'bring-your-own-license', 'general-public-license']),
license_model=dict(choices=['license-included', 'bring-your-own-license', 'general-public-license', 'postgresql-license']),

This comment has been minimized.

@Akasurde

Akasurde Nov 15, 2018

Member

Pardon me if I am wrong, but I don't see postgresql-license as a valid option in boto3 documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment