New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Unify docs css #47450

Open
wants to merge 5 commits into
base: devel
from

Conversation

2 participants
@acozine
Contributor

acozine commented Oct 22, 2018

SUMMARY

Follow-up on #45089. That fix wasn't publishing correctly . . . because the Makefile was using the srtd theme instead of the theme where that fix was implemented (sphinx-rtd-theme). The sphinx-rtd-theme files were added in February, 2018: https://github.com/ansible/ansible/commits/devel/docs/docsite/_themes/sphinx_rtd_theme.

For future clarity, so we don't change unused CSS files, we should only have one theme.

This PR experiments with removing the srtd theme, updates the Makefile, and changes the css to fix the indentation issue.

The branch is being published (temporarily) to https://docs.ansible.com/ansible/latest/index.html - feedback encouraged, since I'm not sure if this breaks anything.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com left nav, css, & makefile

ANSIBLE VERSION

2.8

@acozine acozine added WIP docs labels Oct 22, 2018

@acozine acozine added this to To do in Ansible Core Documentation via automation Oct 22, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 23, 2018

Hi @acozine, thank you for submitting this pull-request!

click here for bot help

@acozine acozine force-pushed the acozine:unify_docs_css branch from c905036 to 7c5395b Oct 23, 2018

@ansibot ansibot added the stale_ci label Nov 1, 2018

@acozine acozine moved this from To do to In progress in Ansible Core Documentation Nov 8, 2018

@ansibot ansibot added the docsite label Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment