New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "credentials" in the tower_job_template module #47545

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@dmsimard
Contributor

dmsimard commented Oct 24, 2018

SUMMARY

Job templates might require more than one credential.
There's credential, vault_credential, machine_credential, etc.
"credentials" is a thing, let's support it.

Fixes: #43234

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

tower_job_template

ANSIBLE VERSION

devel

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 24, 2018

Hi @dmsimard, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Add support for "credentials" in the tower_job_template module
Job templates might require more than one credential.
There's credential, vault_credential, machine_credential, etc.
"credentials" is a thing, let's support it.

@dmsimard dmsimard force-pushed the dmsimard:tower_credentials branch from 3e7c462 to 54b2865 Oct 24, 2018

@dmsimard

This comment has been minimized.

Contributor

dmsimard commented Oct 24, 2018

I'm not sure this works. Need to double check ...

@AlanCoding

This comment has been minimized.

Member

AlanCoding commented Oct 24, 2018

I don't expect that it would work, the associate command needs to be called for each credential in the list.

Providing that is done, it also needs to be combined with ansible/tower-cli#610 to work for all credential types.

module = TowerModule(
argument_spec=argument_spec,
supports_check_mode=True,
mutually_exclusive=[('credential', 'credentials')]

This comment has been minimized.

@AlanCoding

AlanCoding Oct 24, 2018

Member

You should also make it exclusive with vault_credential, which would be another tuple in this list.

@ansibot ansibot removed the needs_triage label Oct 24, 2018

@ansibot ansibot added the stale_ci label Nov 1, 2018

@mattclay

This comment has been minimized.

Member

mattclay commented Nov 5, 2018

@mattclay mattclay added the ci_verified label Nov 5, 2018

@ansibot ansibot removed the stale_ci label Nov 5, 2018

@ansibot ansibot added the stale_ci label Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment