Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPM plugcontrol for WTI Power Devices #47683

Merged
merged 5 commits into from Nov 30, 2018
Merged

CPM plugcontrol for WTI Power Devices #47683

merged 5 commits into from Nov 30, 2018

Conversation

syncpak
Copy link
Contributor

@syncpak syncpak commented Oct 26, 2018

SUMMARY

Added the module cpm_plugcontrol to be able to reboot, turn the power on and off with WTI Power devices.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

cpm_plugcontrol

ANSIBLE VERSION
ansible 2.8.0.dev0 (cpm_plugcontrol 75803e3d97) last updated 2018/10/26 09:21:37 (GMT -700)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/kenp/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/kenp/ansible/lib/ansible
  executable location = /home/kenp/ansible/bin/ansible
  python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 26, 2018

Hi @syncpak, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 26, 2018

@syncpak this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 26, 2018
@syncpak
Copy link
Contributor Author

syncpak commented Oct 26, 2018

Hi @samdoran, I am trying to check-in some new modules but I am getting my check-ins canceled.
All i can see is this error:

irc on_cancel: chat.freenode.net#ansible-notices
Validating input
Generating change view
Generating message
Generating build details
Generating triggered by details
Sending IRC notification
No connection returned for server: close

Is there something that i am missing?

Thanks

@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 26, 2018
@syncpak
Copy link
Contributor Author

syncpak commented Oct 26, 2018

Hi @samdoran, sorry, never mind, i needed to rebase the branch, sorry for bugging you.

@ansibot
Copy link
Contributor

ansibot commented Oct 26, 2018

@wtinetworkgear

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 26, 2018
@syncpak
Copy link
Contributor Author

syncpak commented Oct 26, 2018

@actionemb, @vientiane, @mattsene, @dmobergIT please note this is the new pull for the cpm_plugs (now named cpm_plugcontrol) module, there is another module coming to configure the plugs parameters.

@dmobergIT
Copy link

Got it, will look at it this week. Please also ping my when the Power Plug configuration is also done.

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Nov 1, 2018
@actionemb
Copy link

Do I need any BETA code for my CPM to get this new module to work ?

@syncpak
Copy link
Contributor Author

syncpak commented Nov 1, 2018

@actionemb for this module (cpm_plugcontrol) no BETA code is needed on your WTI device. That being said, make sure that have the latest release code for your CPM (v.6.56)

@syncpak
Copy link
Contributor Author

syncpak commented Nov 2, 2018

Hello @actionemb , @vientiane , @mattsene, @dmobergIT , there is a companion module for the plugs called cpm_plugconfig located here, #47989

@samdoran samdoran self-assigned this Nov 8, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 8, 2018
@mattsene
Copy link

mattsene commented Nov 9, 2018

Will this work with your VMR units ?

@actionemb
Copy link

I noticed that the status of the current state of the plug's state is "as of time of modules is run" Is there a way to get "what the plugs state is going to be?"

@mmorrisdev
Copy link

Where can i set the boot delay for the plugs?

@syncpak
Copy link
Contributor Author

syncpak commented Nov 15, 2018

@mmorrisdev we broke up the control and configuration of the plug, the configuration can be found here. #47989

@syncpak
Copy link
Contributor Author

syncpak commented Nov 21, 2018

shipit

2 similar comments
@mattsene
Copy link

shipit

@vientiane
Copy link

shipit

@gundalow gundalow added the remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html label Nov 22, 2018
@wtinetworkgear
Copy link

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 27, 2018
@scarshouldofwon
Copy link

shipit

@gundalow gundalow merged commit 19035db into ansible:devel Nov 30, 2018
@syncpak syncpak mentioned this pull request Dec 4, 2018
Closed
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@syncpak @kbreit
CPM plugcontrol for WTI Power Devices (ansible#47683)
7fafaf7 
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* remove unneeded legacy files

* Added the new module cpm_plugcontrol to control the plugs on WTI Power devices
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
@syncpak syncpak deleted the cpm_plugcontrol branch November 1, 2019 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@samdoran samdoran

Labels
affects_2.8 This issue/PR affects Ansible v2.8 module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet