New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding dynamodb module #47717

Open
wants to merge 16 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@blastik

blastik commented Oct 27, 2018

SUMMARY

Hello everybody,
This is my very first PR to a open source project so please be gentle ;)
I had the need to deal with AWS DynamoDB tables from Ansible so I created this module that reads, creates, updates or deletes single items.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

dynamodb

ANSIBLE VERSION
ansible 2.8.0.dev0 (add_dynamodb 0a2b84e1b8) last updated 2018/10/27 23:17:04 (GMT +200)
  config file = None
  configured module search path = ['/Users/user/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/user/Documents/Repos/ansible/lib/ansible
  executable location = /Users/user/Documents/Repos/ansible/bin/ansible
  python version = 3.6.4 (v3.6.4:d48ecebad5, Dec 18 2017, 21:07:28) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)]

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 27, 2018

Hi @blastik, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 27, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:304:20: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 720, in <module>
    main()
  File "../bin/plugin_formatter.py", line 678, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 269, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 99, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 62, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 35, in get_single_data
    node = self.get_single_node()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 82, in compose_node
    node = self.compose_sequence_node(anchor)
  File "/usr/local/lib/python3.6/dist-packages/yaml/composer.py", line 110, in compose_sequence_node
    while not self.check_event(SequenceEndEvent):
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/usr/local/lib/python3.6/dist-packages/yaml/parser.py", line 393, in parse_block_sequence_entry
    "expected <block end>, but found %r" % token.id, token.start_mark)
yaml.parser.ParserError: while parsing a block collection
  in "<unicode string>", line 6, column 3:
      - Reads, creates, updates or del ... 
      ^
expected <block end>, but found '?'
  in "<unicode string>", line 7, column 3:
      More infomation can be found here:
      ^
make: *** [modules] Error 1

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:146:0: ImportError: No module named boto3

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:146:0: ImportError: No module named boto3

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:146:0: ImportError: No module named 'boto3'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:146:0: ModuleNotFoundError: No module named 'boto3'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:146:0: ModuleNotFoundError: No module named 'boto3'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:248:9: E123 closing bracket does not match indentation of opening bracket's line

The test ansible-test sanity --test validate-modules [explain] failed with 7 errors:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E105 GPLv3 license header not found in the first 20 lines of the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E324 Value for "default" from the argument_spec (True) for "validate_certs" does not match the documentation (False)
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E326 Value for "choices" from the argument_spec (['get', 'put', 'update', 'delete']) for "action" does not match the documentation ([])
lib/ansible/modules/cloud/amazon/dynamodb.py:15:3: E302 DOCUMENTATION is not valid YAML
lib/ansible/modules/cloud/amazon/dynamodb.py:101:60: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 3 errors:

lib/ansible/modules/cloud/amazon/dynamodb.py:15:3: error DOCUMENTATION: syntax error: expected <block end>, but found '?'
lib/ansible/modules/cloud/amazon/dynamodb.py:101:60: error EXAMPLES: syntax error: expected <block end>, but found '}'
lib/ansible/modules/cloud/amazon/dynamodb.py:105:3: key-duplicates EXAMPLES: duplication of key "name" in mapping

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 27, 2018

@blastik, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 27, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:153:0: ImportError: No module named boto3

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:153:0: ImportError: No module named boto3

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:153:0: ImportError: No module named 'boto3'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:153:0: ModuleNotFoundError: No module named 'boto3'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:153:0: ModuleNotFoundError: No module named 'boto3'

The test ansible-test sanity --test validate-modules [explain] failed with 24 errors:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.description: expected a list for dictionary value @ data['options']['action']['description']. Got {'get': 'Returns a set of attributes for the item with the given primary key.', 'put': 'Creates a new item, or replaces an old item with a new item. If an item that has the same primary key as the new item already exists in the specified table, the new item completely replaces the existing item.', 'update': "Edits an existing item's attributes, or adds a new item to the table if it does not already exist. You can also perform a conditional update on an existing item (insert a new attribute na...
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.type: not a valid value for dictionary value @ data['options']['action']['type']. Got 'string'
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.condition_expression.type: not a valid value for dictionary value @ data['options']['condition_expression']['type']. Got 'string'
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.projection_expression.type: not a valid value for dictionary value @ data['options']['projection_expression']['type']. Got 'string'
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.table.type: not a valid value for dictionary value @ data['options']['table']['type']. Got 'string'
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.update_expression.type: not a valid value for dictionary value @ data['options']['update_expression']['type']. Got 'string'
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.requirements: expected a list for dictionary value @ data['requirements']. Got 'boto3'
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "access_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_url" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "profile" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "security_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "validate_certs" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E324 Value for "default" from the argument_spec (True) for "validate_certs" does not match the documentation (False)
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not
lib/ansible/modules/cloud/amazon/dynamodb.py:106:60: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/dynamodb.py:106:60: error EXAMPLES: syntax error: expected <block end>, but found '}'
lib/ansible/modules/cloud/amazon/dynamodb.py:110:3: key-duplicates EXAMPLES: duplication of key "name" in mapping

click here for bot help

@ansibot ansibot added the ci_verified label Oct 27, 2018

@blastik blastik force-pushed the blastik:add_dynamodb branch from ef74ce0 to 355d32d Oct 27, 2018

@ansibot ansibot removed the ci_verified label Oct 27, 2018

@blastik blastik force-pushed the blastik:add_dynamodb branch 2 times, most recently from 6d471a3 to ff42660 Oct 27, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 27, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test validate-modules [explain] failed with 22 errors:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.description: expected a list for dictionary value @ data['options']['action']['description']. Got {'get': 'Returns a set of attributes for the item with the given primary key.', 'put': 'Creates a new item, or replaces an old item with a new item. If an item that has the same primary key as the new item already exists in the specified table, the new item completely replaces the existing item.', 'update': "Edits an existing item's attributes, or adds a new item to the table if it does not already exist. You can also perform a conditional update on an existing item (insert a new attribute na...
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.type: not a valid value for dictionary value @ data['options']['action']['type']. Got 'string'
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.condition_expression.type: not a valid value for dictionary value @ data['options']['condition_expression']['type']. Got 'string'
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.projection_expression.type: not a valid value for dictionary value @ data['options']['projection_expression']['type']. Got 'string'
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.table.type: not a valid value for dictionary value @ data['options']['table']['type']. Got 'string'
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.update_expression.type: not a valid value for dictionary value @ data['options']['update_expression']['type']. Got 'string'
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "access_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_url" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "profile" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "security_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "validate_certs" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E324 Value for "default" from the argument_spec (True) for "validate_certs" does not match the documentation (False)
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not

click here for bot help

@blastik blastik force-pushed the blastik:add_dynamodb branch from ff42660 to bda7c62 Oct 27, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 28, 2018

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/cloud/amazon/dynamodb.py:41:161: E501 line too long (226 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:44:161: E501 line too long (324 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:47:161: E501 line too long (191 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:52:161: E501 line too long (223 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:60:161: E501 line too long (227 > 160 characters)

The test ansible-test sanity --test validate-modules [explain] failed with 20 errors:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.description.0: expected str @ data['options']['action']['description'][0]. Got {'get': None, 'description': ['Returns a set of attributes for the item with the given primary key.']}
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.description.1: expected str @ data['options']['action']['description'][1]. Got {'put': None, 'description': ['Creates a new item, or replaces an old item with a new item. If an item that has the same primary key as the new item already exists in the specified table, the new item completely replaces the existing item.']}
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.description.2: expected str @ data['options']['action']['description'][2]. Got {'update': None, 'description': ["Edits an existing item's attributes, or adds a new item to the table if it does not already exist. You can also perform a conditional update on an existing item (insert a new attribute name-value pair if it doesn't exist, or replace an existing name-value pair if it has certain expected attribute values)."]}
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.description.3: expected str @ data['options']['action']['description'][3]. Got {'delete': None, 'description': ['Deletes a single item in a table by primary key. You can perform a conditional delete operation that deletes the item if it exists, or if it has an expected attribute value.']}
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "access_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_url" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "profile" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "security_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "validate_certs" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E324 Value for "default" from the argument_spec (True) for "validate_certs" does not match the documentation (False)
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot added the ci_verified label Oct 28, 2018

@Akasurde

This comment has been minimized.

Member

Akasurde commented Oct 28, 2018

@blastik Thanks for the PR. Welcome on board !

@ansibot ansibot removed the ci_verified label Oct 29, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 29, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test pep8 [explain] failed with 8 errors:

lib/ansible/modules/cloud/amazon/dynamodb.py:41:161: E501 line too long (226 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:44:161: E501 line too long (324 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:47:161: E501 line too long (191 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:52:161: E501 line too long (223 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:60:161: E501 line too long (227 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:72:161: E501 line too long (263 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:230:17: E126 continuation line over-indented for hanging indent
lib/ansible/modules/cloud/amazon/dynamodb.py:234:13: E121 continuation line under-indented for hanging indent

The test ansible-test sanity --test validate-modules [explain] failed with 21 errors:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.description.0: expected str @ data['options']['action']['description'][0]. Got {'get': None, 'description': ['Returns a set of attributes for the item with the given primary key.']}
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.description.1: expected str @ data['options']['action']['description'][1]. Got {'put': None, 'description': ['Creates a new item, or replaces an old item with a new item. If an item that has the same primary key as the new item already exists in the specified table, the new item completely replaces the existing item.']}
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.description.2: expected str @ data['options']['action']['description'][2]. Got {'update': None, 'description': ["Edits an existing item's attributes, or adds a new item to the table if it does not already exist. You can also perform a conditional update on an existing item (insert a new attribute name-value pair if it doesn't exist, or replace an existing name-value pair if it has certain expected attribute values)."]}
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.action.description.3: expected str @ data['options']['action']['description'][3]. Got {'delete': None, 'description': ['Deletes a single item in a table by primary key. You can perform a conditional delete operation that deletes the item if it exists, or if it has an expected attribute value.']}
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E305 DOCUMENTATION.options.expression_attribute_names.description.0: expected str @ data['options']['expression_attribute_names']['description'][0]. Got {'One or more substitution tokens for attribute names in an expression to access an attribute whose name conflicts with a DynamoDB reserved word. Reserved keywords list': 'https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/ReservedWords.html'}
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "access_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_url" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "profile" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "security_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "validate_certs" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E324 Value for "default" from the argument_spec (True) for "validate_certs" does not match the documentation (False)
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot added ci_verified and removed ci_verified labels Oct 29, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 30, 2018

The test ansible-test sanity --test pep8 [explain] failed with 8 errors:

lib/ansible/modules/cloud/amazon/dynamodb.py:37:161: E501 line too long (226 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:38:161: E501 line too long (327 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:39:161: E501 line too long (194 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:42:161: E501 line too long (287 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:54:161: E501 line too long (223 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:72:161: E501 line too long (267 > 160 characters)
lib/ansible/modules/cloud/amazon/dynamodb.py:234:17: E126 continuation line over-indented for hanging indent
lib/ansible/modules/cloud/amazon/dynamodb.py:238:13: E121 continuation line under-indented for hanging indent

The test ansible-test sanity --test validate-modules [explain] failed with 17 errors:

lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "access_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "aws_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_access_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "ec2_url" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "profile" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "region" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "secret_key" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "security_token" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E322 "validate_certs" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E324 Value for "default" from the argument_spec (True) for "validate_certs" does not match the documentation (False)
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not
lib/ansible/modules/cloud/amazon/dynamodb.py:0:0: E326 Value for "choices" from the argument_spec (['get', 'put', 'update', 'delete']) for "action" does not match the documentation (["{'get': 'Returns a set of attributes for the item with the given primary key.'}", "{'put': 'Creates a new item, or replaces an old item with a new item. If an item that has the same primary key as the new item already exists in the specified table, the new item completely replaces the existing item.'}", '{\'update\': "Edits an existing item\'s attributes, or adds a new item to the table if it does not already exist. You can also perform a conditional update on an existing item (insert a new attribute name-value pair if it doesn\'t exist, or replace an existing name-value pair if it has certain expected attribute values)."}', "{'delete': 'Deletes a single item in a table by primary key. You can perform a conditional delete operation that deletes the item if it exists, or if it has an expected attribute value.'}"])

click here for bot help

@ansibot ansibot added the ci_verified label Oct 30, 2018

@blastik blastik changed the title from adding dynamodb module to [WIP] adding dynamodb module Nov 29, 2018

@blastik

This comment has been minimized.

blastik commented Nov 30, 2018

@flowerysong okay i think its ready_for_review
test in shippable are failing due missing permissions but i've added this policy to solve it

@blastik blastik changed the title from [WIP] adding dynamodb module to adding dynamodb module Nov 30, 2018

@ansibot ansibot removed the WIP label Nov 30, 2018

@blastik

This comment has been minimized.

blastik commented Nov 30, 2018

ready_for_review

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 5, 2018

@blastik this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@blastik blastik force-pushed the blastik:add_dynamodb branch from e2d74f1 to 6341840 Dec 5, 2018

@blastik

This comment has been minimized.

blastik commented Dec 11, 2018

@flowerysong @Akasurde any news on this ?
remeber: test in shippable are failing due missing permissions but i've added this policy to solve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment