New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust location for cloudstorageaccount modules #47875

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
6 participants
@wawrzek

wawrzek commented Oct 31, 2018

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module/cloud/azure

ANSIBLE VERSION
> /Users/wawrzek/Work/Others/ansible #>ansible --version  
  ansible 2.7.1
  config file = /Users/wawrzek/.ansible.cfg
  configured module search path = ['/Users/wawrzek/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/Cellar/ansible/2.7.1/libexec/lib/python3.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.7.0 (default, Oct  2 2018, 09:19:48) [Clang 9.0.0 (clang-900.0.39.2)]
SUMMARY

Trying to follow Ansible in Azure documentation I got following error:

"msg": "Do you have azure>=2.0.0 installed? Try `pip install ansible[azure]`- No module named 'azure.storage.cloudstorageaccount'"

Above message suggested to use pip. I was using brew. So I decided to looked at sources and found that simple adjusting cloudstorageaccount module import fixed it. Brew using vanilla azure-storage-common version 1.3.0, so it should work everywhere. Current path is for the file:

azure-storage-common-1.3.0/azure/storage/common/cloudstorageaccount.py

Wawrzyniec Niewodniczański
Adjust location for cloudstorageaccount modules
Possible that cloudstorageaccount.py has been moved. Current location:
azure-storage-common-1.3.0/azure/storage/common/cloudstorageaccount.py

Adjust import to above path
@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 31, 2018

Hi @wawrzek, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Oct 31, 2018

@wawrzek, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Nov 1, 2018

@wawrzek Thanks for the contribution, the lastest commit failed. I am Trying to follow Ansible in Azure documentation install ansible on Ubuntu and CentOS. All get successful result. Could you help give you test steps and OS/ Environment? I will try again. Thanks!

@wawrzek

This comment has been minimized.

wawrzek commented Nov 1, 2018

@Fred-sun - I ran it on MacOSX. Ansible and Azure module were installed with brew. What might be important is a version of azure-storage-common module/package. Could you please check what do you have? I hit more problem in my setup. I'm going to remove packages installed with brew and check pip.

Metadata-Version: 1.1
Name: azure-storage-common
Version: 1.3.0
Summary: Microsoft Azure Storage Common Client Library for Python
Home-page: https://github.com/Azure/azure-storage-python
Author: Microsoft Corporation
Author-email: ascl@microsoft.com
License: MIT License
Description-Content-Type: UNKNOWN
Description: Microsoft Azure Storage SDK for Python

@wawrzek

This comment has been minimized.

wawrzek commented Nov 1, 2018

I checked ansible from pip. It fine. It uses python 2.7 and ancient version of azure-storage library:

Metadata-Version: 2.0
Name: azure-storage
Version: 0.35.1
Summary: Microsoft Azure Storage Client Library for Python
Home-page: https://github.com/Azure/azure-storage-python
Author: Microsoft Corporation
Author-email: ptvshelp@microsoft.com
License: Apache License 2.0

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Nov 2, 2018

@wawrzek Thanks for your update, I will try later, Thanks!

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Nov 5, 2018

@yuwzho could you help test this on MACOSX, I have no this test environment. Thanks!

@mattclay

This comment has been minimized.

Member

mattclay commented Nov 5, 2018

@mattclay mattclay added the ci_verified label Nov 5, 2018

@ansibot ansibot added the stale_ci label Nov 13, 2018

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Nov 20, 2018

@wawrzek Thanks for your contribution. CI failure in integration tests. Could you help recheck this PR? Thanks !

@gundalow

This comment has been minimized.

Contributor

gundalow commented Nov 23, 2018

Tests failing with:
"msg": "Do you have azure>=2.0.0 installed? Try pip install ansible[azure]- No module named common.cloudstorageaccount"

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Nov 28, 2018

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Dec 6, 2018

@wawrzek Could you help retest this according by gundalow's comment? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment