New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: support Alicloud VPC module ali_vpc and ali_vpc_facts #47926

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@xiaozhu36
Contributor

xiaozhu36 commented Nov 1, 2018

SUMMARY

Added two new modules ali_vpc.py and ali_vpc_facts.py that can manage alicloud VPC network.

COMPONENT NAME

lib/ansible/modules/cloud/alicloud/ali_vpc.py
lib/ansible/modules/cloud/alicloud/ali_vpc_facts.py

ANSIBLE VERSION
ansible 2.6.1
@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

Hi @xiaozhu36, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

@xiaozhu36 this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

The test ansible-test sanity --test boilerplate [explain] failed with 2 errors:

lib/ansible/modules/cloud/alicloud/ali_vpc.py:0:0: missing: __metaclass__ = type
lib/ansible/modules/cloud/alicloud/ali_vpc.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/alicloud/ali_vpc.py:0:0: E324 Value for "default" from the argument_spec ('172.16.0.0/16') for "cidr_block" does not match the documentation ('172.16.0.0/12')
lib/ansible/modules/cloud/alicloud/ali_vpc.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "cidr_block" does not match the documentation (['10.0.0.0/8', '172.16.0.0/12', '192.168.0.0/16'])

click here for bot help

@ansibot ansibot added the ci_verified label Nov 1, 2018

@samdoran samdoran removed the needs_triage label Nov 1, 2018

@xiaozhu36 xiaozhu36 force-pushed the xiaozhu36:vpc branch from 0ab62a5 to 19007f2 Nov 2, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 2, 2018

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/alicloud/ali_vpc.py:79:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/alicloud/ali_vpc.py:93:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/alicloud/ali_vpc_facts.py:0:0: E323 "cidr_prefix" is listed in DOCUMENTATION.options, but not accepted by the module

click here for bot help

@xiaozhu36 xiaozhu36 force-pushed the xiaozhu36:vpc branch from 19007f2 to 4db98fc Nov 2, 2018

@ansibot ansibot removed the ci_verified label Nov 2, 2018

@xiaozhu36 xiaozhu36 force-pushed the xiaozhu36:vpc branch from 4db98fc to 76b2c43 Nov 2, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 2, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/alicloud/ali_vpc_facts.py:187:11: bad-whitespace Exactly one space required around assignment     vpc_ids=module.params['vpc_ids']            ^

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/alicloud/ali_vpc_facts.py:187:12: E225 missing whitespace around operator

click here for bot help

@ansibot ansibot added the ci_verified label Nov 2, 2018

@xiaozhu36 xiaozhu36 force-pushed the xiaozhu36:vpc branch from 76b2c43 to f46b852 Nov 2, 2018

@ansibot ansibot removed the ci_verified label Nov 2, 2018

@xiaozhu36 xiaozhu36 changed the title from New module: support Alibaba Cloud VPC module ali_vpc and ali_vpc_facts to New module: support Aliloud VPC module ali_vpc and ali_vpc_facts Nov 2, 2018

@xiaozhu36 xiaozhu36 changed the title from New module: support Aliloud VPC module ali_vpc and ali_vpc_facts to New module: support Alicloud VPC module ali_vpc and ali_vpc_facts Nov 2, 2018

@xiaozhu36 xiaozhu36 force-pushed the xiaozhu36:vpc branch from f46b852 to 459aadc Nov 6, 2018

@ansibot ansibot added the stale_ci label Nov 14, 2018

@xiaozhu36 xiaozhu36 force-pushed the xiaozhu36:vpc branch from 459aadc to 95a3faf Nov 26, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 26, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/alicloud/ali_vpc.py:0:0: E323 "vpc_id" is listed in DOCUMENTATION.options, but not accepted by the module

click here for bot help

@ansibot ansibot added ci_verified and removed stale_ci labels Nov 26, 2018

@xiaozhu36 xiaozhu36 force-pushed the xiaozhu36:vpc branch from 95a3faf to b3de47a Nov 26, 2018

@ansibot ansibot removed the ci_verified label Nov 26, 2018

@xiaozhu36 xiaozhu36 force-pushed the xiaozhu36:vpc branch from b3de47a to 0f12098 Nov 27, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 27, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/alicloud/ali_vpc.py:98:1: W293 blank line contains whitespace

click here for bot help

@ansibot ansibot added the ci_verified label Nov 27, 2018

@xiaozhu36 xiaozhu36 force-pushed the xiaozhu36:vpc branch from 0f12098 to 856d9f4 Nov 27, 2018

@ansibot ansibot removed the ci_verified label Nov 27, 2018

@ansibot ansibot added the stale_ci label Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment