New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Fix VM guest customizaton for VLAN/Network configuration only #47930

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@moshloop

moshloop commented Nov 1, 2018

The fixes in #24768 for #24193 did not work completely for my use case (CoreOS with Network / VLAN selection only) - This solution proposed here does work:
#24193 (comment)

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

Hi @moshloop, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

@moshloop, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest.py:2041:9: E303 too many blank lines (2)

click here for bot help

# Find if we need network customizations
customize_network = False
for network in self.params['networks']:
if 'ip' in network or 'netmask' in network or 'domain' in network:

This comment has been minimized.

@Akasurde

Akasurde Nov 2, 2018

Member
Suggested change Beta
if 'ip' in network or 'netmask' in network or 'domain' in network:
if any([i in network for i in ['ip', 'domain', 'netmask']])
@Akasurde

This comment has been minimized.

Member

Akasurde commented Nov 2, 2018

@pdellaert @dericcrago @Im0 @tchernomax @ckotte Could you please review this ?

@Akasurde Akasurde changed the title from Fix VM guest customizaton for VLAN/Network configuration only to VMware: Fix VM guest customizaton for VLAN/Network configuration only Nov 2, 2018

@ansibot ansibot added the stale_ci label Nov 10, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment