New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_guest: improve vlan -> network search with many dvps #47936

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@moshloop

moshloop commented Nov 1, 2018

This improves the performance of mapping a vlan id to a network name with many (2000+) distributed port groups.

I know it is quite hacky - looking for some ideas about how to clean it up and cater for all edge cases.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

Hi @moshloop, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

@moshloop: in order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

@moshloop, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 1, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_guest.py:1175:21: undefined-variable Undefined variable 'logger'

The test ansible-test sanity --test pep8 [explain] failed with 29 errors:

lib/ansible/modules/cloud/vmware/vmware_guest.py:1139:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1139:10: E713 test for membership should be 'not in'
lib/ansible/modules/cloud/vmware/vmware_guest.py:1140:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1142:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1143:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1144:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1145:14: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1147:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1148:14: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1149:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1151:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1153:14: E125 continuation line with same indent as next logical line
lib/ansible/modules/cloud/vmware/vmware_guest.py:1154:14: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1175:22: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1176:22: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1220:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/vmware/vmware_guest.py:1221:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1221:10: E713 test for membership should be 'not in'
lib/ansible/modules/cloud/vmware/vmware_guest.py:1222:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1224:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1225:7: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1226:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1227:14: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1229:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1230:14: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1231:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1233:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/vmware/vmware_guest.py:1235:14: E125 continuation line with same indent as next logical line
lib/ansible/modules/cloud/vmware/vmware_guest.py:1236:14: E111 indentation is not a multiple of four

click here for bot help

@mattclay

This comment has been minimized.

Member

mattclay commented Nov 5, 2018

@mattclay mattclay added the ci_verified label Nov 5, 2018

@ansibot ansibot added the stale_ci label Nov 13, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 21, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment