New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 fixes for ansible.spec #4850
2 fixes for ansible.spec #4850
Conversation
There is a previous pull request to "fix" the SuSE rpm build. |
Might be useful to link the ticket number :) |
The earlier pull request is #4689 |
@dermute Please split the second fix out into a new pull request. |
Just my 2 cents on this patch: As to "#2: remove refs to absent man pages": @mpdehaan originally uploaded an incomplete tarball to PyPI for release 1.3.4 (see issue #4804) which didn't contain the man3 manpages, @dermute probably based this patch on that incomplete tarball. That portion of the patch is therefore no longer necessary. As to "#1: fix for SLES build": The clause "BuildArch: noarch" only works for openSUSE versions later than 11.1 and must therefore be encapuslated in an appropriate %if clause ("%if %{?suse_version: %{suse_version} > 1110} %{!?suse_version:1}"). This patch will therefore not work on openSUSE 11.1 and earlier. You may want to consider my pull request #5042 which doesn't have that deficiency. That pull request also includes the appropriate %fdupes stuff which is required for the package to be accepted by rpmlint on build.opensuse.org. Also, please consider cherry-picking commit 2f25330 from pull request #5042 which contains fixes to ansible.spec that are unrelated to SUSE and thus of general use. Thanks. |
Fix 1: SLES build:
Fix 2: remove refs to absent man pages (man3):