New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend changes in #45953 to vmware_guest_disk #48618

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@jeking3
Contributor

jeking3 commented Nov 13, 2018

SUMMARY

Extended the changes from #45953 (existing disks in vmware_guest) to vmware_guest_disk.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest_disk

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 13, 2018

Hi @jeking3, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 13, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 13, 2018

@jeking3, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 13, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/vmware.py:1237:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_disk.py:346:56: undefined-variable Undefined variable 'long'
lib/ansible/modules/cloud/vmware/vmware_guest_disk.py:564:19: unneeded-not Consider changing "not 'size' in current_disk" to "'size' not in current_disk"

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/module_utils/vmware.py:1235:20: E111 indentation is not a multiple of four
lib/ansible/module_utils/vmware.py:1237:1: W391 blank line at end of file
lib/ansible/modules/cloud/vmware/vmware_guest_disk.py:564:20: E713 test for membership should be 'not in'

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 22, 2018

@ansibot ansibot added the stale_ci label Nov 22, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment