New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add redis cache facts #48652

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@yungezz
Contributor

yungezz commented Nov 14, 2018

SUMMARY

will add tests later

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@yungezz yungezz requested a review from zikalino Nov 14, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 14, 2018

Hi @yungezz, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 14, 2018

@yungezz, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 14, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:139:20: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:95:17: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:95:17: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot added the ci_verified label Nov 14, 2018

:return: dict
'''
new_result = {}
new_result['id'] = rediscache.id

This comment has been minimized.

@zikalino

zikalino Nov 14, 2018

Contributor

you can create entire dictionary at once

@ansibot ansibot removed the needs_triage label Nov 14, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 15, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:0: syntax-error invalid syntax (<unknown>, line 295)

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
cat _themes/srtd/static/css/theme.css | sed -e 's/^[ 	]*//g; s/[ 	]*$//g; s/\([:{;,]\) /\1/g; s/ {/{/g; s/\/\*.*\*\///g; /^$/d' | sed -e :a -e '$!N; s/\n\(.\)/\1/; ta' > _themes/srtd/static/css/theme.min.css
PYTHONPATH=../../lib ../bin/dump_config.py --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ -d ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../bin/generate_man.py --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../bin/dump_keywords.py --template-dir=../templates --output-dir=rst/reference_appendices/ -d ./keyword_desc.yml
PYTHONPATH=../../lib ../bin/plugin_formatter.py -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../bin/plugin_formatter.py", line 720, in <module>
    main()
  File "../bin/plugin_formatter.py", line 678, in main
    plugin_info, categories = get_plugin_info(options.module_dir, limit_to=options.limit_to, verbose=(options.verbosity > 0))
  File "../bin/plugin_formatter.py", line 269, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 99, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 43, in read_docstring
    M = ast.parse(b_module_data.read())
  File "/usr/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<unknown>", line 295
    resource_group=re.sub('\\/.*', '', re.sub('.*resourceGroups\\/', '', rediscache.id))
                 ^
SyntaxError: invalid syntax
make: *** [modules] Error 1

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:26: SyntaxError: resource_group=re.sub('\\/.*', '', re.sub('.*resourceGroups\\/', '', rediscache.id))

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:26: SyntaxError: resource_group=re.sub('\\/.*', '', re.sub('.*resourceGroups\\/', '', rediscache.id))

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:26: SyntaxError: resource_group=re.sub('\\/.*', '', re.sub('.*resourceGroups\\/', '', rediscache.id))

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:26: SyntaxError: resource_group=re.sub('\\/.*', '', re.sub('.*resourceGroups\\/', '', rediscache.id))

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:26: SyntaxError: resource_group=re.sub('\\/.*', '', re.sub('.*resourceGroups\\/', '', rediscache.id))

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:26: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:26: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:26: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:26: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:26: SyntaxError: invalid syntax

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:306:34: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:295:26: python-syntax-error invalid syntax (<unknown>, line 295)

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 15, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:95:21: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:95:21: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot added ci_verified and removed ci_verified labels Nov 15, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 15, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:95:21: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:95:21: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot added the stale_ci label Nov 23, 2018

@yungezz

This comment has been minimized.

Contributor

yungezz commented Nov 26, 2018

add tests after redis cache merged

@Fred-sun

This comment has been minimized.

Contributor

Fred-sun commented Nov 26, 2018

@yungezz I have tested this PR and get successful result, Does this PR ready for review? could you can remove the WIP label ?

yungezz added some commits Nov 15, 2018

@yungezz yungezz force-pushed the VSChina:yungez-rediscache-facts branch from 3da85ae to b273a8d Nov 30, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 30, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_rediscache_facts.py:0:0: E305 DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got ['Yunge Zhu <yungez@microsoft.com>']

click here for bot help

@ansibot ansibot added ci_verified and removed stale_ci labels Nov 30, 2018

@ansibot ansibot added the stale_ci label Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment