New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session tracing support for network_cli, netconf, httapi connection #48655

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@ganeshrn
Member

ganeshrn commented Nov 14, 2018

SUMMARY
  • Add persistent_log_messages configuration option to log device inteaction
    in the log file for network_cli, netconf and httapi connection
    type
  • Log jsonrpc request and response in the log file if the configuration option
    is enabled
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

bin/ansible-connection
network_cli
netconf
httpapi

ADDITIONAL INFORMATION

@ganeshrn ganeshrn requested review from Qalthos and privateip Nov 14, 2018

Add session tracing support for network_cli, netconf and httapi conne…
…ction

*  Add `persistent_log_messages` configuration option to log device inteaction
   in log file for network_cli, netconf and httapi connection
   type
*  Log jsonrpc request and response in log file is configuration option
   is enabled

@ganeshrn ganeshrn force-pushed the ganeshrn:log_device_interaction branch from 8317fa2 to abf0f1b Nov 14, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 14, 2018

Hi @ganeshrn, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 14, 2018

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst:142:0: reference-target-not-found: 'envvar' reference target not found: ANSIBLE_PERSISTENT_LOG_MESSAGES

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/plugins/connection/network_cli.py:403:73: E226 missing whitespace around arithmetic operator
lib/ansible/plugins/connection/network_cli.py:417:69: E226 missing whitespace around arithmetic operator

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Nov 14, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 14, 2018

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst:142:0: reference-target-not-found: 'envvar' reference target not found: ANSIBLE_PERSISTENT_LOG_MESSAGES

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment