New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepend 'ANSIBLE' to overlooked variables, define DEFAULT_VERBOSITY constant #48802

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@tb3088

tb3088 commented Nov 16, 2018

SUMMARY

a simple grep turned up settings that didn't have ANSIBLE_ prepended to the environment variable. Also trying to use ANSIBLE_VERBOSITY=N failed during parser.add_option() because the constant was not defined.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Config

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 16, 2018

Hi @tb3088, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 16, 2018

@tb3088 this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@tb3088

This comment has been minimized.

tb3088 commented Nov 16, 2018

Does the Shippable config need to be toned down on parallelism? It's hitting quota limit on instance slots.

@mattclay

This comment has been minimized.

Member

mattclay commented Nov 16, 2018

@tb3088 There was an issue with the CI AWS account which has been fixed. I've restarted the tests.

@ansibot ansibot added core_review and removed needs_revision labels Nov 16, 2018

@@ -1314,7 +1314,7 @@ DISPLAY_SKIPPED_HOSTS:
name: Show skipped results
default: True
description: "Toggle to control displaying skipped task/host entries in a task in the default callback"
env: [{name: DISPLAY_SKIPPED_HOSTS}]
env: [{name: ANSIBLE_DISPLAY_SKIPPED_HOSTS}]

This comment has been minimized.

@bcoca

bcoca Nov 16, 2018

Member

you can add a new variable, don't just remove the old one, it requires a deprecation period

@ansibot ansibot added needs_revision and removed core_review labels Nov 16, 2018

@sivel sivel removed the needs_triage label Nov 20, 2018

@ansibot ansibot added the stale_ci label Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment