Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix lastpass lookup error #48804
The lastpass lookup plugin fails with
Due to my limited Python experience this fix is primarily based on the way similar stuff is done in the onepass plugin (and testing of course).
2 times, most recently
Nov 16, 2018
This failed due to different behaviour on python 2 and 3.
From the Shippable tests it appears to have succeeded on python 2, but not on python 3.
I have it running locally with python 3.7.1 (Shippable is 3.7.0 it appears).
This is probably beyond my understanding of Python (tried to Google around to get wiser -- no success yet
I took a look and I believe this will fix things. However, there are some other problems with the separation of bytes and text in this plugin which will affect whether this is the right fix or not.
When we fix
Which one do we want to do?