New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sophos UTM - add module to handle utm aaa group entries #48926

Closed
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@MatrixCrawler
Contributor

MatrixCrawler commented Nov 20, 2018

SUMMARY

This PR will add a module to the sophos utm namespace to handle the aaa group entries.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • utm_aaa_group
@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 20, 2018

Hi @MatrixCrawler, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 20, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 20, 2018

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:20:8: W291 trailing whitespace
lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:38:45: W291 trailing whitespace
lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:42:36: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:0:0: E322 "adirectory_groups_sids" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:0:0: E322 "comment" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:0:0: E323 "adirectory_groups_ids" is listed in DOCUMENTATION.options, but not accepted by the module

click here for bot help

@Akasurde Akasurde removed the needs_triage label Nov 20, 2018

Update lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_grou…
…p.py


Added missing . at end of decription

Co-Authored-By: MatrixCrawler <johannes.brunswicker@gmail.com>

@ansibot ansibot removed the ci_verified label Nov 21, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 21, 2018

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:20:8: W291 trailing whitespace
lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:38:45: W291 trailing whitespace
lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:42:36: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:0:0: E322 "adirectory_groups_sids" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:0:0: E322 "comment" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/web_infrastructure/sophos_utm/utm_aaa_group.py:0:0: E323 "adirectory_groups_ids" is listed in DOCUMENTATION.options, but not accepted by the module

click here for bot help

@ansibot ansibot added the ci_verified label Nov 21, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 21, 2018

@MatrixCrawler this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@getjack

This comment has been minimized.

getjack commented Dec 13, 2018

@MatrixCrawler Please rebase the branch or close this PR to support my duplicate so we can shipit ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment