New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Correct powerstate options in vmware_guest_powerstate #48976

Closed
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@thetuxracer

thetuxracer commented Nov 21, 2018

Corrected hyphenation for powerstates, setting powerstate fails with hyphenated values.

+label: docsite_pr

SUMMARY

Using some of the exact values in the manual to manipulate the powerstate of VMs throws errors, because they are garbage values that pyvmomi doesnt recognize.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

vmware_guest_powerstate

ADDITIONAL INFORMATION

Before change:

fatal: [localhost]: FAILED! => {"changed": false, "msg": "value of state must be one of: absent, poweredoff, poweredon, present, rebootguest, restarted, shutdownguest, suspended, got: reboot-guest"}
Update vmware_guest_powerstate.py
Corrected hyphenation for powerstates, setting powerstate fails with hyphenated values.

+label: docsite_pr
@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 21, 2018

Hi @thetuxracer, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 21, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 21, 2018

@thetuxracer, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@Akasurde

This comment has been minimized.

Member

Akasurde commented Nov 21, 2018

@thetuxracer Thanks for reporting this issue / PR. Could you please provide the playbook which reproduce this error message ? Thanks.

@Akasurde Akasurde self-requested a review Nov 21, 2018

@Akasurde Akasurde changed the title from Correct powerstate options in vmware_guest_powerstate to VMware: Correct powerstate options in vmware_guest_powerstate Nov 21, 2018

@thetuxracer

This comment has been minimized.

thetuxracer commented Nov 22, 2018

@thetuxracer Thanks for reporting this issue / PR. Could you please provide the playbook which reproduce this error message ? Thanks.

Here you go:
https://gist.github.com/thetuxracer/09f6d1b26a657b6abc94e44ef0a69508

Thank you.

@Akasurde

This comment has been minimized.

Member

Akasurde commented Nov 22, 2018

@thetuxracer Thanks for the snippet. I see you are using vmware_guest module and this PR is related to vmware_guest_powerstate. I can not reproduce the error specified using vmware_guest_powerstate module, Can you confirm ? Thanks.

needs_info

@ansibot ansibot added the needs_info label Nov 22, 2018

@thetuxracer

This comment has been minimized.

thetuxracer commented Nov 23, 2018

@Akasurde You're right, I messed up between the two modules. Apologies for the same.

Also, since I have your attention here (and I tried reaching out on #ansible irc), can you tell me what needs to go here? If you have a rough doc, I would be more that happy to send in a patch.

Thanks.

@ansibot ansibot removed the needs_info label Nov 23, 2018

@Akasurde

This comment has been minimized.

Member

Akasurde commented Nov 24, 2018

@thetuxracer Thanks for reaching out to me. I was on OOO. I don't have rough doc as such but in that doc we are trying to cover basics of Ansible VMware setup. I have added SSL requirement in https://docs.ansible.com/ansible/devel/vmware/vmware_requirements.html. You can add things which you feel required for getting started in VMware environment. We can always improvise on that.
Thanks.

@ansibot ansibot added the stale_ci label Dec 5, 2018

@Akasurde

This comment has been minimized.

Member

Akasurde commented Dec 10, 2018

Closing this PR as "configuration issue".

@Akasurde Akasurde closed this Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment