New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ECR Lifecycle Policies to ecs_ecr #48997

Open
wants to merge 12 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@SpamapS
Contributor

SpamapS commented Nov 21, 2018

SUMMARY

Add support for ECR Lifecycle Policies to ecs_ecr. Fixes #32003

ISSUE TYPE
Feature Pull Request
COMPONENT NAME

ecs_ecr

ANSIBLE VERSION

ansible 2.4.0.0
config file = /Users/dlee/.ansible.cfg
configured module search path = [u'/Users/dlee/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/Cellar/ansible/2.4.0.0/libexec/lib/python2.7/site-packages/ansible
executable location = /usr/local/bin/ansible
python version = 2.7.14 (default, Sep 25 2017, 09:53:22) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.37)]

ADDITIONAL INFORMATION

Integration tests provided, and they pass.

PLAY RECAP *********************************************************************
localhost : ok=55 changed=8 unreachable=0 failed=0

leedm777 and others added some commits Oct 25, 2017

Add support for lifecycle policies to ecs_ecr
New feature for ecs_ecr to support [ECR Lifecycle Policies][].

Fixes #32003

 [ECR Lifecycle Policies]: https://docs.aws.amazon.com/AmazonECR/latest/userguide/LifecyclePolicies.html
Improve error message for ecs_ecr parsing errors
Replaces the exception and stack trace with a description of what's
actually going wrong from a user perspective.
Rename delete policy to purge policy
Marks the `delete_policy` parameter as deprecated, to be removed in
Ansible 2.6.
Remove changing results based on verbosity
What I really want is --diff support, and changing results based on
verbosity is abnormal.
@SpamapS

This comment has been minimized.

Contributor

SpamapS commented Nov 21, 2018

Rebased #32137

@sivel sivel changed the title from ##### SUMMARY to Add support for ECR Lifecycle Policies to ecs_ecr Nov 21, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 21, 2018

Hi @SpamapS, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 21, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 21, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/amazon/ecs_ecr.py:0:0: E309 version_added for new option (lifecycle_policy) should be 2.8. Currently 2.5
lib/ansible/modules/cloud/amazon/ecs_ecr.py:0:0: E309 version_added for new option (purge_lifecycle_policy) should be 2.8. Currently 2.5
lib/ansible/modules/cloud/amazon/ecs_ecr.py:0:0: E309 version_added for new option (purge_policy) should be 2.8. Currently 2.5

click here for bot help

Updating version_added and deprecation cycle
The original PR sat while a few releases happened.

@ansibot ansibot removed the ci_verified label Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment