git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678)#49000
Open
ju2wheels wants to merge 4 commits intoansible:develfrom
Open
Conversation
Contributor
|
Hi @ju2wheels, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
ju2wheels
force-pushed
the
feature/48678
branch
from
da600d4 to
f70ead2
Compare
ansibot
added
core_review
abadger
removed
the
needs_triage
webknjaz
reviewed
Nov 27, 2018
Member
|
@HD650 please look at this as well if you have time. |
webknjaz
reviewed
Nov 27, 2018
ansibot
added
the
stale_ci
ansibot
removed
the
stale_ci
ju2wheels
force-pushed
the
feature/48678
branch
from
f70ead2 to
510294f
Compare
ansibot
added
the
stale_ci
ju2wheels
force-pushed
the
feature/48678
branch
from
510294f to
de42929
Compare
ansibot
added
support:community
ju2wheels
force-pushed
the
feature/48678
branch
from
25c7fe8 to
67b7972
Compare
ansibot
added
the
stale_ci
ansibot
added
needs_rebase
ju2wheels
force-pushed
the
feature/48678
branch
2 times, most recently
from
8463967 to
7afaea2
Compare
ansibot
removed
needs_rebase
ju2wheels
force-pushed
the
feature/48678
branch
2 times, most recently
from
312f890 to
c4a40dd
Compare
ansibot
added
core_review
webknjaz
reviewed
Jun 12, 2019
webknjaz
approved these changes
Jun 12, 2019
ansibot
added
needs_rebase
…eter, and cleanup parameter support verification. (ansible#48678) - First PR to partially resolve ansible-pull always doing a recusrive clone. ansible#48678 git: Update integration tests to account for recursive submodule init changes (ansible#48678) - Update tests to account for that fact that a one level submodule is not considered "recursive" anymore. Add changelog fragment. (ansible#48678) Update the release version on the added module parameters. (48678) Switch git submodule integration tests to use find module instead of command and ls to check clone contents. (ansible#48678) Note: `ls -1a` includes the elipses for parent and current directory in the listing, but using the find module will not include those, so all file counts are reduced by 2.
ju2wheels
commented
Aug 22, 2019
Author
ju2wheels
left a comment
ju2wheels
left a comment
There was a problem hiding this comment.
Resolved this by removing remote repos and using dynamically created local ones.
… on older git versions. (ansible#48678)
Contributor
|
The test |
Contributor
|
The test |
…f git where its not supported. (ansible#48678)
Author
|
@webknjaz unit tests have been updated to dynamically create local repos for testing instead of using remote repos. Hopefully this makes the unit test cases clearer and easier to follow. Let me know if there are any other concerns. Would I need to put this PR through core review again? |
|
Any ETA when this will be merged? |
Author
|
Unless some one else picks it up and runs with it, probably never. I rebased this at least two times and went to their meetings on IRC following their release process to get follow up and feedback once and got nothing. I tried... I found another way to do what I was trying to do with the related PRs linked to this one, so I wont be putting further effort into trying to get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
SUMMARY
git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678)
ISSUE TYPE
COMPONENT NAME
git
ADDITIONAL INFORMATION