Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678) #49000

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678) #49000

wants to merge 4 commits into from
+369 −138

Conversation

ju2wheels
Copy link

…

SUMMARY

git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

git

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2018

Hi @ju2wheels, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 21, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 21, 2018
@abadger abadger removed the needs_triage Needs a first human triage before being processed. label Nov 27, 2018
@abadger abadger requested a review from webknjaz November 27, 2018 21:26
@abadger abadger added the P3 Priority 3 - Approved, No Time Limitation label Nov 27, 2018
@webknjaz
Copy link
Member

@HD650 please look at this as well if you have time.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 5, 2018
@ju2wheels ju2wheels closed this Jan 12, 2019
@ju2wheels ju2wheels reopened this Jan 12, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 12, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 22, 2019
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 24, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 6, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 22, 2019
@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 22, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/git/tasks/submodules.yml:268:128: error syntax error: expected <block end>, but found '<scalar>'

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 22, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/git/tasks/submodules.yml:268:186: error syntax error: expected <block end>, but found '<scalar>'

click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 22, 2019
@ju2wheels
Copy link
Author

@webknjaz unit tests have been updated to dynamically create local repos for testing instead of using remote repos. Hopefully this makes the unit test cases clearer and easier to follow.

Let me know if there are any other concerns.

Would I need to put this PR through core review again?

@ju2wheels ju2wheels mentioned this pull request Aug 23, 2019
Closed
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 30, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 3, 2020
@ansibot ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 5, 2020
@ansibot ansibot removed the support:community This issue/PR relates to code supported by the Ansible community. label Mar 5, 2021
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed has_issue labels Jul 12, 2023
@ksalman
Copy link

ksalman commented Oct 5, 2023

Any ETA when this will be merged?

@ju2wheels
Copy link
Author

Unless some one else picks it up and runs with it, probably never. I rebased this at least two times and went to their meetings on IRC following their release process to get follow up and feedback once and got nothing. I tried...

I found another way to do what I was trying to do with the related PRs linked to this one, so I wont be putting further effort into trying to get this merged.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxamillion maxamillion maxamillion left review comments

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. P3 Priority 3 - Approved, No Time Limitation pre_azp This PR was last tested before migration to Azure Pipelines. source_control Source-control category stale_review Updates were made after the last review and the last review is more than 7 days old. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ju2wheels @ansibot @webknjaz @ksalman @maxamillion @abadger