git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678) #49000

ju2wheels · 2018-11-21T19:57:33Z

…

SUMMARY

git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678)

First PR to partially resolve ansible-pull always doing a recusrive clone. #48678

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

git

ADDITIONAL INFORMATION

ansibot · 2018-11-21T20:04:54Z

Hi @ju2wheels, thank you for submitting this pull-request!

click here for bot help

test/integration/targets/git/vars/main.yml

webknjaz · 2018-11-27T21:49:05Z

@HD650 please look at this as well if you have time.

lib/ansible/modules/source_control/git.py

ju2wheels

Resolved this by removing remote repos and using dynamically created local ones.

test/integration/targets/git/tasks/submodules.yml

test/integration/targets/git/vars/main.yml

… on older git versions. (ansible#48678)

…ard compat. (ansible#48678)

ansibot · 2019-08-22T17:25:11Z

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/git/tasks/submodules.yml:268:128: error syntax error: expected <block end>, but found '<scalar>'

click here for bot help

ansibot · 2019-08-22T17:50:15Z

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/git/tasks/submodules.yml:268:186: error syntax error: expected <block end>, but found '<scalar>'

click here for bot help

…f git where its not supported. (ansible#48678)

ju2wheels · 2019-08-22T18:08:13Z

@webknjaz unit tests have been updated to dynamically create local repos for testing instead of using remote repos. Hopefully this makes the unit test cases clearer and easier to follow.

Let me know if there are any other concerns.

Would I need to put this PR through core review again?

ju2wheels force-pushed the feature/48678 branch from da600d4 to f70ead2 Compare Nov 21, 2018

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 21, 2018

abadger removed the needs_triage Needs a first human triage before being processed. label Nov 27, 2018

abadger requested a review from webknjaz Nov 27, 2018

abadger added the P3 Priority 3 - Approved, No Time Limitation label Nov 27, 2018

webknjaz reviewed Nov 27, 2018

View changes

test/integration/targets/git/vars/main.yml Outdated Show resolved Hide resolved

webknjaz reviewed Nov 27, 2018

View changes

lib/ansible/modules/source_control/git.py Show resolved Hide resolved

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 5, 2018

ju2wheels closed this Jan 12, 2019

ju2wheels reopened this Jan 12, 2019

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 12, 2019

ju2wheels force-pushed the feature/48678 branch from f70ead2 to 510294f Compare Jan 12, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 22, 2019

ju2wheels force-pushed the feature/48678 branch from 510294f to de42929 Compare Jan 24, 2019

ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 24, 2019

ju2wheels force-pushed the feature/48678 branch from 25c7fe8 to 67b7972 Compare Jan 29, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 6, 2019

ju2wheels reviewed Aug 22, 2019

View changes

test/integration/targets/git/tasks/submodules.yml Outdated Show resolved Hide resolved

test/integration/targets/git/vars/main.yml Outdated Show resolved Hide resolved

test/integration/targets/git/vars/main.yml Outdated Show resolved Hide resolved

Remove git_config module call and replace it with command so it works…

9bb2ed1

… on older git versions. (ansible#48678)

ju2wheels force-pushed the feature/48678 branch from 8368b86 to 9bb2ed1 Compare Aug 22, 2019

ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 22, 2019

Dont explicitly add --local which is default for git config for backw…

66599c0

…ard compat. (ansible#48678)

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 22, 2019

ju2wheels force-pushed the feature/48678 branch from 9d369b8 to 7382e45 Compare Aug 22, 2019

Update submodule tracking unit test for backward compat on versions o…

f9ef756

…f git where its not supported. (ansible#48678)

ju2wheels force-pushed the feature/48678 branch from 7382e45 to f9ef756 Compare Aug 22, 2019

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 22, 2019

ju2wheels mentioned this pull request Aug 23, 2019

Public Ansible Project Meeting Agenda - Aug 2019 ansible/community#482

Closed

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 30, 2019

ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 5, 2020

ansibot removed the support:community This issue/PR relates to code supported by the Ansible community. label Mar 5, 2021

git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678) #49000

git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678) #49000

ju2wheels commented Nov 21, 2018

ansibot commented Nov 21, 2018

webknjaz commented Nov 27, 2018

ju2wheels left a comment

ansibot commented Aug 22, 2019

ansibot commented Aug 22, 2019

ju2wheels commented Aug 22, 2019

git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678) #49000

Are you sure you want to change the base?

git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678) #49000

Conversation

ju2wheels commented Nov 21, 2018

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibot commented Nov 21, 2018

webknjaz commented Nov 27, 2018

ju2wheels left a comment

ansibot commented Aug 22, 2019

ansibot commented Aug 22, 2019

ju2wheels commented Aug 22, 2019