Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678) #49000

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

ju2wheels
Copy link

@ju2wheels ju2wheels commented Nov 21, 2018

SUMMARY

git: add explicit submodule_init parameter, add submodule_depth parameter, and cleanup parameter support verification. (#48678)

  • First PR to partially resolve ansible-pull always doing a recusrive clone. #48678
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

git

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

@ansibot ansibot commented Nov 21, 2018

Hi @ju2wheels, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 core_review feature module needs_triage new_contributor support:core needs_revision and removed core_review labels Nov 21, 2018
@ansibot ansibot added core_review and removed needs_revision labels Nov 21, 2018
@abadger abadger removed the needs_triage label Nov 27, 2018
@abadger abadger requested a review from webknjaz Nov 27, 2018
@abadger abadger added the P3 label Nov 27, 2018
@webknjaz
Copy link
Member

@webknjaz webknjaz commented Nov 27, 2018

@HD650 please look at this as well if you have time.

@ansibot ansibot added the stale_ci label Dec 5, 2018
@ju2wheels ju2wheels closed this Jan 12, 2019
@ju2wheels ju2wheels reopened this Jan 12, 2019
@ansibot ansibot removed the stale_ci label Jan 12, 2019
@ansibot ansibot added the stale_ci label Jan 22, 2019
@ansibot ansibot added support:community and removed stale_ci labels Jan 24, 2019
@ansibot ansibot added the stale_ci label Feb 6, 2019
Copy link
Author

@ju2wheels ju2wheels left a comment

Resolved this by removing remote repos and using dynamically created local ones.

test/integration/targets/git/tasks/submodules.yml Outdated Show resolved Hide resolved
test/integration/targets/git/vars/main.yml Outdated Show resolved Hide resolved
test/integration/targets/git/vars/main.yml Outdated Show resolved Hide resolved
@ansibot ansibot added core_review needs_ci stale_ci and removed needs_rebase stale_ci needs_revision labels Aug 22, 2019
@ansibot ansibot removed needs_ci stale_ci labels Aug 22, 2019
@ansibot
Copy link
Contributor

@ansibot ansibot commented Aug 22, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/git/tasks/submodules.yml:268:128: error syntax error: expected <block end>, but found '<scalar>'

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Aug 22, 2019
@ansibot
Copy link
Contributor

@ansibot ansibot commented Aug 22, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/git/tasks/submodules.yml:268:186: error syntax error: expected <block end>, but found '<scalar>'

click here for bot help

@ansibot ansibot added core_review and removed needs_revision labels Aug 22, 2019
@ju2wheels
Copy link
Author

@ju2wheels ju2wheels commented Aug 22, 2019

@webknjaz unit tests have been updated to dynamically create local repos for testing instead of using remote repos. Hopefully this makes the unit test cases clearer and easier to follow.

Let me know if there are any other concerns.

Would I need to put this PR through core review again?

@ansibot ansibot added the stale_ci label Aug 30, 2019
@ansibot ansibot added needs_rebase needs_revision and removed core_review labels Mar 3, 2020
@ansibot ansibot added pre_azp and removed stale_ci labels Dec 5, 2020
@ansibot ansibot removed the support:community label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.8 feature has_issue module needs_rebase needs_revision new_contributor P3 pre_azp source_control support:core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants