New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: New module vmware_host_tcpip_stacks #49087

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@ckotte
Contributor

ckotte commented Nov 24, 2018

SUMMARY

New module to configure different settings of the system TCP/IP stacks as well as the default gateway of the default TCP/IP stack.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vmware_host_tcpip_stacks

ADDITIONAL INFORMATION

This module complements vmware_host_dns (#47271) where you can configure DNS settings of the default TCP/IP stack and vmware_vmkernel (#47270) where you can assign a new VMkernel adapter to a TCP/IP stack.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 24, 2018

Hi @ckotte, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 24, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 24, 2018

@MikeKlebolt @Akasurde @bedecarroll @CastawayEGR @chrrrles @dav1x @garbled1 @imjoseangel @jjahns @kamsz @kryptsi @lrivallain @nafpliot-ibm @nerzhul @oboukili @rhoop @ritzk @rmin @stravassac @tchernomax @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@Akasurde

Rest LGTM. Could you please try to add test case for this change ? I am not sure if VCSIM provides this functionality.

@ckotte ckotte force-pushed the ckotte:vmware_host_tcpip_stacks branch 2 times, most recently from 8082b30 to 2f3ffe9 Dec 4, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 4, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_host_tcpip_stacks.py:390:50: undefined-variable Undefined variable 'unicode'

click here for bot help

@ansibot ansibot added the ci_verified label Dec 4, 2018

- debug: var=host1
- name: Configure TCP/IP stacks
vmware_host_tcpip_stacks:

This comment has been minimized.

@Akasurde

Akasurde Dec 10, 2018

Member

Could you please run this task again to check idempotence of this module ? Thanks

This comment has been minimized.

@ckotte

ckotte Dec 10, 2018

Contributor

Any specific reason? I changed unicode to six to get rid of the Flake8 warning...

@ckotte ckotte force-pushed the ckotte:vmware_host_tcpip_stacks branch from 2f3ffe9 to 32849d4 Dec 10, 2018

@ansibot ansibot removed the ci_verified label Dec 10, 2018

@ansibot

This comment was marked as resolved.

Contributor

ansibot commented Dec 10, 2018

The test ansible-test sanity --test use-compat-six [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_host_tcpip_stacks.py:156:1: use `ansible.module_utils.six` instead of `six`

click here for bot help

@ansibot ansibot added the ci_verified label Dec 10, 2018

@ckotte ckotte force-pushed the ckotte:vmware_host_tcpip_stacks branch from 32849d4 to f0f1351 Dec 10, 2018

@ansibot ansibot removed the ci_verified label Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment