New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: New module to support BGP configuration management in IOS #49121

Open
wants to merge 10 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@NilashishC
Contributor

NilashishC commented Nov 26, 2018

SUMMARY
  • Added new module - ios_bgp
  • This module provides configuration management of global BGP parameters
    on devices running Cisco IOS
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ios_bgp.py

ANSIBLE VERSION
devel

NilashishC added some commits Nov 22, 2018

ios_bgp initial push
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Added tests for ios_bgp
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Fixed docs
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Added space
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

@NilashishC NilashishC changed the title from WIP: New module - ios_bgp to WIP: New module to support BGP configuration management in IOS Nov 26, 2018

Fix Shippable Errors
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 26, 2018

Hi @NilashishC, thank you for submitting this pull-request!

click here for bot help

@ansibot

This comment has been minimized.

Fix Shippable Errors
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC

This comment has been minimized.

Contributor

NilashishC commented Nov 26, 2018

One of the sanity checks is expecting __init__s to be empty, hence failing for module_utils/network/ios/bgp/__init__.py and bgp/config/__init__.py. Need to discuss with @privateip regarding this.

@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 26, 2018

The test ansible-test sanity --test empty-init [explain] failed with 2 errors:

lib/ansible/module_utils/network/ios/config/__init__.py:0:0: empty __init__.py required
lib/ansible/module_utils/network/ios/config/bgp/__init__.py:0:0: empty __init__.py required

click here for bot help

@ansibot ansibot added the ci_verified label Nov 26, 2018

@NilashishC NilashishC requested a review from privateip Nov 27, 2018

Add support for af_neighbor option
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

NilashishC added some commits Dec 3, 2018

Add support for af_neighbor option - 2
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Add support for af_neighbor option - 3
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

@ansibot ansibot removed the ci_verified label Dec 3, 2018

@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 3, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:36:0: syntax-error invalid syntax (&lt;unknown&gt;, line 36)

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:36:27: SyntaxError: 'remove_private_as': dict(type='bool'),

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:36:27: SyntaxError: 'remove_private_as': dict(type='bool'),

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:36:27: SyntaxError: 'remove_private_as': dict(type='bool'),

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:36:27: SyntaxError: 'remove_private_as': dict(type='bool'),

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:36:27: SyntaxError: 'remove_private_as': dict(type='bool'),

The test ansible-test sanity --test empty-init [explain] failed with 2 errors:

lib/ansible/module_utils/network/ios/config/__init__.py:0:0: empty __init__.py required
lib/ansible/module_utils/network/ios/config/bgp/__init__.py:0:0: empty __init__.py required

The test ansible-test sanity --test import --python 2.6 [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/config/bgp/address_family.py:33:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)
lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:36:27: SyntaxError: invalid syntax
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/bgp/address_family.py:33:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)

The test ansible-test sanity --test import --python 2.7 [explain] failed with 4 errors:

lib/ansible/module_utils/network/ios/config/bgp/address_family.py:33:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)
lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:36:27: SyntaxError: invalid syntax
lib/ansible/modules/network/ios/ios_bgp.py:302:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/bgp/address_family.py:33:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)

The test ansible-test sanity --test import --python 3.5 [explain] failed with 4 errors:

lib/ansible/module_utils/network/ios/config/bgp/address_family.py:33:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)
lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:36:27: SyntaxError: invalid syntax
lib/ansible/modules/network/ios/ios_bgp.py:302:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/bgp/address_family.py:33:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)

The test ansible-test sanity --test import --python 3.6 [explain] failed with 4 errors:

lib/ansible/module_utils/network/ios/config/bgp/address_family.py:33:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)
lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:36:27: SyntaxError: invalid syntax
lib/ansible/modules/network/ios/ios_bgp.py:302:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/bgp/address_family.py:33:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)

The test ansible-test sanity --test import --python 3.7 [explain] failed with 4 errors:

lib/ansible/module_utils/network/ios/config/bgp/address_family.py:33:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)
lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:36:27: SyntaxError: invalid syntax
lib/ansible/modules/network/ios/ios_bgp.py:302:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/bgp/address_family.py:33:0: SyntaxError: invalid syntax (af_neighbor.py, line 36)

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:60:16: E111 indentation is not a multiple of four
lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:112:1: W293 blank line contains whitespace
lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:112:1: W391 blank line at end of file
lib/ansible/modules/network/ios/ios_bgp.py:205:68: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_bgp.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'invalid syntax (af_neighbor.py, line 36)'

click here for bot help

Fix typo
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansibot

This comment has been minimized.

Contributor

ansibot commented Dec 3, 2018

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/user_guide/playbooks_strategies.rst:23:0: duplicate-label: duplicate label strategy_plugins, other instance in /root/ansible/docs/docsite/rst/plugins/strategy.rst

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:112:8: SyntaxError:

The test ansible-test sanity --test empty-init [explain] failed with 2 errors:

lib/ansible/module_utils/network/ios/config/__init__.py:0:0: empty __init__.py required
lib/ansible/module_utils/network/ios/config/bgp/__init__.py:0:0: empty __init__.py required

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:60:16: E111 indentation is not a multiple of four
lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:112:1: W293 blank line contains whitespace
lib/ansible/module_utils/network/ios/config/bgp/af_neighbor.py:112:1: W391 blank line at end of file
lib/ansible/modules/network/ios/ios_bgp.py:205:68: W291 trailing whitespace

click here for bot help

@ansibot ansibot added the stale_ci label Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment